oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

lib/kadm5: improve kadm_c_ error handling

Browse Source 
Perform error checking for each function call and consistently return
errors at the point of failure.

Refactor functions to use a common exit path.  Preserve error messages
stored in the kadm5_client_context.context when appropriate.

Change-Id: I7aa04020e4de3454066f0d88ba805fed999dbd1a
This commit is contained in:
Jeffrey Altman
2018-06-20 23:47:16 -04:00
committed by Nico Williams
parent 622c4ded2f
commit 50ebc1491a
9 changed files with 370 additions and 231 deletions
Download Patch File Download Diff File Expand all files Collapse all files

95
lib/kadm5/chpass_c.c
View File

@@ -62,33 +62,46 @@ kadm5_c_chpass_principal(void *server_handle,
if (ret)
return ret;
krb5_data_zero(&reply);
sp = krb5_storage_from_mem(buf, sizeof(buf));
if (sp == NULL) {
krb5_clear_error_message(context->context);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_store_int32(sp, kadm_chpass);
krb5_store_principal(sp, princ);
krb5_store_string(sp, password);
krb5_store_int32(sp, keepold); /* extension */
ret = _kadm5_client_send(context, sp);
krb5_storage_free(sp);
ret = krb5_store_int32(sp, kadm_chpass);
if (ret)
return ret;
goto out;
ret = krb5_store_principal(sp, princ);
if (ret)
goto out;
ret = krb5_store_string(sp, password);
if (ret)
goto out;
ret = krb5_store_int32(sp, keepold); /* extension */
if (ret)
goto out;
ret = _kadm5_client_send(context, sp);
if (ret)
goto out_keep_error;
ret = _kadm5_client_recv(context, &reply);
if (ret)
return ret;
goto out_keep_error;
krb5_storage_free(sp);
sp = krb5_storage_from_data(&reply);
if (sp == NULL) {
krb5_clear_error_message(context->context);
krb5_data_free (&reply);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_ret_int32(sp, &tmp);
ret = krb5_ret_int32(sp, &tmp);
if (ret == 0)
ret = tmp;
out:
krb5_clear_error_message(context->context);
krb5_storage_free(sp);
krb5_data_free(&reply);
return tmp;
return ret;
}
kadm5_ret_t
@@ -110,33 +123,51 @@ kadm5_c_chpass_principal_with_key(void *server_handle,
if (ret)
return ret;
krb5_data_zero(&reply);
sp = krb5_storage_from_mem(buf, sizeof(buf));
if (sp == NULL) {
krb5_clear_error_message(context->context);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_store_int32(sp, kadm_chpass_with_key);
krb5_store_principal(sp, princ);
krb5_store_int32(sp, n_key_data);
for (i = 0; i < n_key_data; ++i)
kadm5_store_key_data (sp, &key_data[i]);
krb5_store_int32(sp, keepold); /* extension */
ret = _kadm5_client_send(context, sp);
krb5_storage_free(sp);
ret = krb5_store_int32(sp, kadm_chpass_with_key);
if (ret)
return ret;
goto out;
ret = krb5_store_principal(sp, princ);
if (ret)
goto out;
ret = krb5_store_int32(sp, n_key_data);
if (ret)
goto out;
for (i = 0; i < n_key_data; ++i) {
ret = kadm5_store_key_data (sp, &key_data[i]);
if (ret)
goto out;
}
ret = krb5_store_int32(sp, keepold); /* extension */
if (ret)
goto out;
ret = _kadm5_client_send(context, sp);
if (ret)
goto out_keep_error;
ret = _kadm5_client_recv(context, &reply);
if (ret)
return ret;
goto out_keep_error;
krb5_storage_free(sp);
sp = krb5_storage_from_data (&reply);
if (sp == NULL) {
krb5_clear_error_message(context->context);
krb5_data_free (&reply);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_ret_int32(sp, &tmp);
ret = krb5_ret_int32(sp, &tmp);
if (ret == 0)
ret = tmp;
out:
krb5_clear_error_message(context->context);
out_keep_error:
krb5_storage_free(sp);
krb5_data_free(&reply);
return tmp;
return ret;
}

45
lib/kadm5/create_c.c
View File

@@ -62,32 +62,47 @@ kadm5_c_create_principal(void *server_handle,
if (ret)
return ret;
krb5_data_zero(&reply);
sp = krb5_storage_from_mem(buf, sizeof(buf));
if (sp == NULL) {
krb5_clear_error_message(context->context);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_store_int32(sp, kadm_create);
kadm5_store_principal_ent(sp, princ);
krb5_store_int32(sp, mask);
krb5_store_string(sp, password);
ret = _kadm5_client_send(context, sp);
krb5_storage_free(sp);
ret = krb5_store_int32(sp, kadm_create);
if (ret)
return ret;
goto out;
ret = kadm5_store_principal_ent(sp, princ);
if (ret)
goto out;
ret = krb5_store_int32(sp, mask);
if (ret)
goto out;
ret = krb5_store_string(sp, password);
if (ret)
goto out;
ret = _kadm5_client_send(context, sp);
if (ret)
goto out_keep_error;
ret = _kadm5_client_recv(context, &reply);
if (ret)
return ret;
goto out_keep_error;
krb5_storage_free(sp);
sp = krb5_storage_from_data(&reply);
if (sp == NULL) {
krb5_clear_error_message(context->context);
krb5_data_free (&reply);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_ret_int32(sp, &tmp);
ret = krb5_ret_int32(sp, &tmp);
if (ret == 0)
ret = tmp;
out:
krb5_clear_error_message(context->context);
out_keep_error:
krb5_storage_free(sp);
krb5_data_free(&reply);
return tmp;
return ret;
}

37
lib/kadm5/delete_c.c
View File

@@ -49,29 +49,40 @@ kadm5_c_delete_principal(void *server_handle, krb5_principal princ)
if (ret)
return ret;
krb5_data_zero(&reply);
sp = krb5_storage_from_mem(buf, sizeof(buf));
if (sp == NULL) {
krb5_clear_error_message(context->context);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_store_int32(sp, kadm_delete);
krb5_store_principal(sp, princ);
ret = _kadm5_client_send(context, sp);
krb5_storage_free(sp);
ret = krb5_store_int32(sp, kadm_delete);
if (ret)
return ret;
goto out;
ret = krb5_store_principal(sp, princ);
if (ret)
goto out;
ret = _kadm5_client_send(context, sp);
if (ret)
goto out_keep_error;
ret = _kadm5_client_recv(context, &reply);
if (ret)
return ret;
goto out_keep_error;
krb5_storage_free(sp);
sp = krb5_storage_from_data(&reply);
if (sp == NULL) {
krb5_clear_error_message(context->context);
krb5_data_free (&reply);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_ret_int32(sp, &tmp);
ret = krb5_ret_int32(sp, &tmp);
if (ret == 0)
ret = tmp;
out:
krb5_clear_error_message(context->context);
out_keep_error:
krb5_storage_free(sp);
krb5_data_free(&reply);
return tmp;
return ret;
}

46
lib/kadm5/get_c.c
View File

@@ -38,7 +38,7 @@ RCSID("$Id$");
kadm5_ret_t
kadm5_c_get_principal(void *server_handle,
krb5_principal princ,
kadm5_principal_ent_t out,
kadm5_principal_ent_t ent,
uint32_t mask)
{
kadm5_client_context *context = server_handle;
@@ -52,32 +52,44 @@ kadm5_c_get_principal(void *server_handle,
if (ret)
return ret;
krb5_data_zero(&reply);
sp = krb5_storage_from_mem(buf, sizeof(buf));
if (sp == NULL) {
krb5_clear_error_message(context->context);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_store_int32(sp, kadm_get);
krb5_store_principal(sp, princ);
krb5_store_int32(sp, mask);
ret = _kadm5_client_send(context, sp);
krb5_storage_free(sp);
ret = krb5_store_int32(sp, kadm_get);
if (ret)
return ret;
goto out;
ret = krb5_store_principal(sp, princ);
if (ret)
goto out;
ret = krb5_store_int32(sp, mask);
if (ret)
goto out;
ret = _kadm5_client_send(context, sp);
if (ret)
goto out_keep_error;
ret = _kadm5_client_recv(context, &reply);
if (ret)
return ret;
goto out_keep_error;
krb5_storage_free(sp);
sp = krb5_storage_from_data(&reply);
if (sp == NULL) {
krb5_clear_error_message(context->context);
krb5_data_free (&reply);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_ret_int32(sp, &tmp);
ret = tmp;
krb5_clear_error_message(context->context);
ret = krb5_ret_int32(sp, &tmp);
if (ret == 0)
kadm5_ret_principal_ent(sp, out);
ret = tmp;
out:
krb5_clear_error_message(context->context);
out_keep_error:
if (ret == 0)
kadm5_ret_principal_ent(sp, ent);
krb5_storage_free(sp);
krb5_data_free(&reply);
return ret;

65
lib/kadm5/get_princs_c.c
View File

@@ -47,45 +47,72 @@ kadm5_c_get_principals(void *server_handle,
unsigned char buf[1024];
int32_t tmp;
krb5_data reply;
int i;
*count = 0;
*princs = NULL;
ret = _kadm5_connect(server_handle);
if (ret)
return ret;
krb5_data_zero(&reply);
sp = krb5_storage_from_mem(buf, sizeof(buf));
if (sp == NULL)
return ENOMEM;
krb5_store_int32(sp, kadm_get_princs);
krb5_store_int32(sp, expression != NULL);
if(expression)
krb5_store_string(sp, expression);
ret = _kadm5_client_send(context, sp);
krb5_storage_free(sp);
if (sp == NULL) {
ret = ENOMEM;
goto out;
}
ret = krb5_store_int32(sp, kadm_get_princs);
if (ret)
return ret;
goto out;
ret = krb5_store_int32(sp, expression != NULL);
if (ret)
goto out;
if (expression) {
ret = krb5_store_string(sp, expression);
if (ret)
goto out;
}
ret = _kadm5_client_send(context, sp);
if (ret)
goto out_keep_error;
ret = _kadm5_client_recv(context, &reply);
if (ret)
return ret;
goto out_keep_error;
krb5_storage_free(sp);
sp = krb5_storage_from_data (&reply);
if (sp == NULL) {
krb5_data_free (&reply);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_ret_int32(sp, &tmp);
ret = krb5_ret_int32(sp, &tmp);
if (ret == 0)
ret = tmp;
if(ret == 0) {
int i;
krb5_ret_int32(sp, &tmp);
if (ret)
goto out;
ret = krb5_ret_int32(sp, &tmp);
if (ret)
goto out;
*princs = calloc(tmp + 1, sizeof(**princs));
if (*princs == NULL) {
ret = ENOMEM;
goto out;
}
for(i = 0; i < tmp; i++)
krb5_ret_string(sp, &(*princs)[i]);
*count = tmp;
for (i = 0; i < tmp; i++) {
ret = krb5_ret_string(sp, &(*princs)[i]);
if (ret)
goto out;
}
*count = tmp;
out:
krb5_clear_error_message(context->context);
out_keep_error:
krb5_storage_free(sp);
krb5_data_free(&reply);
return ret;

42
lib/kadm5/modify_c.c
View File

@@ -51,31 +51,43 @@ kadm5_c_modify_principal(void *server_handle,
if (ret)
return ret;
krb5_data_zero(&reply);
sp = krb5_storage_from_mem(buf, sizeof(buf));
if (sp == NULL) {
krb5_clear_error_message(context->context);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_store_int32(sp, kadm_modify);
kadm5_store_principal_ent(sp, princ);
krb5_store_int32(sp, mask);
ret = _kadm5_client_send(context, sp);
krb5_storage_free(sp);
ret = krb5_store_int32(sp, kadm_modify);
if (ret)
return ret;
goto out;
ret = kadm5_store_principal_ent(sp, princ);
if (ret)
goto out;
ret = krb5_store_int32(sp, mask);
if (ret)
goto out;
ret = _kadm5_client_send(context, sp);
if (ret)
goto out_keep_error;
ret = _kadm5_client_recv(context, &reply);
if (ret)
return ret;
goto out_keep_error;
krb5_storage_free(sp);
sp = krb5_storage_from_data(&reply);
if (sp == NULL) {
krb5_clear_error_message(context->context);
krb5_data_free (&reply);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_ret_int32(sp, &tmp);
ret = krb5_ret_int32(sp, &tmp);
if (ret == 0)
ret = tmp;
out:
krb5_clear_error_message(context->context);
out_keep_error:
krb5_storage_free(sp);
krb5_data_free(&reply);
return tmp;
return ret;
}

35
lib/kadm5/privs_c.c
View File

@@ -51,31 +51,38 @@ kadm5_c_get_privs(void *server_handle, uint32_t *privs)
if (ret)
return ret;
krb5_data_zero(&reply);
sp = krb5_storage_from_mem(buf, sizeof(buf));
if (sp == NULL) {
krb5_clear_error_message(context->context);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_store_int32(sp, kadm_get_privs);
ret = _kadm5_client_send(context, sp);
krb5_storage_free(sp);
ret = krb5_store_int32(sp, kadm_get_privs);
if (ret)
return ret;
goto out;
ret = _kadm5_client_send(context, sp);
if (ret)
goto out_keep_error;
ret = _kadm5_client_recv(context, &reply);
if (ret)
return ret;
goto out_keep_error;
krb5_storage_free(sp);
sp = krb5_storage_from_data(&reply);
if (sp == NULL) {
krb5_clear_error_message(context->context);
krb5_data_free (&reply);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_ret_int32(sp, &tmp);
krb5_clear_error_message(context->context);
ret = krb5_ret_int32(sp, &tmp);
if (ret == 0)
ret = tmp;
if(ret == 0){
if (ret == 0)
krb5_ret_uint32(sp, privs);
}
out:
krb5_clear_error_message(context->context);
out_keep_error:
krb5_storage_free(sp);
krb5_data_free (&reply);
return ret;

37
lib/kadm5/randkey_c.c
View File

@@ -51,15 +51,18 @@ kadm5_c_randkey_principal(void *server_handle,
int32_t tmp;
size_t i;
krb5_data reply;
krb5_keyblock *k;
ret = _kadm5_connect(server_handle);
if (ret)
return ret;
krb5_data_zero(&reply);
sp = krb5_storage_from_mem(buf, sizeof(buf));
if (sp == NULL) {
krb5_clear_error_message(context->context);
return ENOMEM;
ret = ENOMEM;
goto out;
}
/*
@@ -92,29 +95,27 @@ kadm5_c_randkey_principal(void *server_handle,
if (ret == 0)
krb5_store_int32(sp, ks_tuple[i].ks_salttype);
}
if (ret)
return ret;
/* Future extensions go here */
if (ret)
goto out;
ret = _kadm5_client_send(context, sp);
krb5_storage_free(sp);
if (ret)
return ret;
goto out_keep_error;
ret = _kadm5_client_recv(context, &reply);
if (ret)
return ret;
goto out_keep_error;
krb5_storage_free(sp);
sp = krb5_storage_from_data(&reply);
if (sp == NULL) {
krb5_clear_error_message(context->context);
krb5_data_free (&reply);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_clear_error_message(context->context);
ret = krb5_ret_int32(sp, &tmp);
if (ret == 0)
ret = tmp;
if (ret == 0){
krb5_keyblock *k;
if (ret)
goto out;
ret = krb5_ret_int32(sp, &tmp);
if (ret)
@@ -128,8 +129,11 @@ kadm5_c_randkey_principal(void *server_handle,
ret = ENOMEM;
goto out;
}
for(i = 0; ret == 0 && i < tmp; i++)
for (i = 0; ret == 0 && i < tmp; i++) {
ret = krb5_ret_keyblock(sp, &k[i]);
if (ret)
goto out;
}
if (ret == 0 && n_keys && new_keys) {
*n_keys = tmp;
*new_keys = k;
@@ -139,8 +143,11 @@ kadm5_c_randkey_principal(void *server_handle,
krb5_free_keyblock_contents(context->context, &k[i - 1]);
free(k);
}
}
out:
krb5_clear_error_message(context->context);
out_keep_error:
krb5_storage_free(sp);
krb5_data_free(&reply);
return ret;

41
lib/kadm5/rename_c.c
View File

@@ -51,26 +51,43 @@ kadm5_c_rename_principal(void *server_handle,
if (ret)
return ret;
krb5_data_zero(&reply);
sp = krb5_storage_from_mem(buf, sizeof(buf));
if (sp == NULL)
return ENOMEM;
krb5_store_int32(sp, kadm_rename);
krb5_store_principal(sp, source);
krb5_store_principal(sp, target);
ret = _kadm5_client_send(context, sp);
krb5_storage_free(sp);
if (sp == NULL) {
ret = ENOMEM;
goto out;
}
ret = krb5_store_int32(sp, kadm_rename);
if (ret)
return ret;
goto out;
ret = krb5_store_principal(sp, source);
if (ret)
goto out;
ret = krb5_store_principal(sp, target);
if (ret)
goto out;
ret = _kadm5_client_send(context, sp);
if (ret)
goto out_keep_error;
ret = _kadm5_client_recv(context, &reply);
if (ret)
return ret;
goto out_keep_error;
krb5_storage_free(sp);
sp = krb5_storage_from_data(&reply);
if (sp == NULL) {
krb5_data_free (&reply);
return ENOMEM;
ret = ENOMEM;
goto out;
}
krb5_ret_int32(sp, &tmp);
ret = krb5_ret_int32(sp, &tmp);
if (ret == 0)
ret = tmp;
out:
krb5_clear_error_message(context->context);
out_keep_error:
krb5_storage_free(sp);
krb5_data_free(&reply);
return ret;