oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

asn1: Trade template crash for leak (AFL)

Browse Source 
Yesterday's fix for an unlikely leak in the template interpreter
introduced a crash found by American Fuzzy Lop (AFL).
This commit is contained in:
Nicolas Williams
2021-03-03 10:16:45 -06:00
parent a0f542486e
commit 4eff66a2cd
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/asn1/template.c
View File

@@ -1059,10 +1059,8 @@ _asn1_decode(const struct asn1_template *t, unsigned flags,
ret = _asn1_decode(t->ptr, flags & (~A1_PF_INDEFINTE), p, len, ret = _asn1_decode(t->ptr, flags & (~A1_PF_INDEFINTE), p, len,
DPO(el->val, vallength), &newsize); DPO(el->val, vallength), &newsize);
if (ret) { if (ret)
_asn1_free(t->ptr, DPO(el->val, vallength));
return ret; return ret;
}
vallength = newlen; vallength = newlen;
el->len++; el->len++;
p += newsize; len -= newsize; p += newsize; len -= newsize;