oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

kdc: Use HDB_AUTHSTATUS_INVALID to mark that the status has not be set yet

Browse Source 
-1 is unclear, so use a named constant.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Andrew Bartlett
2021-12-17 10:44:13 +13:00
committed by Luke Howard
parent 93deac696f
commit 4a2e40a5b6
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
kdc/kerberos5.c
View File

@@ -881,7 +881,7 @@ pa_enc_ts_validate(astgs_request_t r,
} }
free_EncryptedData(&enc_data); free_EncryptedData(&enc_data);
free(auth_status->free_ptr); free(auth_status->free_ptr);
auth_status->auth_status = -1; auth_status->auth_status = HDB_AUTHSTATUS_INVALID;
auth_status->auth_details = NULL; auth_status->auth_details = NULL;
auth_status->free_ptr = NULL; auth_status->free_ptr = NULL;
ret = decode_PA_ENC_TS_ENC(ts_data.data, ret = decode_PA_ENC_TS_ENC(ts_data.data,
@@ -2167,7 +2167,7 @@ _kdc_as_rep(astgs_request_t r)
i = 0; i = 0;
pa = _kdc_find_padata(req, &i, pat[n].type); pa = _kdc_find_padata(req, &i, pat[n].type);
if (pa) { if (pa) {
struct kdc_pa_auth_status auth_status = {-1, NULL, NULL}; struct kdc_pa_auth_status auth_status = {HDB_AUTHSTATUS_INVALID, NULL, NULL};
if (r->client->entry.flags.synthetic && if (r->client->entry.flags.synthetic &&
!(pat[n].flags & PA_SYNTHETIC_OK)) { !(pat[n].flags & PA_SYNTHETIC_OK)) {
@@ -2183,7 +2183,7 @@ _kdc_as_rep(astgs_request_t r)
Key *ckey = NULL; Key *ckey = NULL;
krb5_boolean default_salt; krb5_boolean default_salt;
if (auth_status.auth_status == -1) if (auth_status.auth_status == HDB_AUTHSTATUS_INVALID)
auth_status.auth_status = HDB_AUTHSTATUS_GENERIC_FAILURE; auth_status.auth_status = HDB_AUTHSTATUS_GENERIC_FAILURE;
_kdc_audit_auth_status(r, _kdc_audit_auth_status(r,
&auth_status, &auth_status,
@@ -2211,7 +2211,7 @@ _kdc_as_rep(astgs_request_t r)
r->replaced_reply_key = (pat[n].flags & PA_REPLACE_REPLY_KEY) != 0; r->replaced_reply_key = (pat[n].flags & PA_REPLACE_REPLY_KEY) != 0;
if (auth_status.auth_status == -1) if (auth_status.auth_status == HDB_AUTHSTATUS_INVALID)
auth_status.auth_status = HDB_AUTHSTATUS_GENERIC_SUCCESS; auth_status.auth_status = HDB_AUTHSTATUS_GENERIC_SUCCESS;
_kdc_audit_auth_status(r, _kdc_audit_auth_status(r,