oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

base: avoid unnecessary allocation of "reason" key

Browse Source 
"reason" key is unused, don't allocate it
This commit is contained in:
Luke Howard
2022-01-03 16:19:49 +11:00
parent 097a3de44e
commit 44a8cf1747
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/base/log.c
View File

@@ -699,7 +699,10 @@ fmtkv(int flags, const char *k, const char *fmt, va_list ap)
} else } else
value_vis = value; value_vis = value;
kv.key = heim_string_create(k); if (k)
kv.key = heim_string_create(k);
else
kv.key = NULL;
kv.value = heim_string_ref_create(value_vis, free); kv.value = heim_string_ref_create(value_vis, free);
return kv; return kv;
@@ -711,8 +714,8 @@ heim_audit_vaddreason(heim_svc_req_desc r, const char *fmt, va_list ap)
{ {
struct heim_audit_kv_tuple kv; struct heim_audit_kv_tuple kv;
kv = fmtkv(HEIM_SVC_AUDIT_VISLAST, "reason", fmt, ap); kv = fmtkv(HEIM_SVC_AUDIT_VISLAST, NULL, fmt, ap);
if (kv.key == NULL || kv.value == NULL) { if (kv.value == NULL) {
heim_log(r->hcontext, r->logf, 1, "heim_audit_vaddreason: " heim_log(r->hcontext, r->logf, 1, "heim_audit_vaddreason: "
"failed to add reason (out of memory)"); "failed to add reason (out of memory)");
return; return;
@@ -733,7 +736,6 @@ heim_audit_vaddreason(heim_svc_req_desc r, const char *fmt, va_list ap)
} }
heim_release(r->reason); heim_release(r->reason);
r->reason = kv.value; r->reason = kv.value;
heim_release(kv.key);
} }
void void