oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

gss: fix leak in add_builtin() if interning OID fails

Browse Source 
4a93c477 (#447) introduced a leak in add_builtin().  Reported by
jaltman@auristor.com.
This commit is contained in:
Luke Howard
2018-12-23 15:34:27 +11:00
parent 6d7b0bfd17
commit 3c92747f2a
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/gssapi/mech/gss_mech_switch.c
View File

@@ -217,8 +217,10 @@ add_builtin(gssapi_mech_interface mech)
m->gm_so = NULL; m->gm_so = NULL;
m->gm_mech = *mech; m->gm_mech = *mech;
_gss_intern_oid(&minor_status, &mech->gm_mech_oid, &m->gm_mech_oid); _gss_intern_oid(&minor_status, &mech->gm_mech_oid, &m->gm_mech_oid);
if (minor_status) if (minor_status) {
free(m);
return minor_status; return minor_status;
}
gss_add_oid_set_member(&minor_status, gss_add_oid_set_member(&minor_status,
&m->gm_mech.gm_mech_oid, &_gss_mech_oids); &m->gm_mech.gm_mech_oid, &_gss_mech_oids);