Fixes to make Heimdal -Wall -Werror clean

These fixes make developer mode build, at least on Ubuntu.
This commit is contained in:
Nicolas Williams
2011-11-02 21:39:07 -05:00
parent 9c830f5237
commit 3bebbe5323
24 changed files with 286 additions and 172 deletions

View File

@@ -44,6 +44,7 @@ kcm_ccache_refresh(krb5_context context,
krb5_kdc_flags flags;
krb5_const_realm realm;
krb5_ccache_data ccdata;
const char *estr;
memset(&in, 0, sizeof(in));
@@ -66,8 +67,10 @@ kcm_ccache_refresh(krb5_context context,
if (ccache->server != NULL) {
ret = krb5_copy_principal(context, ccache->server, &in.server);
if (ret) {
estr = krb5_get_error_message(context, ret);
kcm_log(0, "Failed to copy service principal: %s",
krb5_get_err_text(context, ret));
estr);
krb5_free_error_message(context, estr);
goto out;
}
} else {
@@ -75,8 +78,10 @@ kcm_ccache_refresh(krb5_context context,
ret = krb5_make_principal(context, &in.server, realm,
KRB5_TGS_NAME, realm, NULL);
if (ret) {
estr = krb5_get_error_message(context, ret);
kcm_log(0, "Failed to make TGS principal for realm %s: %s",
realm, krb5_get_err_text(context, ret));
realm, estr);
krb5_free_error_message(context, estr);
goto out;
}
}
@@ -98,8 +103,10 @@ kcm_ccache_refresh(krb5_context context,
&in,
&out);
if (ret) {
estr = krb5_get_error_message(context, ret);
kcm_log(0, "Failed to renew credentials for cache %s: %s",
ccache->name, krb5_get_err_text(context, ret));
ccache->name, estr);
krb5_free_error_message(context, estr);
goto out;
}
@@ -108,8 +115,10 @@ kcm_ccache_refresh(krb5_context context,
ret = kcm_ccache_store_cred_internal(context, ccache, out, 0, credp);
if (ret) {
estr = krb5_get_error_message(context, ret);
kcm_log(0, "Failed to store credentials for cache %s: %s",
ccache->name, krb5_get_err_text(context, ret));
ccache->name, estr);
krb5_free_error_message(context, estr);
krb5_free_creds(context, out);
goto out;
}