Fixes to make Heimdal -Wall -Werror clean

These fixes make developer mode build, at least on Ubuntu.
This commit is contained in:
Nicolas Williams
2011-11-02 21:39:07 -05:00
parent 9c830f5237
commit 3bebbe5323
24 changed files with 286 additions and 172 deletions

View File

@@ -43,11 +43,13 @@ kcm_ccache_resolve_client(krb5_context context,
kcm_ccache *ccache)
{
krb5_error_code ret;
const char *estr;
ret = kcm_ccache_resolve(context, name, ccache);
if (ret) {
kcm_log(1, "Failed to resolve cache %s: %s",
name, krb5_get_err_text(context, ret));
estr = krb5_get_error_message(context, ret);
kcm_log(1, "Failed to resolve cache %s: %s", name, estr);
krb5_free_error_message(context, estr);
return ret;
}
@@ -67,11 +69,13 @@ kcm_ccache_destroy_client(krb5_context context,
{
krb5_error_code ret;
kcm_ccache ccache;
const char *estr;
ret = kcm_ccache_resolve(context, name, &ccache);
if (ret) {
kcm_log(1, "Failed to resolve cache %s: %s",
name, krb5_get_err_text(context, ret));
estr = krb5_get_error_message(context, ret);
kcm_log(1, "Failed to resolve cache %s: %s", name, estr);
krb5_free_error_message(context, estr);
return ret;
}
@@ -92,6 +96,7 @@ kcm_ccache_new_client(krb5_context context,
{
krb5_error_code ret;
kcm_ccache ccache;
const char *estr;
/* We insist the ccache name starts with UID or UID: */
if (name_constraints != 0) {
@@ -127,8 +132,9 @@ kcm_ccache_new_client(krb5_context context,
if (ret == KRB5_FCC_NOFILE) {
ret = kcm_ccache_new(context, name, &ccache);
if (ret) {
kcm_log(1, "Failed to initialize cache %s: %s",
name, krb5_get_err_text(context, ret));
estr = krb5_get_error_message(context, ret);
kcm_log(1, "Failed to initialize cache %s: %s", name, estr);
krb5_free_error_message(context, estr);
return ret;
}
@@ -139,8 +145,9 @@ kcm_ccache_new_client(krb5_context context,
} else {
ret = kcm_zero_ccache_data(context, ccache);
if (ret) {
kcm_log(1, "Failed to empty cache %s: %s",
name, krb5_get_err_text(context, ret));
estr = krb5_get_error_message(context, ret);
kcm_log(1, "Failed to empty cache %s: %s", name, estr);
krb5_free_error_message(context, estr);
kcm_release_ccache(context, ccache);
return ret;
}