oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

lib/krb5: unparse_name_fixed ERANGE if zero buffer len

Browse Source 
The tests depend upon an ERANGE error for buffer length zero.
They broken due to 8324a2af1d
("lib/krb5: unparse_name_fixed error if invalid name buffer or length")
which returned EINVAL.

Change-Id: I81693f9d3f5fdc1838c11ffbfe0dafc742d9b207
This commit is contained in:
Jeffrey Altman
2022-01-20 11:09:04 -05:00
parent d55abd8f50
commit 34e918f210
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/krb5/principal.c
View File

@@ -457,13 +457,20 @@ unparse_name_fixed(krb5_context context,
int no_realm = (flags & KRB5_PRINCIPAL_UNPARSE_NO_REALM) != 0; int no_realm = (flags & KRB5_PRINCIPAL_UNPARSE_NO_REALM) != 0;
int display = (flags & KRB5_PRINCIPAL_UNPARSE_DISPLAY) != 0; int display = (flags & KRB5_PRINCIPAL_UNPARSE_DISPLAY) != 0;
if (name == NULL || len == 0) { if (name == NULL) {
krb5_set_error_message(context, EINVAL, krb5_set_error_message(context, EINVAL,
N_("Invalid name buffer or length, " N_("Invalid name buffer, "
"can't unparse", "")); "can't unparse", ""));
return EINVAL; return EINVAL;
} }
if (len == 0) {
krb5_set_error_message(context, ERANGE,
N_("Invalid name buffer length, "
"can't unparse", ""));
return ERANGE;
}
name[0] = '\0'; name[0] = '\0';
if (!no_realm && princ_realm(principal) == NULL) { if (!no_realm && princ_realm(principal) == NULL) {