oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

base: Fix leak on ENOMEM

Browse Source
This commit is contained in:
Nicolas Williams
2021-10-10 21:35:48 -05:00
parent 7672ad31db
commit 341848a27b
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/base/log.c
View File

@@ -689,8 +689,11 @@ fmtkv(int flags, const char *k, const char *fmt, va_list ap)
if (flags & HEIM_SVC_AUDIT_VIS) if (flags & HEIM_SVC_AUDIT_VIS)
vis_flags |= VIS_WHITE; vis_flags |= VIS_WHITE;
buf3 = malloc((j + 1) * 4 + 1); buf3 = malloc((j + 1) * 4 + 1);
if (buf3)
strvisx(buf3, buf2, j, vis_flags); strvisx(buf3, buf2, j, vis_flags);
free(buf2); free(buf2);
if (buf3 == NULL)
return NULL;
} else } else
buf3 = buf2; buf3 = buf2;
@@ -721,12 +724,11 @@ heim_audit_vaddreason(heim_svc_req_desc r, const char *fmt, va_list ap)
heim_string_get_utf8(str), heim_string_get_utf8(str),
heim_string_get_utf8(r->reason)); heim_string_get_utf8(r->reason));
if (str2) { if (str2) {
heim_release(r->reason);
heim_release(str); heim_release(str);
r->reason = str2; str = str2;
} /* else the earlier reason is likely better than the newer one */
return;
} }
}
heim_release(r->reason);
r->reason = str; r->reason = str;
} }