More s/int/size_t/ for iterators. Also fixed a stupid bug.

lib/hdb/keys.c

@@ -33,7 +33,6 @@
  */
 
 #include "hdb_locl.h"
-#include <assert.h>
 
 /*
  * free all the memory used by (len, keys)
@@ -42,7 +41,7 @@
 void
 hdb_free_keys(krb5_context context, int len, Key *keys)
 {
-    int i;
+    size_t i;
 
     for (i = 0; i < len; i++) {
 	free(keys[i].mkvno);
@@ -60,7 +59,7 @@ hdb_free_keys(krb5_context context, int len, Key *keys)
 void
 hdb_free_keysets(krb5_context context, int len, hdb_keyset *keysets)
 {
-    int i;
+    size_t i;
 
     for (i = 0; i < len; i++) {
 	hdb_free_keys(context, keysets[i].keys.len, keysets[i].keys.val);
@@ -337,7 +336,7 @@ krb5_error_code
 ks_tuple2str(krb5_context context, int n_ks_tuple,
 	     krb5_key_salt_tuple *ks_tuple, char ***ks_tuple_strs)
 {
-	int i;
+	size_t i;
 	char **ksnames;
 	char *ename, *sname;
 	krb5_error_code rc = KRB5_PROG_ETYPE_NOSUPP;

lib/hdb/mkey.c

@@ -492,7 +492,7 @@ hdb_unseal_keys_kvno(krb5_context context, HDB *db, krb5_kvno kvno,
     unsigned int tmp_len;
     unsigned int kvno_diff = 0;
     krb5_kvno tmp_kvno;
-    int i, k;
+    size_t i, k;
     int exclude_dead = 0;
     KerberosTime now = 0;
     time_t *set_time;
@@ -518,7 +518,7 @@ hdb_unseal_keys_kvno(krb5_context context, HDB *db, krb5_kvno kvno,
 
     hist_keys = &ext->data.u.hist_keys;
 
-    for (i = hist_keys->len - 1; i >= 0; i++) {
+    for (i = 0; i < hist_keys->len; i++) {
 	if (kvno != 0 && hist_keys->val[i].kvno != kvno)
 	    continue;
 

lib/hdb/print.c

@@ -128,7 +128,7 @@ static krb5_error_code
 entry2string_int (krb5_context context, krb5_storage *sp, hdb_entry *ent)
 {
     char *p;
-    int i;
+    size_t i;
     krb5_error_code ret;
 
     /* --- principal */