oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

roken: rk_undumpdata free allocation on error

Browse Source 
Do not return allocated memory and an error code.
Free it instead so as to avoid memory leaks.

Change-Id: I47d42be0f6bc52062c57c00c37b665ee2f2811ce
This commit is contained in:
Jeffrey Altman
2016-11-19 02:08:58 -05:00
parent d8e7027c9d
commit 2f62c7c77e
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/roken/dumpdata.c
View File

@@ -81,14 +81,16 @@ rk_undumpdata(const char *filename, void **buf, size_t *size)
sret = net_read(fd, *buf, *size); sret = net_read(fd, *buf, *size);
if (sret < 0) if (sret < 0)
ret = errno; ret = errno;
else if (sret != (ssize_t)*size) { else if (sret != (ssize_t)*size)
ret = EINVAL; ret = EINVAL;
free(*buf); else
*buf = NULL;
} else
ret = 0; ret = 0;
out: out:
if (ret) {
free(*buf);
*buf = NULL;
}
close(fd); close(fd);
return ret; return ret;
} }