oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

slave: quieten static analyzer false positives

Browse Source
This commit is contained in:
Nicolas Williams
2016-02-29 12:19:19 -06:00
parent 2415a5ee1d
commit 2734102cc7
1 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
lib/kadm5/ipropd_slave.c
View File

@@ -170,18 +170,21 @@ ihave(krb5_context context, krb5_auth_context auth_context,
krb5_data data; krb5_data data;
sp = krb5_storage_from_mem(buf, 8); sp = krb5_storage_from_mem(buf, 8);
krb5_store_uint32(sp, I_HAVE); ret = krb5_store_uint32(sp, I_HAVE);
krb5_store_uint32(sp, version); if (ret == 0)
ret = krb5_store_uint32(sp, version);
krb5_storage_free(sp); krb5_storage_free(sp);
data.length = 8; data.length = 8;
data.data = buf; data.data = buf;
if (verbose) if (ret == 0) {
krb5_warnx(context, "telling master we are at %u", version); if (verbose)
krb5_warnx(context, "telling master we are at %u", version);
ret = krb5_write_priv_message(context, auth_context, &fd, &data); ret = krb5_write_priv_message(context, auth_context, &fd, &data);
if (ret) if (ret)
krb5_warn(context, ret, "krb5_write_message"); krb5_warn(context, ret, "krb5_write_message");
}
return ret; return ret;
} }
@@ -437,17 +440,19 @@ send_im_here(krb5_context context, int fd,
sp = krb5_storage_from_data (&data); sp = krb5_storage_from_data (&data);
if (sp == NULL) if (sp == NULL)
krb5_errx(context, IPROPD_RESTART, "krb5_storage_from_data"); krb5_errx(context, IPROPD_RESTART, "krb5_storage_from_data");
krb5_store_uint32(sp, I_AM_HERE); ret = krb5_store_uint32(sp, I_AM_HERE);
krb5_storage_free(sp); krb5_storage_free(sp);
ret = krb5_write_priv_message(context, auth_context, &fd, &data); if (ret == 0) {
krb5_data_free(&data); ret = krb5_write_priv_message(context, auth_context, &fd, &data);
krb5_data_free(&data);
if (ret) if (ret)
krb5_err(context, IPROPD_RESTART, ret, "krb5_write_priv_message"); krb5_err(context, IPROPD_RESTART, ret, "krb5_write_priv_message");
if (verbose) if (verbose)
krb5_warnx(context, "pinged master"); krb5_warnx(context, "pinged master");
}
return; return;
} }