oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

Use malloc() instead of static buffer.

Browse Source 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22588 ec53bebd-3082-4978-b11e-865c3cabbd6b
This commit is contained in:
Love Hörnquist Åstrand
2008-02-11 21:46:45 +00:00
parent 9215d6ea7b
commit 1c9234c4f7
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/hdb/hdb-ldap.c
View File

@@ -989,8 +989,10 @@ LDAP_message2entry(krb5_context context, HDB * db, LDAPMessage * msg,
goto out; goto out;
} }
for (i = 0; i < ent->entry.etypes->len; i++) { for (i = 0; i < ent->entry.etypes->len; i++) {
char buf[100]; char *buf;
if (vals[i]->bv_len > sizeof(buf) - 1) {
buf = malloc(vals[i]->bv_len + 1);
if (buf == NULL) {
krb5_set_error_string(context, "malloc: out of memory"); krb5_set_error_string(context, "malloc: out of memory");
ret = ENOMEM; ret = ENOMEM;
goto out; goto out;
@@ -998,6 +1000,7 @@ LDAP_message2entry(krb5_context context, HDB * db, LDAPMessage * msg,
memcpy(buf, vals[i]->bv_val, vals[i]->bv_len); memcpy(buf, vals[i]->bv_val, vals[i]->bv_len);
buf[vals[i]->bv_len] = '\0'; buf[vals[i]->bv_len] = '\0';
ent->entry.etypes->val[i] = atoi(buf); ent->entry.etypes->val[i] = atoi(buf);
free(buf);
} }
ldap_value_free_len(vals); ldap_value_free_len(vals);
} }