oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

Fix keytab file and lock leak when trying all keys

Browse Source
This commit is contained in:
Nicolas Williams
2013-07-31 18:13:50 -05:00
parent 1bed48b75c
commit 13814606f4
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/krb5/rd_req.c
View File

@@ -957,7 +957,7 @@ krb5_rd_req_ctx(krb5_context context,
_krb5_kt_principal_not_found(context, ret, id, o->server, _krb5_kt_principal_not_found(context, ret, id, o->server,
ap_req.ticket.enc_part.etype, ap_req.ticket.enc_part.etype,
kvno); kvno);
goto out; break;
} }
if (entry.keyblock.keytype != ap_req.ticket.enc_part.etype) { if (entry.keyblock.keytype != ap_req.ticket.enc_part.etype) {
@@ -990,13 +990,13 @@ krb5_rd_req_ctx(krb5_context context,
&o->keyblock); &o->keyblock);
if (ret) { if (ret) {
krb5_kt_free_entry (context, &entry); krb5_kt_free_entry (context, &entry);
goto out; break;
} }
ret = krb5_copy_principal(context, entry.principal, &p); ret = krb5_copy_principal(context, entry.principal, &p);
if (ret) { if (ret) {
krb5_kt_free_entry (context, &entry); krb5_kt_free_entry (context, &entry);
goto out; break;
} }
krb5_free_principal(context, o->ticket->server); krb5_free_principal(context, o->ticket->server);
o->ticket->server = p; o->ticket->server = p;
@@ -1006,6 +1006,8 @@ krb5_rd_req_ctx(krb5_context context,
done = 1; done = 1;
} }
krb5_kt_end_seq_get (context, id, &cursor); krb5_kt_end_seq_get (context, id, &cursor);
if (ret)
goto out;
} }
/* If there is a PAC, verify its server signature */ /* If there is a PAC, verify its server signature */