oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

include field separators in comparison

Browse Source 
When comparing the first component of a multi-component
string that uses a field separator (e.g., '/' or ':'), be sure
to include the separator in the comparison to ensure that the
comparison does not succeed due to a prefix match.

Change-Id: Ieec3e73cb015a83bb652ec11cd7d83e57755c3d2
This commit is contained in:
Jeffrey Altman
2017-04-28 11:24:00 -04:00
parent 93518bfab4
commit 12afd9c4b7
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
kdc/hpropd.c
View File

@@ -176,7 +176,7 @@ main(int argc, char **argv)
ret = krb5_unparse_name(context, ticket->server, &server); ret = krb5_unparse_name(context, ticket->server, &server);
if (ret) if (ret)
krb5_err(context, 1, ret, "krb5_unparse_name"); krb5_err(context, 1, ret, "krb5_unparse_name");
if (strncmp(server, "hprop/", 5) != 0) if (strncmp(server, "hprop/", 6) != 0)
krb5_errx(context, 1, "ticket not for hprop (%s)", server); krb5_errx(context, 1, "ticket not for hprop (%s)", server);
free(server); free(server);

4
lib/hx509/hxtool.c
View File

@@ -944,7 +944,7 @@ pcert_verify(struct verify_options *opt, int argc, char **argv)
if (ret) if (ret)
errx(1, "hx509_revoke_add_crl: %s: %d", s, ret); errx(1, "hx509_revoke_add_crl: %s: %d", s, ret);
} else if (strncmp(s, "ocsp:", 4) == 0) { } else if (strncmp(s, "ocsp:", 5) == 0) {
s += 5; s += 5;
ret = hx509_revoke_add_ocsp(context, revoke_ctx, s); ret = hx509_revoke_add_ocsp(context, revoke_ctx, s);
@@ -1155,7 +1155,7 @@ revoke_print(struct revoke_print_options *opt, int argc, char **argv)
if (ret) if (ret)
errx(1, "hx509_revoke_add_crl: %s: %d", s, ret); errx(1, "hx509_revoke_add_crl: %s: %d", s, ret);
} else if (strncmp(s, "ocsp:", 4) == 0) { } else if (strncmp(s, "ocsp:", 5) == 0) {
s += 5; s += 5;
ret = hx509_revoke_add_ocsp(context, revoke_ctx, s); ret = hx509_revoke_add_ocsp(context, revoke_ctx, s);