oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

(valid_princ): check return value of functions

Browse Source 
(encode_v4_ticket): add some const
new calls for free_ent


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9031 ec53bebd-3082-4978-b11e-865c3cabbd6b
This commit is contained in:
Assar Westerlund
2000-09-10 14:15:52 +00:00
parent 2032126e34
commit 0ca8aae650
1 changed files with 15 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
kdc/kerberos4.c
View File

@@ -61,7 +61,7 @@ make_err_reply(krb5_data *reply, int code, const char *msg)
{ {
KTEXT_ST er; KTEXT_ST er;
/* name, instance and realm is not checked in most (all?) version /* name, instance and realm are not checked in most (all?)
implementations; msg is also never used, but we send it anyway implementations; msg is also never used, but we send it anyway
(for debugging purposes) */ (for debugging purposes) */
@@ -74,9 +74,13 @@ make_err_reply(krb5_data *reply, int code, const char *msg)
static krb5_boolean static krb5_boolean
valid_princ(krb5_context context, krb5_principal princ) valid_princ(krb5_context context, krb5_principal princ)
{ {
krb5_error_code ret;
char *s; char *s;
hdb_entry *ent; hdb_entry *ent;
krb5_unparse_name(context, princ, &s);
ret = krb5_unparse_name(context, princ, &s);
if (ret)
return 0;
ent = db_fetch(princ); ent = db_fetch(princ);
if(ent == NULL){ if(ent == NULL){
kdc_log(7, "Lookup %s failed", s); kdc_log(7, "Lookup %s failed", s);
@@ -85,8 +89,7 @@ valid_princ(krb5_context context, krb5_principal princ)
} }
kdc_log(7, "Lookup %s succeeded", s); kdc_log(7, "Lookup %s succeeded", s);
free(s); free(s);
hdb_free_entry(context, ent); free_ent(ent);
free(ent);
return 1; return 1;
} }
@@ -502,11 +505,8 @@ do_version4(unsigned char *buf,
out2: out2:
if(tgt_princ) if(tgt_princ)
krb5_free_principal(context, tgt_princ); krb5_free_principal(context, tgt_princ);
if(tgt){ if(tgt)
hdb_free_entry(context, tgt); free_ent(tgt);
free(tgt);
}
break; break;
} }
@@ -529,14 +529,10 @@ out:
free(sname); free(sname);
if(sinst) if(sinst)
free(sinst); free(sinst);
if(client){ if(client)
hdb_free_entry(context, client); free_ent(client);
free(client); if(server)
} free_ent(server);
if(server){
hdb_free_entry(context, server);
free(server);
}
krb5_storage_free(sp); krb5_storage_free(sp);
return 0; return 0;
} }
@@ -567,8 +563,8 @@ encrypt_v4_ticket(void *buf, size_t len, des_cblock *key, EncryptedData *reply)
} }
krb5_error_code krb5_error_code
encode_v4_ticket(void *buf, size_t len, EncTicketPart *et, encode_v4_ticket(void *buf, size_t len, const EncTicketPart *et,
PrincipalName *service, size_t *size) const PrincipalName *service, size_t *size)
{ {
krb5_storage *sp; krb5_storage *sp;
krb5_error_code ret; krb5_error_code ret;