send a reply

git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2496 ec53bebd-3082-4978-b11e-865c3cabbd6b

kpasswd/kpasswdd.c

@@ -53,9 +53,162 @@ syslog_and_die (const char *m, ...)
 
 static char *database = HDB_DEFAULT_DB;
 
+static void
+send_reply (int s,
+	    struct sockaddr_in *addr,
+	    krb5_data *ap_rep,
+	    krb5_data *rest)
+{
+    struct msghdr msghdr;
+    struct iovec iov[3];
+    u_int16_t len, ap_rep_len;
+    u_char header[6];
+    u_char *p;
+
+    if (ap_rep)
+	ap_rep_len = ap_rep->length;
+    else
+	ap_rep_len = 0;
+
+    len = 6 + ap_rep_len + rest->length;
+    p = header;
+    *p++ = (len >> 8) & 0xFF;
+    *p++ = (len >> 0) & 0xFF;
+    *p++ = 0;
+    *p++ = 1;
+    *p++ = (ap_rep_len >> 8) & 0xFF;
+    *p++ = (ap_rep_len >> 0) & 0xFF;
+
+    memset (&msghdr, 0, sizeof(msghdr));
+    msghdr.msg_name       = (void *)addr;
+    msghdr.msg_namelen    = sizeof(*addr);
+    msghdr.msg_iov        = iov;
+    msghdr.msg_iovlen     = sizeof(iov)/sizeof(*iov);
+#if 0
+    msghdr.msg_control    = NULL;
+    msghdr.msg_controllen = 0;
+#endif
+
+    iov[0].iov_base       = header;
+    iov[0].iov_len        = 6;
+    if (ap_rep_len) {
+	iov[1].iov_base   = ap_rep->data;
+	iov[1].iov_len    = ap_rep->length;
+    } else {
+	iov[1].iov_base   = NULL;
+	iov[1].iov_len    = 0;
+    }
+    iov[2].iov_base       = rest->data;
+    iov[2].iov_len        = rest->length;
+
+    if (sendmsg (s, &msghdr, 0) < 0)
+	syslog (LOG_ERR, "sendmsg: %m");
+}
+
+static int
+make_result (krb5_data *data,
+	     u_int16_t result_code,
+	     const char *expl)
+{
+    krb5_data_zero (data);
+
+    data->length = asprintf ((char **)&data->data,
+			     "%c%c%s",
+			     (result_code >> 8) & 0xFF,
+			     result_code & 0xFF,
+			     expl);
+
+    if (data->data == NULL) {
+	syslog (LOG_ERR, "Out of memory generating error reply");
+	return 1;
+    }
+    return 0;
+}
+
+static void
+reply_error (krb5_context context,
+	     krb5_principal server,
+	     int s,
+	     struct sockaddr_in *addr,
+	     krb5_error_code error_code,
+	     u_int16_t result_code,
+	     const char *expl)
+{
+    krb5_error_code ret;
+    krb5_data error_data;
+    krb5_data e_data;
+
+    if (make_result(&e_data, result_code, expl))
+	return;
+
+    ret = krb5_mk_error (context,
+			 error_code,
+			 NULL,
+			 &e_data,
+			 NULL,
+			 server,
+			 0,
+			 &error_data);
+    krb5_data_free (&e_data);
+    if (ret) {
+	syslog (LOG_ERR,
+		"Could not even generate error reply: %s",
+		krb5_get_err_text (context, ret));
+	return;
+    }
+    send_reply (s, addr, NULL, &error_data);
+    krb5_data_free (&error_data);
+}
+
+static void
+reply_priv (krb5_context context,
+	    krb5_auth_context auth_context,
+	    int s,
+	    struct sockaddr_in *addr,
+	    u_int16_t result_code,
+	    const char *expl)
+{
+    krb5_error_code ret;
+    krb5_data krb_priv_data;
+    krb5_data ap_rep_data;
+    krb5_data e_data;
+
+    ret = krb5_mk_rep (context,
+		       &auth_context,
+		       &ap_rep_data);
+    if (ret) {
+	syslog (LOG_ERR,
+		"Could not even generate error reply: %s",
+		krb5_get_err_text (context, ret));
+	return;
+    }
+
+    if (make_result(&e_data, result_code, expl))
+	return;
+
+    ret = krb5_mk_priv (context,
+			auth_context,
+			&e_data,
+			&krb_priv_data,
+			NULL);
+    krb5_data_free (&e_data);
+    if (ret) {
+	syslog (LOG_ERR,
+		"Could not even generate error reply: %s",
+		krb5_get_err_text (context, ret));
+	return;
+    }
+    send_reply (s, addr, &ap_rep_data, &krb_priv_data);
+    krb5_data_free (&ap_rep_data);
+    krb5_data_free (&krb_priv_data);
+}
+
 static void
 change (krb5_context context,
+	krb5_auth_context auth_context,
 	krb5_principal principal,
+	int s,
+	struct sockaddr_in *addr,
 	krb5_data *pwd_data)
 {
     krb5_error_code ret;
@@ -63,15 +216,23 @@ change (krb5_context context,
     HDB *db;
     hdb_entry ent;
     krb5_data salt;
+    krb5_keyblock new_keyblock;
 
     krb5_unparse_name (context, principal, &c);
 
     syslog (LOG_INFO, "Changing password for %s", c);
     free (c);
 
+    if (pwd_data->length < 6) {	/* XXX */
+	syslog (LOG_ERR, "Password too short");
+	reply_priv (context, auth_context, s, addr, 4, "password too short");
+	return;
+    }
+
     ret = hdb_open (context, &db, database, O_RDWR, 0600);
     if (ret) {
 	syslog (LOG_ERR, "hdb_open: %s", krb5_get_err_text(context, ret));
+	reply_priv (context, auth_context, s, addr, 2, "hdb_open failed");
 	return;
     }
 
@@ -82,39 +243,129 @@ change (krb5_context context,
     switch (ret) {
     case KRB5_HDB_NOENTRY:
 	syslog (LOG_ERR, "not found in database");
-	return;
+	reply_priv (context, auth_context, s, addr, 2,
+		    "entry not found in database");
+	goto out;
     case 0:
 	break;
     default :
 	syslog (LOG_ERR, "dbfetch: %s", krb5_get_err_text(context, ret));
-	return;
+	reply_priv (context, auth_context, s, addr, 2,
+		    "db_fetch failed");
+	goto out;
     }
 
     krb5_data_zero (&salt);
     krb5_get_salt (principal, &salt);
-    memset (&ent.keyblock, 0, sizeof(ent.keyblock));
+    memset (&new_keyblock, 0, sizeof(new_keyblock));
-    {
+    krb5_string_to_key_data (pwd_data, &salt, &new_keyblock);
-	char *pwd;
-
-	pwd = malloc (pwd_data->length + 1);
-	strcpy (pwd, pwd_data->data);
-	pwd[pwd_data->length] = '\0';
-	krb5_string_to_key (pwd, &salt, &ent.keyblock);
-	free (pwd);
-    }
     krb5_data_free (&salt);
-    ent.kvno++;
+    if (new_keyblock.keytype == ent.keyblock.keytype
-    ent.last_change = time(NULL);
+	&& new_keyblock.keyvalue.length == ent.keyblock.keyvalue.length
-    krb5_copy_principal (context, principal, &ent.changed_by);
+	&& memcmp (new_keyblock.keyvalue.data,
-    ret = db->store (context, db, &ent);
+		   ent.keyblock.keyvalue.data,
+		   new_keyblock.keyvalue.length) == 0) {
+	ret = 0;
+    } else {
+	memset (&ent.keyblock, 0, sizeof(ent.keyblock));
+	ent.keyblock.keytype = new_keyblock.keytype;
+	krb5_data_copy (&ent.keyblock.keyvalue,
+			new_keyblock.keyvalue.data,
+			new_keyblock.keyvalue.length);
+	ent.kvno++;
+	ent.last_change = time(NULL);
+	krb5_copy_principal (context, principal, &ent.changed_by);
+	ret = db->store (context, db, &ent);
+    }
+    memset (&new_keyblock, 0, sizeof(new_keyblock));
+    krb5_free_keyblock (context, &new_keyblock);
+
     if (ret == -1) {
 	syslog (LOG_ERR, "dbstore: %m");
-	return;
+	reply_priv (context, auth_context, s, addr, 2,
+		    "db_store failed");
+    } else {
+	reply_priv (context, auth_context, s, addr, 0, "password changed");
     }
+out:
     hdb_free_entry (context, &ent);
     db->close (context, db);
 }
 
+static int
+verify (krb5_context context,
+	krb5_auth_context *auth_context,
+	krb5_principal server,
+	krb5_ticket **ticket,
+	krb5_data *out_data,
+	int s,
+	struct sockaddr_in *addr,
+	u_char *msg,
+	size_t len)
+{
+    krb5_error_code ret;
+    u_int16_t pkt_len, pkt_ver, ap_req_len;
+    krb5_data ap_req_data;
+    krb5_data krb_priv_data;
+
+    pkt_len = (msg[0] << 8) | (msg[1]);
+    pkt_ver = (msg[2] << 8) | (msg[3]);
+    ap_req_len = (msg[4] << 8) | (msg[5]);
+    if (pkt_len != len) {
+	syslog (LOG_ERR, "Strange len: %d != %d", pkt_len, len);
+	reply_error (context, server, s, addr, 0, 1, "bad length");
+	return 1;
+    }
+    if (pkt_ver != 0x0001) {
+	syslog (LOG_ERR, "Bad version (%d)", pkt_ver);
+	reply_error (context, server, s, addr, 0, 1, "bad version");
+	return 1;
+    }
+
+    ap_req_data.data   = msg + 6;
+    ap_req_data.length = ap_req_len;
+
+    ret = krb5_rd_req (context,
+		       auth_context,
+		       &ap_req_data,
+		       server,
+		       NULL,
+		       NULL,
+		       ticket);
+    if (ret) {
+	syslog (LOG_ERR, "krb5_rd_req: %s",
+		krb5_get_err_text(context, ret));
+	reply_error (context, server, s, addr, ret, 3, "rd_req failed");
+	return 1;
+    }
+
+    if (!(*ticket)->ticket.flags.initial) {
+	syslog (LOG_ERR, "initial flag not set");
+	reply_error (context, server, s, addr, ret, 1,
+		     "initial flag not set");
+	krb5_free_ticket (context, *ticket);
+	goto out;
+    }
+    krb_priv_data.data   = msg + 6 + ap_req_len;
+    krb_priv_data.length = len - 6 - ap_req_len;
+
+    ret = krb5_rd_priv (context,
+			*auth_context,
+			&krb_priv_data,
+			out_data,
+			NULL);
+    
+    if (ret) {
+	syslog (LOG_ERR, "krb5_rd_priv: %s",
+		krb5_get_err_text(context, ret));
+	reply_error (context, server, s, addr, ret, 3, "rd_priv failed");
+	goto out;
+    }
+    return 0;
+out:
+    krb5_free_ticket (context, *ticket);
+    return 1;
+}
 
 static void
 process (krb5_context context,
@@ -126,64 +377,21 @@ process (krb5_context context,
 {
     krb5_error_code ret;
     krb5_auth_context auth_context = NULL;
-    u_int16_t pkt_len, pkt_ver, ap_req_len;
-
-    krb5_data ap_req_data;
-    krb5_data krb_priv_data;
     krb5_data out_data;
     krb5_ticket *ticket;
 
-    pkt_len = (msg[0] << 8) | (msg[1]);
-    pkt_ver = (msg[2] << 8) | (msg[3]);
-    ap_req_len = (msg[4] << 8) | (msg[5]);
-    if (pkt_len != len) {
-	syslog (LOG_ERR, "Strange len: %d != %d", pkt_len, len);
-	return;
-    }
-    if (pkt_ver != 0x0001) {
-	syslog (LOG_ERR, "Bad version (%d)", pkt_ver);
-	return;
-    }
-
-    ap_req_data.data   = msg + 6;
-    ap_req_data.length = ap_req_len;
-
-    ret = krb5_rd_req (context,
-		       &auth_context,
-		       &ap_req_data,
-		       server,
-		       NULL,
-		       NULL,
-		       &ticket);
-    if (ret) {
-	syslog (LOG_ERR, "krb5_rd_req: %s",
-		krb5_get_err_text(context, ret));
-	return;
-    }
-
-    if (!ticket->ticket.flags.initial) {
-	syslog (LOG_ERR, "initial flag not set");
-	return;
-    }
-    krb_priv_data.data   = msg + 6 + ap_req_len;
-    krb_priv_data.length = len - 6 - ap_req_len;
-
     krb5_data_zero (&out_data);
 
-    ret = krb5_rd_priv (context,
+    if (verify (context, &auth_context, server, &ticket, &out_data,
-			auth_context,
+		s, addr, msg, len) == 0)
-			&krb_priv_data,
+	change (context,
-			&out_data,
+		auth_context,
-			NULL);
+		ticket->client,
-    
+		s,
-    if (ret) {
+		addr,
-	syslog (LOG_ERR, "krb5_rd_priv: %s",
+		&out_data);
-		krb5_get_err_text(context, ret));
-	return;
-    }
-
-    change (context, ticket->client, &out_data);
 
+    krb5_data_free (&out_data);
     krb5_auth_con_free (context, auth_context);
 }