oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

lib/krb5: make_pa_tgs_req do not pass ptr to in param to allocator

Browse Source 
_krb5_mk_req_internal() accepts a (krb5_auth_context *) because
it can allocate and return a krb5_auth_context to the caller.
mkae_pa_tgs_req() should never be called with a non-NULL
krb5_auth_context but to avoid confusion, alter the signature
to accept a (krb5_auth_context *) instead of (krb5_auth_context)
so _krb5_mk_req_internal() is not called with a pointer to an
input parameter.

Change-Id: I6c2293529766eb06a9eebf41715533d8195b1f72
This commit is contained in:
Jeffrey Altman
2022-01-16 19:31:34 -05:00
parent 5838fcaa61
commit 0a088b9b61
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/krb5/get_cred.c
View File

@@ -50,7 +50,7 @@ get_cred_kdc_capath(krb5_context, krb5_kdc_flags,
static krb5_error_code static krb5_error_code
make_pa_tgs_req(krb5_context context, make_pa_tgs_req(krb5_context context,
krb5_auth_context ac, krb5_auth_context *ac,
KDC_REQ_BODY *body, KDC_REQ_BODY *body,
krb5_ccache ccache, krb5_ccache ccache,
krb5_creds *creds, krb5_creds *creds,
@@ -71,7 +71,7 @@ make_pa_tgs_req(krb5_context context,
in_data.length = len; in_data.length = len;
in_data.data = buf; in_data.data = buf;
ret = _krb5_mk_req_internal(context, &ac, 0, &in_data, ret = _krb5_mk_req_internal(context, ac, 0, &in_data,
creds, tgs_req, creds, tgs_req,
KRB5_KU_TGS_REQ_AUTH_CKSUM, KRB5_KU_TGS_REQ_AUTH_CKSUM,
KRB5_KU_TGS_REQ_AUTH); KRB5_KU_TGS_REQ_AUTH);
@@ -286,7 +286,7 @@ init_tgs_req (krb5_context context,
} }
ret = make_pa_tgs_req(context, ret = make_pa_tgs_req(context,
ac, &ac,
&t->req_body, &t->req_body,
ccache, ccache,
krbtgt, krbtgt,