search/kanji: split queries into separate functions

lib/search/kanji_search.dart

@@ -5,140 +5,186 @@ import 'package:jadb/table_names/kanjidic.dart';
 import 'package:jadb/table_names/radkfile.dart';
 import 'package:sqflite_common/sqflite.dart';
 
+Future<List<Map<String, Object?>>> _charactersQuery(
+  DatabaseExecutor connection,
+  String kanji,
+) => connection.query(
+  KANJIDICTableNames.character,
+  where: 'literal = ?',
+  whereArgs: [kanji],
+);
+
+Future<List<Map<String, Object?>>> _codepointsQuery(
+  DatabaseExecutor connection,
+  String kanji,
+) => connection.query(
+  KANJIDICTableNames.codepoint,
+  where: 'kanji = ?',
+  whereArgs: [kanji],
+);
+
+Future<List<Map<String, Object?>>> _kunyomisQuery(
+  DatabaseExecutor connection,
+  String kanji,
+) => connection.query(
+  KANJIDICTableNames.kunyomi,
+  where: 'kanji = ?',
+  whereArgs: [kanji],
+  orderBy: 'orderNum',
+);
+
+Future<List<Map<String, Object?>>> _onyomisQuery(
+  DatabaseExecutor connection,
+  String kanji,
+) => connection.query(
+  KANJIDICTableNames.onyomi,
+  where: 'kanji = ?',
+  whereArgs: [kanji],
+  orderBy: 'orderNum',
+);
+
+Future<List<Map<String, Object?>>> _meaningsQuery(
+  DatabaseExecutor connection,
+  String kanji,
+) => connection.query(
+  KANJIDICTableNames.meaning,
+  where: 'kanji = ? AND language = ?',
+  whereArgs: [kanji, 'eng'],
+  orderBy: 'orderNum',
+);
+
+Future<List<Map<String, Object?>>> _nanorisQuery(
+  DatabaseExecutor connection,
+  String kanji,
+) => connection.query(
+  KANJIDICTableNames.nanori,
+  where: 'kanji = ?',
+  whereArgs: [kanji],
+);
+
+Future<List<Map<String, Object?>>> _dictionaryReferencesQuery(
+  DatabaseExecutor connection,
+  String kanji,
+) => connection.query(
+  KANJIDICTableNames.dictionaryReference,
+  where: 'kanji = ?',
+  whereArgs: [kanji],
+);
+
+Future<List<Map<String, Object?>>> _queryCodesQuery(
+  DatabaseExecutor connection,
+  String kanji,
+) => connection.query(
+  KANJIDICTableNames.queryCode,
+  where: 'kanji = ?',
+  whereArgs: [kanji],
+);
+
+Future<List<Map<String, Object?>>> _radicalsQuery(
+  DatabaseExecutor connection,
+  String kanji,
+) => connection.rawQuery(
+  '''
+    SELECT DISTINCT
+      "XREF__KANJIDIC_Radical__RADKFILE"."radicalSymbol" AS "symbol",
+      "names"
+    FROM "${KANJIDICTableNames.radical}"
+    JOIN "XREF__KANJIDIC_Radical__RADKFILE" USING ("radicalId")
+    LEFT JOIN (
+      SELECT "radicalId", group_concat("name") AS "names"
+      FROM "${KANJIDICTableNames.radicalName}"
+      GROUP BY "radicalId"
+    ) USING ("radicalId")
+    WHERE "${KANJIDICTableNames.radical}"."kanji" = ?
+  ''',
+  [kanji],
+);
+
+Future<List<Map<String, Object?>>> _partsQuery(
+  DatabaseExecutor connection,
+  String kanji,
+) => connection.query(
+  RADKFILETableNames.radkfile,
+  where: 'kanji = ?',
+  whereArgs: [kanji],
+);
+
+Future<List<Map<String, Object?>>> _readingsQuery(
+  DatabaseExecutor connection,
+  String kanji,
+) => connection.query(
+  KANJIDICTableNames.reading,
+  where: 'kanji = ?',
+  whereArgs: [kanji],
+);
+
+Future<List<Map<String, Object?>>> _strokeMiscountsQuery(
+  DatabaseExecutor connection,
+  String kanji,
+) => connection.query(
+  KANJIDICTableNames.strokeMiscount,
+  where: 'kanji = ?',
+  whereArgs: [kanji],
+);
+
+// Future<List<Map<String, Object?>>> _variantsQuery(
+//   DatabaseExecutor connection,
+//   String kanji,
+// ) => connection.query(
+//   KANJIDICTableNames.variant,
+//   where: 'kanji = ?',
+//   whereArgs: [kanji],
+// );
+
 /// Searches for a kanji character and returns its details, or null if the kanji is not found in the database.
 Future<KanjiSearchResult?> searchKanjiWithDbConnection(
   DatabaseExecutor connection,
   String kanji,
 ) async {
   late final List<Map<String, Object?>> characters;
-  final charactersQuery = connection.query(
-    KANJIDICTableNames.character,
-    where: 'literal = ?',
-    whereArgs: [kanji],
-  );
-
   late final List<Map<String, Object?>> codepoints;
-  final codepointsQuery = connection.query(
-    KANJIDICTableNames.codepoint,
-    where: 'kanji = ?',
-    whereArgs: [kanji],
-  );
-
   late final List<Map<String, Object?>> kunyomis;
-  final kunyomisQuery = connection.query(
-    KANJIDICTableNames.kunyomi,
-    where: 'kanji = ?',
-    whereArgs: [kanji],
-    orderBy: 'orderNum',
-  );
-
   late final List<Map<String, Object?>> onyomis;
-  final onyomisQuery = connection.query(
-    KANJIDICTableNames.onyomi,
-    where: 'kanji = ?',
-    whereArgs: [kanji],
-    orderBy: 'orderNum',
-  );
-
   late final List<Map<String, Object?>> meanings;
-  final meaningsQuery = connection.query(
-    KANJIDICTableNames.meaning,
-    where: 'kanji = ? AND language = ?',
-    whereArgs: [kanji, 'eng'],
-    orderBy: 'orderNum',
-  );
-
   late final List<Map<String, Object?>> nanoris;
-  final nanorisQuery = connection.query(
-    KANJIDICTableNames.nanori,
-    where: 'kanji = ?',
-    whereArgs: [kanji],
-  );
-
   late final List<Map<String, Object?>> dictionaryReferences;
-  final dictionaryReferencesQuery = connection.query(
-    KANJIDICTableNames.dictionaryReference,
-    where: 'kanji = ?',
-    whereArgs: [kanji],
-  );
-
   late final List<Map<String, Object?>> queryCodes;
-  final queryCodesQuery = connection.query(
-    KANJIDICTableNames.queryCode,
-    where: 'kanji = ?',
-    whereArgs: [kanji],
-  );
-
   late final List<Map<String, Object?>> radicals;
-  final radicalsQuery = connection.rawQuery(
-    '''
-      SELECT DISTINCT
-        "XREF__KANJIDIC_Radical__RADKFILE"."radicalSymbol" AS "symbol",
-        "names"
-      FROM "${KANJIDICTableNames.radical}"
-      JOIN "XREF__KANJIDIC_Radical__RADKFILE" USING ("radicalId")
-      LEFT JOIN (
-        SELECT "radicalId", group_concat("name") AS "names"
-        FROM "${KANJIDICTableNames.radicalName}"
-        GROUP BY "radicalId"
-      ) USING ("radicalId")
-      WHERE "${KANJIDICTableNames.radical}"."kanji" = ?
-    ''',
-    [kanji],
-  );
-
   late final List<Map<String, Object?>> parts;
-  final partsQuery = connection.query(
-    RADKFILETableNames.radkfile,
-    where: 'kanji = ?',
-    whereArgs: [kanji],
-  );
-
   late final List<Map<String, Object?>> readings;
-  final readingsQuery = connection.query(
-    KANJIDICTableNames.reading,
-    where: 'kanji = ?',
-    whereArgs: [kanji],
-  );
-
   late final List<Map<String, Object?>> strokeMiscounts;
-  final strokeMiscountsQuery = connection.query(
-    KANJIDICTableNames.strokeMiscount,
-    where: 'kanji = ?',
-    whereArgs: [kanji],
-  );
-
   // TODO: add variant data to result
   // late final List<Map<String, Object?>> variants;
-  // final variants_query = connection.query(
-  //   KANJIDICTableNames.variant,
-  //   where: "kanji = ?",
-  //   whereArgs: [kanji],
-  // );
 
   // TODO: Search for kunyomi and onyomi usage of the characters
-  //       from JMDict. We'll need to fuzzy aquery JMDict_KanjiElement for mathces,
+  //       from JMDict. We'll need to fuzzy aquery JMDict_KanjiElement for matches,
   //       filter JMdict_ReadingElement for kunyomi/onyomi, and then sort the main entry
   //       by JLPT, news frequency, etc.
 
-  await charactersQuery.then((value) => characters = value);
+  await _charactersQuery(connection, kanji).then((value) => characters = value);
 
   if (characters.isEmpty) {
     return null;
   }
 
   await Future.wait({
-    codepointsQuery.then((value) => codepoints = value),
-    kunyomisQuery.then((value) => kunyomis = value),
-    onyomisQuery.then((value) => onyomis = value),
-    meaningsQuery.then((value) => meanings = value),
-    nanorisQuery.then((value) => nanoris = value),
-    dictionaryReferencesQuery.then((value) => dictionaryReferences = value),
-    queryCodesQuery.then((value) => queryCodes = value),
-    radicalsQuery.then((value) => radicals = value),
-    partsQuery.then((value) => parts = value),
-    readingsQuery.then((value) => readings = value),
-    strokeMiscountsQuery.then((value) => strokeMiscounts = value),
+    _codepointsQuery(connection, kanji).then((value) => codepoints = value),
+    _kunyomisQuery(connection, kanji).then((value) => kunyomis = value),
+    _onyomisQuery(connection, kanji).then((value) => onyomis = value),
+    _meaningsQuery(connection, kanji).then((value) => meanings = value),
+    _nanorisQuery(connection, kanji).then((value) => nanoris = value),
+    _dictionaryReferencesQuery(
+      connection,
+      kanji,
+    ).then((value) => dictionaryReferences = value),
+    _queryCodesQuery(connection, kanji).then((value) => queryCodes = value),
+    _radicalsQuery(connection, kanji).then((value) => radicals = value),
+    _partsQuery(connection, kanji).then((value) => parts = value),
+    _readingsQuery(connection, kanji).then((value) => readings = value),
+    _strokeMiscountsQuery(
+      connection,
+      kanji,
+    ).then((value) => strokeMiscounts = value),
     // variants_query.then((value) => variants = value),
   });