Projects/nettsiden
Projects
/
nettsiden
8
2
Fork 0
Code Issues 15 Pull Requests 2 Activity

WIP: readd-webmail, fixes #70 #75

Draft
felixalb wants to merge 2 commits from readd-webmail into master
pull from: readd-webmail
merge into: Projects:master
Conversation 2 Commits 2 Files Changed 9 +109 -75
felixalb commented 2024-08-21 17:03:03 +02:00
Owner
Copy Link

image

  • Re-add the webmail index on the website
  • Remove defunct clients (text, css and logos)
  • Add new clients
  • Remove defunct CSS
  • Fix indentation
  • Rename from /mail to /webmail
  • Add some pointers to using non-web email clients
  • Test / fix on mobile
  • Standardize on a place to put icons / images
  • Standardize on a code formatting / indentation style for HTML, CSS and PHP
![image](/attachments/ebb42a0b-538c-4ca4-b279-330b08d7605f) - [x] Re-add the webmail index on the website - [x] Remove defunct clients (text, css and logos) - [x] Add new clients - [x] Remove defunct CSS - [x] Fix indentation - [x] Rename from /mail to /webmail - [x] Add some pointers to using non-web email clients - [ ] Test / fix on mobile - [ ] Standardize on a place to put icons / images - [ ] Standardize on a code formatting / indentation style for HTML, CSS and PHP
image.png
276 KiB
🚀 1
felixalb added 2 commits 2024-08-21 17:03:03 +02:00
oysteikt commented 2024-08-22 23:32:25 +02:00
Owner
Copy Link

Is this still WIP? If so, could you add a todo-list to the PR description?

Is this still WIP? If so, could you add a todo-list to the PR description?
👍 1
felixalb commented 2024-08-25 16:42:34 +02:00
Author
Owner
Copy Link

I marked it WIP as I did a few things on the files I touched;

  • Reindented to a reasonable indentation style
  • Moved pictures/PNGs out of the /css directory

However, I did not explain or document this yet, and other parts of the project remains in the old style. I am still thinking about if I should revert this and try to preserve original style, leave it as is now, or do something treewide to make both of these fixes the default. Input is welcome!

I marked it WIP as I did a few things on the files I touched; - [ ] Reindented to a reasonable indentation style - [ ] Moved pictures/PNGs out of the /css directory However, I did not explain or document this yet, and other parts of the project remains in the old style. I am still thinking about if I should revert this and try to preserve original style, leave it as is now, or do something treewide to make both of these fixes the default. Input is welcome!
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b readd-webmail master
git pull origin readd-webmail

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff readd-webmail
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
art

The issue needs someone to be creative

  
big

No, not bug, **big** - this is gonna take a while

  
blocked

This issue/PR depends on one or more other issues/PRs

  
bug

Something is not working, and it's not the shield hero

  
crash report

Report an oopsie

  
disputed

kranglefanter

  
documentation

Documentation changes required

  
duplicate

This issue or pull request already exists

  
feature request

New feature

  
good first issue

Get your hands dirty with a new project here

  
packaging

Relates to distribution of the software

  
question

More information is needed

  
security

Skommel

  
wontfix

This won't be fixed

No Label
art
big
blocked
bug
crash report
disputed
documentation
duplicate
feature request
good first issue
packaging
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Projects/nettsiden#75
No description provided.
Delete Branch "readd-webmail"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?