Split code into client and server #55

oysteikt · 2024-08-17T20:22:16+02:00

oysteikt commented

2024-08-17 20:22:16 +02:00

Fixes: #47
Reopens: #21

Fixes: #47 Reopens: #21

oysteikt added 2 commits 2024-08-17 20:22:17 +02:00

Add protocol for authenticating a unix socket 20e60ca5c7

Rewrite entire codebase to split into client and server af86893acf

oysteikt requested review from felixalb 2024-08-17 20:22:27 +02:00

felixalb approved these changes 2024-08-17 20:29:35 +02:00

felixalb left a comment

Note: I have not done a proper code review, and barely read any of it yet.

I have however,

Verified that it builds on mac
Verified most of the featuers in mysqladm works as expected
- Given OOB feedback for the few things that I found strange, these are mostly fixed now
Verified that most of the features in mysql-useradm and mysql-dbadm works as the old ones

All in all, functionality and architecture seems well planned and implemented.

I am however skeptical of the usefulness of the backwards-compatible -useradm and -dbadm utilities, and think they might work against their purpose of getting people over to the new system.

Also, user-facing options for sockets and config files might be a bit scary/confusing, but I think it's fine as they are not usually needed, and don't show up in -h. A potential workaround could be hiding them in envvars instead of flags.

Note: I have not done a proper code review, and barely read any of it yet. I have however, - Verified that it builds on mac - Verified most of the featuers in mysqladm works as expected - Given OOB feedback for the few things that I found strange, these are mostly fixed now - Verified that most of the features in mysql-useradm and mysql-dbadm works as the old ones All in all, functionality and architecture seems well planned and implemented. I am however skeptical of the usefulness of the backwards-compatible -useradm and -dbadm utilities, and think they might work against their purpose of getting people over to the new system. Also, user-facing options for sockets and config files might be a bit scary/confusing, but I think it's fine as they are not usually needed, and don't show up in `-h`. A potential workaround could be hiding them in envvars instead of flags.

oysteikt merged commit af86893acf into main

2024-08-17 20:37:21 +02:00

oysteikt deleted branch split-into-client-server

2024-08-17 20:37:21 +02:00

Sign in to join this conversation.

No reviewers