oysteikt/mpvipc-async
oysteikt
/
mpvipc-async
1
0
Fork 0
Code Issues 4 Pull Requests Actions Releases 1 Activity

Add TODO for missing async response events

This commit is contained in:
Oystein Kristoffer Tveit 2024-08-03 16:02:17 +02:00
parent 9e0d8c0117
commit cbd8b1aed2
Signed by: oysteikt
GPG Key ID: 9F2F7D8250F35146
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/event_parser.rs
View File

@ -209,9 +209,16 @@ pub(crate) fn parse_event(raw_event: MpvIpcEvent) -> Result<Event, MpvError> {
"shutdown" => Ok(Event::Shutdown), "shutdown" => Ok(Event::Shutdown),
"log-message" => parse_log_message(event), "log-message" => parse_log_message(event),
"hook" => parse_hook(event), "hook" => parse_hook(event),
// TODO: fix these. They are asynchronous responses to different requests.
// see:
// - https://github.com/mpv-player/mpv/blob/5f768a688b706cf94041adf5bed7c7004af2ec5a/libmpv/client.h#L1158-L1160
// - https://github.com/mpv-player/mpv/blob/5f768a688b706cf94041adf5bed7c7004af2ec5a/libmpv/client.h#L1095-L1098
// - https://github.com/mpv-player/mpv/blob/5f768a688b706cf94041adf5bed7c7004af2ec5a/libmpv/client.h#L972-L982
// "get-property-reply" => // "get-property-reply" =>
// "set-property-reply" => // "set-property-reply" =>
// "command-reply" => // "command-reply" =>
"client-message" => parse_client_message(event), "client-message" => parse_client_message(event),
"video-reconfig" => Ok(Event::VideoReconfig), "video-reconfig" => Ok(Event::VideoReconfig),
"audio-reconfig" => Ok(Event::AudioReconfig), "audio-reconfig" => Ok(Event::AudioReconfig),