788e3b31e1
The "pure" and "const" attributes are not so well-defined, and a recent clang version implements an optimization which pushes the definition's boundary beyond what I believed it was. clang now assumes that functions declared "pure" cannot throw exceptions, even if they lack the "noexcept" specification. When compiled with this new clang version, MPD will crash randomly if an exception happens to get thrown by such as "pure" function (https://github.com/MusicPlayerDaemon/MPD/issues/41). This commit removes all such misplaced "pure" and "const" attributes, closing #41.
49 lines
1.4 KiB
C++
49 lines
1.4 KiB
C++
/*
|
|
* Copyright 2003-2017 The Music Player Daemon Project
|
|
* http://www.musicpd.org
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#ifndef MPD_DATABASE_SONG_HXX
|
|
#define MPD_DATABASE_SONG_HXX
|
|
|
|
#include "Compiler.h"
|
|
|
|
struct LightSong;
|
|
class Database;
|
|
class Storage;
|
|
class DetachedSong;
|
|
|
|
/**
|
|
* "Detach" the #Song object, i.e. convert it to a #DetachedSong
|
|
* instance.
|
|
*/
|
|
DetachedSong
|
|
DatabaseDetachSong(const Storage &storage, const LightSong &song);
|
|
|
|
/**
|
|
* Look up a song in the database and convert it to a #DetachedSong
|
|
* instance. The caller is responsible for freeing it.
|
|
*
|
|
* @return nullptr on error
|
|
*/
|
|
gcc_malloc gcc_nonnull_all
|
|
DetachedSong *
|
|
DatabaseDetachSong(const Database &db, const Storage &storage,
|
|
const char *uri);
|
|
|
|
#endif
|