
If we only receive very little data from the InputStream, try a second Read() call to get more data. This works around tiny reads at input buffer boundaries with the io_uring input plugin. These tiny reads are inefficient, and we can afford to wait one more low-level I/O iteration to finish (but not more). Closes https://github.com/MusicPlayerDaemon/MPD/issues/2186
393 lines
9.7 KiB
C++
393 lines
9.7 KiB
C++
/*
|
|
* Copyright 2003-2021 The Music Player Daemon Project
|
|
* http://www.musicpd.org
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#include "config.h"
|
|
#include "FileCommands.hxx"
|
|
#include "Request.hxx"
|
|
#include "protocol/Ack.hxx"
|
|
#include "client/Client.hxx"
|
|
#include "client/Response.hxx"
|
|
#include "util/CharUtil.hxx"
|
|
#include "util/OffsetPointer.hxx"
|
|
#include "util/ScopeExit.hxx"
|
|
#include "util/StringCompare.hxx"
|
|
#include "util/StringView.hxx"
|
|
#include "util/UriExtract.hxx"
|
|
#include "tag/Handler.hxx"
|
|
#include "tag/Generic.hxx"
|
|
#include "TagAny.hxx"
|
|
#include "db/Interface.hxx"
|
|
#include "song/LightSong.hxx"
|
|
#include "storage/StorageInterface.hxx"
|
|
#include "fs/AllocatedPath.hxx"
|
|
#include "fs/FileInfo.hxx"
|
|
#include "fs/DirectoryReader.hxx"
|
|
#include "input/InputStream.hxx"
|
|
#include "input/Error.hxx"
|
|
#include "LocateUri.hxx"
|
|
#include "TimePrint.hxx"
|
|
#include "thread/Mutex.hxx"
|
|
#include "Log.hxx"
|
|
|
|
#include <fmt/format.h>
|
|
|
|
#include <algorithm>
|
|
#include <cassert>
|
|
#include <array>
|
|
|
|
gcc_pure
|
|
static bool
|
|
SkipNameFS(PathTraitsFS::const_pointer name_fs) noexcept
|
|
{
|
|
return PathTraitsFS::IsSpecialFilename(name_fs);
|
|
}
|
|
|
|
gcc_pure
|
|
static bool
|
|
skip_path(Path name_fs) noexcept
|
|
{
|
|
return name_fs.HasNewline();
|
|
}
|
|
|
|
CommandResult
|
|
handle_listfiles_local(Response &r, Path path_fs)
|
|
{
|
|
DirectoryReader reader(path_fs);
|
|
|
|
while (reader.ReadEntry()) {
|
|
const Path name_fs = reader.GetEntry();
|
|
if (SkipNameFS(name_fs.c_str()) || skip_path(name_fs))
|
|
continue;
|
|
|
|
std::string name_utf8 = name_fs.ToUTF8();
|
|
if (name_utf8.empty())
|
|
continue;
|
|
|
|
const auto full_fs = path_fs / name_fs;
|
|
FileInfo fi;
|
|
if (!GetFileInfo(full_fs, fi, false))
|
|
continue;
|
|
|
|
if (fi.IsRegular())
|
|
r.Fmt("file: {}\n"
|
|
"size: {}\n",
|
|
name_utf8,
|
|
fi.GetSize());
|
|
else if (fi.IsDirectory())
|
|
r.Fmt("directory: {}\n", name_utf8);
|
|
else
|
|
continue;
|
|
|
|
time_print(r, "Last-Modified", fi.GetModificationTime());
|
|
}
|
|
|
|
return CommandResult::OK;
|
|
}
|
|
|
|
gcc_pure
|
|
static bool
|
|
IsValidName(const StringView s) noexcept
|
|
{
|
|
if (s.empty() || !IsAlphaASCII(s.front()))
|
|
return false;
|
|
|
|
return std::none_of(s.begin(), s.end(), [=](const auto &ch) {
|
|
return !IsAlphaASCII(ch) && ch != '_' && ch != '-';
|
|
});
|
|
}
|
|
|
|
gcc_pure
|
|
static bool
|
|
IsValidValue(const StringView s) noexcept
|
|
{
|
|
return std::none_of(s.begin(), s.end(), [](const auto &ch) { return (unsigned char)ch < 0x20; });
|
|
}
|
|
|
|
class PrintCommentHandler final : public NullTagHandler {
|
|
Response &response;
|
|
|
|
public:
|
|
explicit PrintCommentHandler(Response &_response) noexcept
|
|
:NullTagHandler(WANT_PAIR), response(_response) {}
|
|
|
|
void OnPair(StringView _key, StringView _value) noexcept override {
|
|
const std::string_view key{_key}, value{_value};
|
|
if (IsValidName(key) && IsValidValue(value))
|
|
response.Fmt("{}: {}\n", key, value);
|
|
}
|
|
};
|
|
|
|
CommandResult
|
|
handle_read_comments(Client &client, Request args, Response &r)
|
|
{
|
|
assert(args.size == 1);
|
|
|
|
const char *const uri = args.front();
|
|
|
|
PrintCommentHandler handler(r);
|
|
TagScanAny(client, uri, handler);
|
|
return CommandResult::OK;
|
|
}
|
|
|
|
/**
|
|
* Searches for the files listed in #artnames in the UTF8 folder
|
|
* URI #directory. This can be a local path or protocol-based
|
|
* URI that #InputStream supports. Returns the first successfully
|
|
* opened file or #nullptr on failure.
|
|
*/
|
|
static InputStreamPtr
|
|
find_stream_art(std::string_view directory, Mutex &mutex)
|
|
{
|
|
static constexpr auto art_names = std::array {
|
|
"cover.png",
|
|
"cover.jpg",
|
|
"cover.webp",
|
|
};
|
|
|
|
for(const auto name : art_names) {
|
|
std::string art_file = PathTraitsUTF8::Build(directory, name);
|
|
|
|
try {
|
|
return InputStream::OpenReady(art_file.c_str(), mutex);
|
|
} catch (...) {
|
|
auto e = std::current_exception();
|
|
if (!IsFileNotFound(e))
|
|
LogError(e);
|
|
}
|
|
}
|
|
return nullptr;
|
|
}
|
|
|
|
static CommandResult
|
|
read_stream_art(Response &r, const std::string_view art_directory,
|
|
size_t offset)
|
|
{
|
|
// TODO: eliminate this const_cast
|
|
auto &client = const_cast<Client &>(r.GetClient());
|
|
|
|
/* to avoid repeating the search for each chunk request by the
|
|
same client, use the #LastInputStream class to cache the
|
|
#InputStream instance */
|
|
auto *is = client.last_album_art.Open(art_directory, [](std::string_view directory,
|
|
Mutex &mutex){
|
|
return find_stream_art(directory, mutex);
|
|
});
|
|
|
|
if (is == nullptr) {
|
|
r.Error(ACK_ERROR_NO_EXIST, "No file exists");
|
|
return CommandResult::ERROR;
|
|
}
|
|
if (!is->KnownSize()) {
|
|
r.Error(ACK_ERROR_NO_EXIST, "Cannot get size for stream");
|
|
return CommandResult::ERROR;
|
|
}
|
|
|
|
const offset_type art_file_size = is->GetSize();
|
|
|
|
if (offset > art_file_size) {
|
|
r.Error(ACK_ERROR_ARG, "Offset too large");
|
|
return CommandResult::ERROR;
|
|
}
|
|
|
|
std::size_t buffer_size =
|
|
std::min<offset_type>(art_file_size - offset,
|
|
r.GetClient().binary_limit);
|
|
|
|
auto buffer = std::make_unique<std::byte[]>(buffer_size);
|
|
|
|
std::size_t read_size = 0;
|
|
if (buffer_size > 0) {
|
|
std::unique_lock<Mutex> lock(is->mutex);
|
|
is->Seek(lock, offset);
|
|
|
|
const bool was_ready = is->IsReady();
|
|
|
|
read_size = is->Read(lock, buffer.get(), buffer_size);
|
|
|
|
if (was_ready && read_size < buffer_size / 2)
|
|
/* the InputStream was ready before, but we
|
|
got only very little data; probably just
|
|
some data left in the buffer without doing
|
|
any I/O; let's wait for the next low-level
|
|
read to complete to get more data for the
|
|
client */
|
|
read_size += is->Read(lock, buffer.get() + read_size,
|
|
buffer_size - read_size);
|
|
}
|
|
|
|
r.Fmt("size: {}\n", art_file_size);
|
|
|
|
r.WriteBinary({buffer.get(), read_size});
|
|
|
|
return CommandResult::OK;
|
|
}
|
|
|
|
#ifdef ENABLE_DATABASE
|
|
|
|
/**
|
|
* Attempt to locate the "real" directory where the given song is
|
|
* stored. This attempts to resolve "virtual" directories/songs,
|
|
* e.g. expanded CUE sheet contents.
|
|
*/
|
|
[[gnu::pure]]
|
|
static std::string_view
|
|
RealDirectoryOfSong(Client &client, const char *song_uri,
|
|
std::string_view directory_uri) noexcept
|
|
try {
|
|
const auto *db = client.GetDatabase();
|
|
if (db == nullptr)
|
|
return directory_uri;
|
|
|
|
const auto *song = db->GetSong(song_uri);
|
|
if (song == nullptr)
|
|
return directory_uri;
|
|
|
|
AtScopeExit(db, song) { db->ReturnSong(song); };
|
|
|
|
if (song->real_uri == nullptr)
|
|
return directory_uri;
|
|
|
|
const char *real_uri = song->real_uri;
|
|
|
|
/* this is a simplification which is just enough for CUE
|
|
sheets (but may be incomplete): for each "../", go one
|
|
level up */
|
|
while ((real_uri = StringAfterPrefix(real_uri, "../")) != nullptr)
|
|
directory_uri = PathTraitsUTF8::GetParent(directory_uri);
|
|
|
|
return directory_uri;
|
|
} catch (...) {
|
|
/* ignore all exceptions from Database::GetSong() */
|
|
return directory_uri;
|
|
}
|
|
|
|
static CommandResult
|
|
read_db_art(Client &client, Response &r, const char *uri, const uint64_t offset)
|
|
{
|
|
const Storage *storage = client.GetStorage();
|
|
if (storage == nullptr) {
|
|
r.Error(ACK_ERROR_NO_EXIST, "No database");
|
|
return CommandResult::ERROR;
|
|
}
|
|
std::string uri2 = storage->MapUTF8(uri);
|
|
|
|
std::string_view directory_uri =
|
|
RealDirectoryOfSong(client,
|
|
uri,
|
|
PathTraitsUTF8::GetParent(uri2.c_str()));
|
|
|
|
return read_stream_art(r, directory_uri, offset);
|
|
}
|
|
#endif
|
|
|
|
CommandResult
|
|
handle_album_art(Client &client, Request args, Response &r)
|
|
{
|
|
assert(args.size == 2);
|
|
|
|
const char *uri = args.front();
|
|
size_t offset = args.ParseUnsigned(1);
|
|
|
|
const auto located_uri = LocateUri(UriPluginKind::INPUT, uri, &client
|
|
#ifdef ENABLE_DATABASE
|
|
, nullptr
|
|
#endif
|
|
);
|
|
|
|
switch (located_uri.type) {
|
|
case LocatedUri::Type::ABSOLUTE:
|
|
case LocatedUri::Type::PATH:
|
|
return read_stream_art(r,
|
|
PathTraitsUTF8::GetParent(located_uri.canonical_uri),
|
|
offset);
|
|
|
|
case LocatedUri::Type::RELATIVE:
|
|
#ifdef ENABLE_DATABASE
|
|
return read_db_art(client, r, located_uri.canonical_uri, offset);
|
|
#else
|
|
r.Error(ACK_ERROR_NO_EXIST, "Database disabled");
|
|
return CommandResult::ERROR;
|
|
#endif
|
|
}
|
|
r.Error(ACK_ERROR_NO_EXIST, "No art file exists");
|
|
return CommandResult::ERROR;
|
|
}
|
|
|
|
class PrintPictureHandler final : public NullTagHandler {
|
|
Response &response;
|
|
|
|
const size_t offset;
|
|
|
|
bool found = false;
|
|
|
|
bool bad_offset = false;
|
|
|
|
public:
|
|
PrintPictureHandler(Response &_response, size_t _offset) noexcept
|
|
:NullTagHandler(WANT_PICTURE), response(_response),
|
|
offset(_offset) {}
|
|
|
|
void RethrowError() const {
|
|
if (bad_offset)
|
|
throw ProtocolError(ACK_ERROR_ARG, "Bad file offset");
|
|
}
|
|
|
|
void OnPicture(const char *mime_type,
|
|
ConstBuffer<void> buffer) noexcept override {
|
|
if (found)
|
|
/* only use the first picture */
|
|
return;
|
|
|
|
found = true;
|
|
|
|
if (offset > buffer.size) {
|
|
bad_offset = true;
|
|
return;
|
|
}
|
|
|
|
response.Fmt("size: {}\n", buffer.size);
|
|
|
|
if (mime_type != nullptr)
|
|
response.Fmt("type: {}\n", mime_type);
|
|
|
|
buffer.size -= offset;
|
|
|
|
const std::size_t binary_limit = response.GetClient().binary_limit;
|
|
if (buffer.size > binary_limit)
|
|
buffer.size = binary_limit;
|
|
buffer.data = OffsetPointer(buffer.data, offset);
|
|
|
|
response.WriteBinary(buffer);
|
|
}
|
|
};
|
|
|
|
CommandResult
|
|
handle_read_picture(Client &client, Request args, Response &r)
|
|
{
|
|
assert(args.size == 2);
|
|
|
|
const char *const uri = args.front();
|
|
const size_t offset = args.ParseUnsigned(1);
|
|
|
|
PrintPictureHandler handler(r, offset);
|
|
TagScanAny(client, uri, handler);
|
|
handler.RethrowError();
|
|
return CommandResult::OK;
|
|
}
|