oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity
9,486 Commits 1 Branch 144 Tags 56 MiB
Commit Graph

9486 Commits

Author SHA1 Message Date
Max Kellermann 6ad336743d PlaylistFile: don't allow empty playlist name 2014-11-02 11:52:48 +01:00
Max Kellermann c882568ccd playlist/m3u: recognize the file suffix ".m3u8" 2014-11-02 11:50:56 +01:00
Max Kellermann f6b2899dd2 decoder/faad: remove workaround for ancient libfaad2 ABI bug 
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit()
prototype in its header declared the "samplerate" parameter to be
"unsigned long *", but internally, the function assumed it was
"uint32_t *" instead.  On 32 bit machines, that was no difference, but
on 64 bit, this left one portion of the return value uninitialized;
and worse, on big-endian, the wrong word was filled.  This bug had to
be worked around in MPD (commit 9c4e97a6).

A few months later, the bug was fixed in the FAAD CVS in commit 1.117
on file libfaad/decoder.c; the commit message was:

 "Use public headers internally to prevent duplicate declarations"

The commit message was too brief at best; the problem was not
duplicate declarations, but a prototype mismatch.  No mention of the
bug fix in the ChangeLog.

The MPD project never learned about this bug fix, and so MPD would
always pass a "uin32_t *" dressed up as a "unsigned long *".  Nearly 6
years later, it's about time to fix this second ABI problem.  Let's
kill the workaround!
 2014-11-02 11:50:56 +01:00
Steven OBrien bccd4ef2f7 decoder/ffmpeg: recognize MIME type audio/aacp 2014-11-02 11:50:56 +01:00
Max Kellermann 94c240a026 configure.ac: show DSD in result 2014-11-02 11:50:56 +01:00
Max Kellermann c50a0cf7bf output/roar: remove unnecessary "volatile" keyword 
A mutex acts as a memory barrier, and thus "volatile" is not
necessary.
 2014-11-02 11:50:56 +01:00
Max Kellermann c37f7abb79 TagString: use g_strndup() for unterminated string 
Fixes buffer overflow bug.
 2014-11-02 11:48:13 +01:00
Max Kellermann 432ce9b1de configure.ac: prepare for 0.18.17 2014-11-02 11:41:40 +01:00
Max Kellermann 054323c2bc lib/upnp/Discovery: add missing stdlib.h include 2014-11-02 11:04:13 +01:00
Max Kellermann a8770aa606 input/curl: fix curl_easy_setopt() parameter types 2014-11-01 14:09:30 +01:00
Max Kellermann 7d5442e103 Decoder, Playlist: ignore URI query string for plugin detection 
Use the new uri_get_suffix() overload that removes the query string.
 2014-11-01 13:41:18 +01:00
Max Kellermann eab32f2e5d util/UriUtil: add uri_get_suffix() overload that ignores query string 2014-11-01 12:45:47 +01:00
NanoTech d42c0f1dc5 Main: run the OS X native event loop after forking 2014-10-31 15:03:53 +01:00
NanoTech 6ad1e4d99a Revert "Main: run the OS X native event loop" 
This reverts commit f0be48ff90
(except for the NEWS entry).

If libdispatch (GCD) is used before forking, it
can't safely be used again after forking.
 2014-10-31 15:03:46 +01:00
Max Kellermann 7350144ab3 PlaylistFile: don't allow empty playlist name 2014-10-31 14:59:27 +01:00
Max Kellermann 54c591bd9d decoder/mad: fix negative replay gain values 
Negating an unsigned integer does not work.
 2014-10-28 22:22:30 +01:00
Max Kellermann 217d88f21f TextInputStream: don't ignore unterminated last line 2014-10-28 22:10:47 +01:00
Max Kellermann 394e3be482 playlist/m3u: recognize the file suffix ".m3u8" 2014-10-26 08:14:16 +01:00
Max Kellermann d7f024c510 OutputThread: fall back to PCM if given DSD sample rate is not supported 
Works around the "PCM conversion from f to dsd is not implemented"
error message that prevents DSD playback.
 2014-10-25 22:06:08 +02:00
Max Kellermann bc5a53574c decoder/faad: remove workaround for ancient libfaad2 ABI bug 
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit()
prototype in its header declared the "samplerate" parameter to be
"unsigned long *", but internally, the function assumed it was
"uint32_t *" instead.  On 32 bit machines, that was no difference, but
on 64 bit, this left one portion of the return value uninitialized;
and worse, on big-endian, the wrong word was filled.  This bug had to
be worked around in MPD (commit 9c4e97a6).

A few months later, the bug was fixed in the FAAD CVS in commit 1.117
on file libfaad/decoder.c; the commit message was:

 "Use public headers internally to prevent duplicate declarations"

The commit message was too brief at best; the problem was not
duplicate declarations, but a prototype mismatch.  No mention of the
bug fix in the ChangeLog.

The MPD project never learned about this bug fix, and so MPD would
always pass a "uin32_t *" dressed up as a "unsigned long *".  Nearly 6
years later, it's about time to fix this second ABI problem.  Let's
kill the workaround!
 2014-10-25 20:42:50 +02:00
Max Kellermann 30df709736 configure.ac: update VERSION_REVISION 2014-10-25 00:33:25 +02:00
Steven OBrien 8cd17ce045 decoder/ffmpeg: recognize MIME type audio/aacp 2014-10-25 00:26:58 +02:00
Max Kellermann 1bfbced258 configure.ac: add storage plugin section to result 2014-10-25 00:21:18 +02:00
Max Kellermann 6ac5980a17 configure.ac: show DSD in result 2014-10-25 00:19:01 +02:00
Max Kellermann 2e24adae89 configure.ac: require xmlto for --enable-documentation 2014-10-25 00:14:25 +02:00
Max Kellermann 188b94cb3e test/test_archive: don't use GLib 2014-10-25 00:08:04 +02:00
Max Kellermann c48733e34f fs/Charset: work around clang's -Wunused-const-variable 
MPD_PATH_MAX_UTF8 is only used by GLib-specific code currently.
 2014-10-25 00:07:25 +02:00
Max Kellermann f36db9bb04 configure.ac: auto-disable plugins that require GLib when --disable-glib is used 2014-10-24 23:46:20 +02:00
Max Kellermann 30dd29e251 configure.ac: improve database dependency checks 
Abort if --enable-libmpdclient or --enable-upnp are used with
--disable-database, instead of ignoring the mismatch silently.
 2014-10-24 23:43:21 +02:00
Max Kellermann 6cf1acfb48 test/DumpDatabase, ...: no g_thread_init() calls when GLib is disabled 2014-10-24 18:30:30 +02:00
Max Kellermann a7b09d3d1c OutputThread: close the output plugin after filter failure 
Fixes memory leak because ao_plugin_close() never gets called.
 2014-10-24 00:35:16 +02:00
Max Kellermann 8fc3768166 OutputThread: unlock mutex for CloseFilter() 
Be consistent.
 2014-10-24 00:29:03 +02:00
Max Kellermann b07bddf742 output/roar: remove unnecessary "volatile" keyword 
A mutex acts as a memory barrier, and thus "volatile" is not
necessary.
 2014-10-23 23:29:56 +02:00
Max Kellermann 220f957cd8 pcm/ChannelsConverter: fix variable used to generate error message 
Use the "_format" parameter instead of the (uninitialized) "format"
attribute.
 2014-10-23 22:44:53 +02:00
Max Kellermann 8ce48d83eb pcm/FormatConverter: move check to Open() 
Report unsupported format while opening the filter, not later when the
first conversion takes place.
 2014-10-23 22:42:08 +02:00
Max Kellermann 200cdb6b0a pcm/PcmConvert: assign {src,dest}_format at the end 
Fixes assertion failure in destructor by not assigning
{src,dest}_format when an error occurs.
 2014-10-23 22:39:51 +02:00
Max Kellermann d9fb40203a pcm/PcmConvert: make AudioFormat parameters "const" 2014-10-23 22:39:51 +02:00
Max Kellermann 2d9e972195 configure.ac: prepare for 0.19.2 2014-10-23 21:57:04 +02:00
Max Kellermann 97a1a04116 release v0.19.1 2014-10-19 01:03:17 +02:00
Max Kellermann 493cd866f1 TextInputStream: manually shift the buffer before reading 
Fixes truncated lines in m3u and cue files (regression by commit
67958f7).
 2014-10-19 00:50:52 +02:00
Max Kellermann 063d369672 util/StaticFifoBuffer: make Shift() public 2014-10-19 00:49:08 +02:00
Max Kellermann a0fae8dacc playlist/extm3u: strip first line for #EXTM3U detection 2014-10-17 20:45:18 +02:00
Max Kellermann bc840b69d5 Makefile.am: distribute systemd/mpd.socket 
The file systemd/mpd.service.in is being distributed implicitly, but
systemd/mpd.socket is not and needs to be added to EXTRA_DIST.
 2014-10-12 08:38:52 +02:00
Max Kellermann 85301853d6 ThreadInputStream: call ThreadRead() inside the thread instead of Read() 
Fixes deadlock bug in the "mms" plugin.
 2014-10-11 21:59:06 +02:00
Max Kellermann 7cd53fb452 ThreadInputStream: add assertions 2014-10-11 21:57:31 +02:00
Max Kellermann 538ddf7af2 NEWS: add missing line 2014-10-11 21:48:52 +02:00
Max Kellermann d5afa181f7 NEWS: fix typo in version number 2014-10-11 21:48:27 +02:00
Max Kellermann 8ed4124184 util/DynamicFifoBuffer: make the "Range" type public 
Export it from the protected base class.  This fixes a build failure
on Mac OS X.
 2014-10-11 20:28:08 +02:00
Max Kellermann 160242a74f configure.ac: prepare for 0.19.1 2014-10-11 20:25:19 +02:00
Max Kellermann 81b83bc904 release v0.19 2014-10-10 23:49:31 +02:00