oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity
3,875 Commits 1 Branch 144 Tags 56 MiB
eb5b3ce553
Commit Graph

29 Commits

Author SHA1 Message Date
Max Kellermann
6823217697 ls: moved generic URI utilities to uri.c 
"ls" is a bad name for a library which parses URIs.  We'll move the
rest of the "ls" library later.
 2009-02-25 16:44:06 +01:00
Max Kellermann
bdfb6c239a playlist: moved is_valid_playlist_name() to stored_playlist.c 2009-01-25 14:19:28 +01:00
Max Kellermann
1a59afa388 stored_playlist: moved configuration variables from playlist.c 
Don't declare and export variables specific to stored playlists in
playlist.c/playlist.h.
 2009-01-25 13:53:16 +01:00
Max Kellermann
2c45224be7 mapper: added dot to PLAYLIST_FILE_SUFFIX 
Some code will be a little bit simpler if the dot is part of the
string literal.
 2009-01-25 13:43:57 +01:00
Max Kellermann
9933144de7 mapper: make the playlist directory optional 2009-01-18 16:15:45 +01:00
Max Kellermann
5ed5aa99ac path: allocate buffer in fs_charset conversion functions 
Don't use fixed static buffers.  GLib allocates a new string for us
anyway, let's just return this one instead of copying it.
 2009-01-08 21:20:46 +01:00
Max Kellermann
da69382273 path: removed pfx_dir() 
Use GLib's g_build_filename() instead of pfx_dir().
 2009-01-04 19:37:19 +01:00
Max Kellermann
fed719197c song: allocate the result of song_get_url() 2009-01-04 19:09:34 +01:00
Max Kellermann
923d2c966f mapper: allocate the result of map_fs_to_utf8() 2009-01-04 18:59:47 +01:00
Max Kellermann
17d8bdb427 playlist: use uri_has_scheme() instead of isRemoteUrl() 
For internal checks (i.e. not in command.c), we need to check whether
an URI is in the databse, in the local file system or a remote URI
with a scheme.
 2009-01-04 16:23:33 +01:00
Max Kellermann
9e46c32004 playlist: use GLib instead of utils.h 2009-01-02 17:22:47 +01:00
Max Kellermann
0c422838a8 playlist: use g_file_test() instead of stat() 
To find out whether a file exists, use g_file_test() instead of
stat(), because it is more portable and easier to use.
 2009-01-01 19:22:07 +01:00
Max Kellermann
80fa9183e4 mapper: allocate playlist path from heap 
Don't pass a static buffer to map_spl_utf8_to_fs().
 2009-01-01 19:17:44 +01:00
Max Kellermann
95b3430f52 removed os_compat.h 
Only include headers which are really needed.  os_compat.h aimed to
make MPD easily portable, but was never actually made portable.
 2008-12-29 17:28:32 +01:00
Max Kellermann
859aac7242 utils: removed myFgets() 
Replaced myFgets() with fgets() + g_strchomp().
 2008-12-28 19:54:49 +01:00
Max Kellermann
a94e59ca21 stored_playlist: fix integer overflow in length estimation 
With a large maximum playlist length, the integer multiplication
"playlist_max_length * MPD_PATH_MAX" may overflow.  Change that to a
division.  This was not a dangerous bug, since it was only used for
a quick estimate.
 2008-12-24 17:40:41 +01:00
Max Kellermann
3287726736 ls: removed isValidRemoteUtf8Url() 
The function didn't do anything useful, it was just several lines
obfuscating that it was only forwarding isRemoteUrl()'s return value.
 2008-12-16 21:15:20 +01:00
Max Kellermann
d8e877e335 path: moved playlist_dir to mapper.c 
Added the function map_spl_utf8_to_fs() which replaces
utf8_to_fs_playlist_path().
 2008-10-31 16:47:14 +01:00
Max Kellermann
4bc2def15c stored_playlist: fixed signed comparison warning 
Cast playlist_max_length to off_t before comparing it to stat.st_size.
 2008-10-26 16:26:44 +01:00
Max Kellermann
fdc9a4cc5a stored_playlist: emit idle event on delete 
The "rm" command did not send notifications to idle clients.  Add it.
 2008-10-23 09:54:39 +02:00
Max Kellermann
93598e28f4 stored_playlist: renamed and moved spl_delete() to stored_playlist.c 
The function deletePlaylist() shouldn't be in playlist.c.
 2008-10-23 09:54:32 +02:00
Max Kellermann
39f0c41fbf stored_playlist: spl_load() returns GPtrArray 
Don't use our deprecated linked list library, use GLib's GPtrArray
instead.
 2008-10-23 09:54:28 +02:00
Max Kellermann
3958457256 stored_playlist: unsigned index arguments 
Pass index arguments as unsigned integers.  They must not be negative,
and even if some caller accidently passes -1, it won't pass the bound
checks (since it's now 2**32-1).
 2008-10-23 09:53:34 +02:00
Max Kellermann
a65e20b50e stored_playlist: added spl_list() 
spl_list() provides an interface for enumerating all stored playlists.
This separates the internal playlist logic from the protocol specific
function lsPlaylists().
 2008-10-22 19:15:50 +02:00
Max Kellermann
3a164ef8e6 stored_playlist: spl_append_uri() returns enum playlist_result 
The return value of spl_append_uri() was somewhat buggy: some branches
returned ACK_* values, and some an enum playlist_result.  Unify this.
 2008-10-22 17:24:40 +02:00
Max Kellermann
d2606baa79 stored_playlist: de-CamelCase moved function 
Rename addToStoredPlaylist() to spl_append_uri(), and remove the
clearStoredPlaylist() macro.
 2008-10-22 17:23:58 +02:00
Max Kellermann
1da921f03c stored_playlist: moved functions from playlist.c 
The two functions clearStoredPlaylist() and addToStoredPlaylist()
don't belong into playlist.c.  clearStoredPlaylist() was a wrapper for
spl_clear(), and is converted into a CPP macro for now.
 2008-10-22 17:23:11 +02:00
Max Kellermann
ac853b6165 stored_playlist: no CamelCase 
Renamed all public functions, prefix is "spl_".
 2008-10-22 17:21:59 +02:00
Max Kellermann
a4def81313 renamed storedPlaylist.c to stored_playlist.c 
No CamelCase in file names.
 2008-10-22 17:21:57 +02:00