Commit Graph

28 Commits

Author SHA1 Message Date
5348f8c9c8 copyright year 2021 2021-01-01 19:54:28 +01:00
97425d56e7 remove gcc_unused
[[maybe_unused]] (introduced in C++17) is standard C++.

https://clang.llvm.org/docs/AttributeReference.html#maybe-unused-unused
says that this is equivalent to the GNU unused attribute.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-03-16 00:08:21 -07:00
cd612c4eef AudioFormat: move to pcm/ 2020-01-18 20:24:59 +01:00
2817bf9e95 copyright year 2020 2020-01-18 19:23:49 +01:00
af99f9fc90 pcm/Volume: convert S16 to S24 to preserve quality and reduce noise
Applying software volume to S16 samples means several bits of
precision are lost; at 25% volume, two bits are lost.  Additionally,
dithering adds some noise.

The problem gets worse when you apply the software volume code twice:
for the software mixer volume, and again for the replay gain.  This
loses some more precision and adds even more dithering noise, which
can become audible (see
https://github.com/MusicPlayerDaemon/MPD/issues/542).

By converting everything to 24 bit, we need to shift only two bits to
the right instead of ten, losing nearly no precision, and dithering is
not needed.  Even if the output device is unable to play S24 directly,
we can convert back to S16 with only one stage of dithering.

Closes https://github.com/MusicPlayerDaemon/MPD/issues/542
2019-07-30 20:03:37 +02:00
5fa7610264 pcm/Volume: Open() returns output sample format
Prepare for a new mode which may convert to a different sample format
when applying volume, to reduce dithering.
2019-07-05 19:03:00 +02:00
a139279575 Copyright year 2019 2019-06-17 11:17:30 +02:00
ce49d99c2f check.h: remove obsolete header
Since we switched from autotools to Meson in commit
94592c1406, we don't need to include
`config.h` early to properly enable large file support.  Meson passes
the required macros on the compiler command line instead of defining
them in `config.h`.

This means we can include `config.h` at any time, whenever we want to
check its macros, and there are no ordering constraints.
2018-11-19 16:33:49 +01:00
f5c9071494 *: copyright year 2018 2018-10-31 17:54:59 +01:00
d6529d8c60 test/*: catch and print all exceptions 2018-07-17 21:58:39 +02:00
5900253b85 update copyright year 2017-01-03 20:48:59 +01:00
13001c018c AudioParser: throw exception on error 2016-10-28 22:36:04 +02:00
ae1eb9ccde pcm/Convert: migrate from class Error to C++ exceptions 2016-09-09 14:44:13 +02:00
1d67aa7bf2 update copyright year to 2016 2016-02-26 17:54:05 +01:00
7cc33d0f27 test/stdbin.h: remove obsolete header 2015-08-15 16:37:58 +02:00
712ed555e6 Copyright year 2015 2015-01-01 19:48:13 +01:00
4f83c60296 copyright year 2014 2014-01-13 22:31:55 +01:00
3f3ae48ff4 test: add missing includes 2014-01-07 23:57:39 +01:00
1ad52f131c test/*: use fprintf(stderr,...) and Log() instead of g_printerr()
Avoid GLib.
2013-12-24 14:44:08 +01:00
8edde7a4b3 pcm/Volume: convert to class
Prepare for adding state.
2013-12-23 10:58:37 +01:00
6d21b9448a pcm/PcmVolume: rename to Volume.cxx 2013-12-23 10:35:21 +01:00
29030b54c9 util/Error: new error passing library
Replaces GLib's GError.
2013-09-04 18:14:22 +02:00
85b77b81ca *: use gcc.h macros instead of GLib 2013-08-04 23:48:01 +02:00
d1e7b4e381 audio_format: convert to C++ 2013-08-03 21:37:56 +02:00
c654c7630a pcm_*: move to src/pcm/ 2013-04-09 01:24:52 +02:00
1b175025fe pcm_*: convert to C++ 2013-01-31 21:11:06 +01:00
d664baff26 audio_{parser,config}: convert to C++ 2013-01-30 21:47:12 +01:00
cfeeb7af2e test/run_encoder, ...: convert to C++ 2013-01-30 21:39:43 +01:00