oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity
15,615 Commits 2 Branches 145 Tags
9f013f7de4f9cfff03e8dc552f5fd0ecdea7daef
Commit Graph

15615 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rosen Penev 2b3d6461e3 remove unused ctype.h header 
None of the functions in these files come from ctype.h

Also changed one instance of isdigit to the C++ variant.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-03-12 15:43:50 -07:00
Rosen Penev ab9f5d2067 replace assert.h with cassert 
The former was deprecated with C++14.

According to the C++11 and C++17 standards, both files are identical.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-03-12 15:25:38 -07:00
Max Kellermann a718086ffb test/run_convert: add option --config 2020-03-12 21:41:39 +01:00
Max Kellermann 8d40e68dec test/run_convert: add option --verbose 2020-03-12 21:41:39 +01:00
Max Kellermann de0affe115 test/run_convert: move code to ParseCommandLine() 2020-03-12 21:40:27 +01:00
Max Kellermann 26e718c7c3 doc/user.rst, .travis.yml: drop GCC 6 support 
Debian Stable (Buster) has GCC 8 and Ubuntu LTS (18.04) has GCC 7.

This will unlock a lot of C++17 features like `std::string_view`.
 2020-03-12 21:37:07 +01:00
Max Kellermann 82743dfd02 playlist/asx: concatenate multiple CharacterData fragments 
Similar to c45f113856
 2020-03-12 21:07:37 +01:00
Rosen Penev f00f8b002a [clang-tidy] use nodiscard 
Introduced in C++17. It replaces gcc's warn_unused_result.

Found with modernize-use-nodiscard.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-03-12 12:59:16 -07:00
Max Kellermann 33694642bd playlist/asx: add State::TAG 2020-03-12 20:42:16 +01:00
Max Kellermann c71242d743 playlist/asx: use tag_table to convert element name to TagType 2020-03-12 20:40:18 +01:00
Max Kellermann 2229e86673 client/Expire: cancel the BackgroundCommand before deleting it 
Fixes assertion failure.

Closes https://github.com/MusicPlayerDaemon/MPD/issues/774
 2020-03-12 20:32:08 +01:00
Max Kellermann f24c274f5c client/BackgroundCommand: fix typo in comment 2020-03-12 20:32:07 +01:00
Max Kellermann 3824bf66ca lib/chromaprint/DecoderClient: add assertion 2020-03-12 20:32:07 +01:00
Max Kellermann d942f874ae lib/chromaprint/DecoderClient: check ready in GetCommand() 
Fixes access to uninitialized memory (`remaining_bytes` isn't
initialized until Ready() is called) and fixes spurious
`getfingerprint` failures.
 2020-03-12 20:31:46 +01:00
Max Kellermann 01632d37ef Merge branch 'v0.21.x' 2020-03-12 08:11:08 +01:00
Max Kellermann c45f113856 playlist/xspf: concatenate multiple CharacterData fragments 
Closes https://github.com/MusicPlayerDaemon/MPD/issues/781
 2020-03-12 08:02:58 +01:00
Max Kellermann e0a8fd398c playlist/xspf: add State::TAG 2020-03-12 08:00:54 +01:00
Max Kellermann 3e97058151 playlist/xspf: move location.empty() check to _start_element() 2020-03-11 20:54:53 +01:00
Max Kellermann 51b1dd8672 playlist/xspf: use tag_table to convert element name to TagType 2020-03-11 20:51:47 +01:00
Max Kellermann 98a7d8da6c playlist/xspf: use C++11 initializer 2020-03-11 20:51:10 +01:00
Max Kellermann acb29f792f tag/Mask: fix yet another typo, this time in Unset() 
Similar to commits e8f2f98048 and
ff1ff1e54a

Closes https://github.com/MusicPlayerDaemon/MPD/issues/783
 2020-03-11 20:34:02 +01:00
Max Kellermann cd364023ae .travis.yml: rename "matrix" to "jobs" 
Travis has changed the canonical name for this a while ago.

(Now really.  The last commit for this was empty.)
 2020-03-07 09:31:46 +01:00
Max Kellermann 8d34a1cfc6 archive/iso9660: skip empty filenames 
Aparently, libcdio sometimes returns empty filenames, causing MPD
crashes.  This shouldn't really happen, and I consider this a libcdio
bug - but if it happens, people blame MPD, so let's add a check.

Closes https://github.com/MusicPlayerDaemon/MPD/issues/776
 2020-03-07 09:30:56 +01:00
Max Kellermann 73a1f078a6 archive/iso9660: use IsSpecialFilename() 2020-03-07 09:30:56 +01:00
Max Kellermann b7ce452308 fs/Traits: add IsSpecialFilename() 
Merge some duplicate code in a central library.
 2020-03-07 09:30:56 +01:00
Max Kellermann 5faf76051d .travis.yml: force updating homebrew on OSX 
Workaround for Travis failures as described in
 https://travis-ci.community/t/macos-build-fails-because-of-homebrew-bundle-unknown-command/7296/18
 2020-03-07 09:30:56 +01:00
Max Kellermann 5fe70a3417 .travis.yml: rename "matrix" to "jobs" 
Travis has changed the canonical name for this a while ago.
 2020-03-07 09:30:56 +01:00
Thomas Klausner 7a68b1e71f Adapt SolarisOutputPlugin.cxx to be usable on NetBSD. 2020-02-29 10:05:29 +01:00
Thomas Klausner d5468dfe89 Add missing header. 
Fixes
../src/time/ISO8601.cxx:67:24: error: use of undeclared identifier 'strtoul'
        unsigned long value = strtoul(s, &endptr, 10);
                              ^
../src/time/ISO8601.cxx:77:14: error: use of undeclared identifier 'strtoul'
                        minutes = strtoul(s, &endptr, 10);
                                  ^

on NetBSD with clang 9.0.0.
 2020-02-29 10:04:54 +01:00
John Regan 976372ff63 gme: check for empty metadata strings instead of nullptr 
Using libgme 0.6.2 on macOS, it appears that gme_info_t strings can be
empty, which creates weird track titles: (001/050)

This adds an additional check for an empty string.
 2020-02-25 20:12:08 +01:00
Max Kellermann c977d646c7 Merge remote-tracking branches 'neheb/j', 'neheb/f', 'neheb/qwe' and 'neheb/hgf' 2020-02-20 16:58:17 +01:00
Rosen Penev ac50bb5d2b [clang-tidy] remove needless std::move 
Found with performance-move-const-arg

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-02-20 16:47:34 +01:00
Max Kellermann 85e33f7d60 lib/dbus/Udisks2: make path non-const to allow moving from it 2020-02-20 16:47:32 +01:00
Max Kellermann 7646866a32 neighbor/smbclient: make iterators non-const to enable the std::move() 2020-02-20 16:47:32 +01:00
Max Kellermann d072b3cb17 storage/smbclient: remove misplaced .c_str() call 2020-02-20 16:47:32 +01:00
Max Kellermann 646fef108a storage/composite: make variable non-const to enable the std::move() 2020-02-20 16:41:38 +01:00
Max Kellermann d1cc73775f Instance: flush input cache on SIGHUP 2020-02-17 15:23:05 +01:00
Max Kellermann 29d05cdb8e unix/SignalHandlers: pass Instance to ...Init() 2020-02-17 15:23:03 +01:00
Max Kellermann 322d6f2a40 doc/user.rst: add section "Signals" 2020-02-17 15:22:45 +01:00
Max Kellermann 7729713924 doc/user.rst: add section "Starting MPD" 
Move the existing systemd sections over there.
 2020-02-17 12:21:05 +01:00
Rosen Penev 351a4a80d2 [clang-tidy] use using instead of typedef 
Found with modernize-use-using

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-02-16 19:22:32 -08:00
Rosen Penev 87f7b0f0bb [clang-tidy] use emplace_back 
Found with hicpp-use-emplace

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-02-16 19:21:55 -08:00
Rosen Penev 6d3190fe5f [clang-tidy] use = default 
Found with modernize-use-equals-default

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-02-16 17:10:18 -08:00
Rosen Penev 5d787806fe [clang-tidy] add ending namespace comments 
Found with llvm-namespace-comment

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-02-16 16:44:37 -08:00
Max Kellermann 9abb686eeb increment version number to 0.21.21 2020-02-16 20:48:46 +01:00
Max Kellermann dea0cc165d input/cache/Manager: add method Flush() 2020-02-16 20:46:24 +01:00
Max Kellermann 07e0a31d02 Merge tag 'v0.21.20' 
release v0.21.20
 2020-02-16 20:46:13 +01:00
Max Kellermann f24bcc7f42 release v0.21.20 v0.21.20 2020-02-16 20:43:35 +01:00
Max Kellermann 89800324cb .travis.yml: use GTest 1.8.0 instead of HEAD 
Fixes strange C++11 compatibility problems during GTest installation:

 /tmp/gtest-20200216-20679-mu1044/googletest/include/gtest/internal/gtest-internal.h:1249:1: error: unknown type name 'constexpr'
 constexpr bool TypedTestCaseIsDeprecated() { return true; }

 /tmp/gtest-20200216-20679-mu1044/googletest/include/gtest/internal/gtest-internal.h:1249:11: error: expected unqualified-id
 constexpr bool TypedTestCaseIsDeprecated() { return true; }

 /tmp/gtest-20200216-20679-mu1044/googletest/include/gtest/internal/gtest-internal.h:1254:1: error: unknown type name 'constexpr'
 constexpr bool RegisterTypedTestCase_P_IsDeprecated() { return true; }
 2020-02-16 20:33:15 +01:00
Rosen Penev 050e30418c Fix travis 
pip is bugged on arm64 and s390x. Add --no-cache-dir to fix. For
consistency, it doesn't hurt to add everywhere.
 2020-02-16 19:29:30 +01:00