oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity
1,127 Commits 1 Branch 144 Tags 56 MiB
7fdcd56a99
Commit Graph

62 Commits

Author SHA1 Message Date
Eric Wong
a234780aab sparse: ANSI-fy function declarations 
These are just warnings from sparse, but it makes the output
easier to read.  I ran this through a quick perl script, but
of course verified the output by looking at the diff and making
sure the thing still compiles.

here's the quick perl script I wrote to generate this patch:
----------- 8< -----------
use Tie::File;
defined(my $pid = open my $fh, '-|') or die $!;
if (!$pid) {
open STDERR, '>&STDOUT' or die $!;
exec 'sparse', @ARGV or die $!;
}
my $na = 'warning: non-ANSI function declaration of function';
while (<$fh>) {
print STDERR $_;
if (/^(.+?\.[ch]):(\d+):(\d+): $na '(\w+)'/o) {
my ($f, $l, $pos, $func) = ($1, $2, $3, $4);
$l--;
tie my @x, 'Tie::File', $f or die "$!: $f";
print '-', $x[$l], "\n";
$x[$l] =~ s/\b($func\s*)\(\s*\)/$1(void)/;
print '+', $x[$l], "\n";
untie @x;
}
}

git-svn-id: https://svn.musicpd.org/mpd/trunk@4378 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-17 00:15:34 +00:00
Eric Wong
b4df8b8f88 De-inline non-trivial, non-performance-critical functions 
Functions that should stay inlined should have an explanation
attached to them.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4355 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-15 13:42:57 +00:00
Avuton Olrich
be006b86ed [CLEANUP] Remove unused code 
Fix whitespace->tabs
Use static where possible

git-svn-id: https://svn.musicpd.org/mpd/trunk@4346 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-15 04:51:31 +00:00
J. Alexander Treuman
2fa7125cce Change shank's email address 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4333 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-14 19:37:45 +00:00
Avuton Olrich
a37348a74f Huge header update, update the copyright and add 
the GPL header where necessary

git-svn-id: https://svn.musicpd.org/mpd/trunk@4317 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-13 19:20:34 +00:00
J. Alexander Treuman
18306dfbd3 Add back the id3v1_encoding option. Now it really will convert id3v1 only. 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4282 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-06-21 20:52:51 +00:00
J. Alexander Treuman
9e393393e0 Cleanup getId3Info. 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4281 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-06-21 20:24:43 +00:00
J. Alexander Treuman
bdf4107117 Rewrote id3Dup to search for tags manually. Now libid3tag will actually tell us the version of the tag we got. As an added benefit we also do fewer reads/mallocs when scanning mp3s during database update/creation. 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4277 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-06-21 15:12:41 +00:00
Qball Cow
4324150b42 Added Disc # metadata item based on bug 571 (added id3v2 support) 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4131 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-04-30 19:55:56 +00:00
Eric Wong
6963502213 merge with mpd/trunk up to r3925 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3926 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-03-16 06:52:46 +00:00
Eric Wong
f8597ccf25 remove C++ style comments 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3689 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-11-19 10:52:47 +00:00
Qball Cow
edcfbef90d Patch to make the configure flag for mpd-mad and mpd-libid3tag more logic (from ticho) 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3477 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-09-08 21:08:02 +00:00
Warren Dukes
a97110661c fix bug 421: database read failed with newline in ID3-tag 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3231 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-04-30 01:50:29 +00:00
Warren Dukes
75a967014f removed the id3v1_encoding config option, there's no way to guarantee that we actually got a given field from the v1 and not the v2 tag 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3052 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-03-11 02:59:26 +00:00
Warren Dukes
01b708bc13 add support for parsing ape tags in musepack files 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3030 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-03-07 00:51:21 +00:00
Warren Dukes
3bdee55217 added composer, performer, and comment metadata items 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3022 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-03-05 22:24:10 +00:00
Warren Dukes
76addf155e ok, dottemag's id3v1_encoding config parameter should now work. 
dottemag can you test it? i made one little tweak

git-svn-id: https://svn.musicpd.org/mpd/trunk@2620 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-11-11 21:43:39 +00:00
Warren Dukes
41bf67ae99 we can't store more than 255 tag items per tag 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2592 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-11-10 22:13:30 +00:00
Warren Dukes
c5d27d8eaa merge changes from metadata-rewrite branch 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2589 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-11-10 21:58:27 +00:00
Warren Dukes
58dbe4bb5d merge shank-rewrite-config changes 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2375 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-10-28 05:14:55 +00:00
Warren Dukes
cc66392570 apply dottemag's id3v1 encodings patch 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2163 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-10-05 17:16:26 +00:00
Warren Dukes
ce2fe32c54 fix booboo in validateUtf8 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2011 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-08-12 12:17:54 +00:00
Warren Dukes
26d4e89d15 stripReturnChar() in validateUtf8tag() 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2001 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-08-11 12:06:55 +00:00
Warren Dukes
608a15a885 bug fix for metadata again, had an extra "!" in mpdTagsAreEqual() 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1371 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-07 15:00:18 +00:00
Warren Dukes
b29f73c819 mechanism for updating metadata while decoding 
vorbis comments are updated on the fly for streams
need to decode icy metadata
buffering of metadata needs to be hardened, to ensure that player has already read a particular metachunk or passed over it

git-svn-id: https://svn.musicpd.org/mpd/trunk@1358 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-06 19:41:03 +00:00
Warren Dukes
4e53282469 todo update 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1352 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-06 16:42:14 +00:00
Warren Dukes
3c0c34bcb7 '\n' are bad 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1296 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-02 02:07:07 +00:00
Warren Dukes
16da97e4c8 parsing mp3 id3v2 tags on the fly for streams 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1281 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-01 12:50:15 +00:00
Warren Dukes
199ad37e22 more efficient of updating of metadata 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1277 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-01 10:28:06 +00:00
Warren Dukes
000e053ce7 icynames are now copied to title of streams 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1258 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-31 11:42:46 +00:00
Warren Dukes
9f0cbe9e49 aac_plugin 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1250 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-31 02:56:14 +00:00
Warren Dukes
3aba9b2a66 mp4_plugin 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1249 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-31 02:42:22 +00:00
Warren Dukes
5d392c70cb audiofile_plugin 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1248 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-31 02:31:55 +00:00
Warren Dukes
97fe75a0bf little cleanup of plugin stuff 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1247 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-31 02:21:06 +00:00
Warren Dukes
30424cb3e9 flac_plugin 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1246 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-31 01:54:10 +00:00
Warren Dukes
fd6aa25359 mp3 and ogg plugin stuff 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1245 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-31 01:21:17 +00:00
Warren Dukes
fbcb995a81 cleanup EINTR checking in tag.c 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1127 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-21 22:52:54 +00:00
Warren Dukes
48a58073dd add new inputStream stuff, hopefully something major isn't foobar'd 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1049 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-18 02:46:13 +00:00
Warren Dukes
12d3bd0716 fix a bug in update if unable to open mp4 file, would cause a segfault 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1025 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-15 19:39:55 +00:00
Warren Dukes
ef9f832fb3 mp4/aac now use InputStream 
git-svn-id: https://svn.musicpd.org/mpd/trunk@925 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-06 18:49:04 +00:00
Warren Dukes
549344d38a add vim shiznit to end of all source files 
git-svn-id: https://svn.musicpd.org/mpd/trunk@750 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-14 14:53:41 +00:00
Warren Dukes
860f8bda71 ok, rework myfprintf so it uses write() and never use any file stream 
print functions.  this way we can always know wtf is going on!
also, remove some places where we were using fprintf and printf instead of
myfprintf

git-svn-id: https://svn.musicpd.org/mpd/trunk@734 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-13 19:08:38 +00:00
Warren Dukes
5a50fa7147 block signals when writing db to ensure db isn't corrupted 
git-svn-id: https://svn.musicpd.org/mpd/trunk@730 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-13 17:08:31 +00:00
Warren Dukes
8c96c2d363 rename all ascii/utf8 stuff to latin1/utf8 
git-svn-id: https://svn.musicpd.org/mpd/trunk@718 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-13 13:52:16 +00:00
Warren Dukes
f765c26275 fix a small booboo and add some debugging stuff 
git-svn-id: https://svn.musicpd.org/mpd/trunk@708 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-13 02:38:09 +00:00
Warren Dukes
375e3ffed4 add my own utf8/ascii converters and utf8 validator 
validate all mpd tags on import, if they are invalid, assume they are ascii
and convert to utf8

git-svn-id: https://svn.musicpd.org/mpd/trunk@707 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-13 02:20:46 +00:00
Warren Dukes
063affb047 we no longer need to block signals in tag.c, since update is now done 
in a seperate process

git-svn-id: https://svn.musicpd.org/mpd/trunk@696 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-11 21:43:23 +00:00
Warren Dukes
4c1eb9225d add aac_decode.[ch] and start working on it 
also, if locale is C or POSIX, set fs charset to iso-8859-1

git-svn-id: https://svn.musicpd.org/mpd/trunk@347 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-21 21:32:23 +00:00
Warren Dukes
b72f591641 parse length from Aac files and ID3 tags 
git-svn-id: https://svn.musicpd.org/mpd/trunk@346 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-21 18:12:37 +00:00
Warren Dukes
1bb75913c3 begin parsing work on AAC info parsing 
git-svn-id: https://svn.musicpd.org/mpd/trunk@345 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-21 16:34:06 +00:00