oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity
4,081 Commits 1 Branch 144 Tags 56 MiB
617a4fd2d2
Commit Graph

3472 Commits

Author SHA1 Message Date
Max Kellermann
a5a15beac2 pcm_convert: added 32 bit support 
All PCM sub libraries have 32 bit support now.  Add support to the
glue function pcm_convert().
 2009-03-02 16:41:10 +01:00
Max Kellermann
3165e26f9a pcm_format: added conversion from 32 bit 
Support converting 32 bit samples to any other supported sample
format.
 2009-03-02 16:41:08 +01:00
Max Kellermann
d4e4c57b8d pcm_format: added pcm_convert_to_32() 
Added code to convert all other sample formats to 32 bit.
 2009-03-02 16:39:54 +01:00
Max Kellermann
d24f2ba5ee pcm_dither: added pcm_dither_32_to_16() 
For 32 bit dithering, reuse the 24 bit dithering code, but apply a 8
bit right shift first.
 2009-03-02 16:37:11 +01:00
Max Kellermann
78e08f655a pcm_dither: renamed struct pcm_dither_24 to struct pcm_dither 
There is nothing 24 bit specific in the pcm_dither_24 struct.  Since
we want to reuse the struct for 32 bit dithering, let's drop the "_24"
suffix from the struct name.
 2009-03-02 16:37:05 +01:00
Max Kellermann
d9c1434298 pcm_resample: use 24 bit resampling code for 32 bit samples 
Resampling 32 bit samples is the same as resampling 24 bit samples -
both are stored in the int32_t type.
 2009-03-02 16:37:00 +01:00
Max Kellermann
1b31f52285 pcm_channels: added implementation for 32 bit samples 
Some 24 bit code can be reused.  The 32 bit variant has to use 64 bit
integers, because 32 bit integers could overflow.  This may be a
performance hit on 32 bit CPUs.
 2009-03-02 16:36:49 +01:00
Max Kellermann
062f37071c audio_format: allow 32 bit samples 
This is the first patch in a series to enable 32 bit audio samples in
MPD.  32 bit samples are more tricky than 24 bit samples, because the
integer may overflow when you operate on a sample.
 2009-03-02 15:46:09 +01:00
Max Kellermann
8c0bce0b94 audio_format: allow up to 8 channels 
audio_valid_sample_format() verifies the number of channels.  Let's
just say up to 8 channels is allowed (which is possible with some
consumer sound chips).  I don't know if there are bigger cards, and
since I cannot test it, I'll limit it to 8 for now.
 2009-03-02 15:43:45 +01:00
Max Kellermann
a1561252d0 directory: directory_load() returns GError 
Do error reporting with GLib's GError library in this library, too.
 2009-03-02 15:42:42 +01:00
Max Kellermann
c0ffec2fd1 database: db_load() returns GError 
Do error reporting with GLib's GError library.
 2009-03-02 15:42:21 +01:00
Max Kellermann
eb5b3ce553 database: no CamelCase 
Renamed a bunch of variables.
 2009-03-02 15:41:44 +01:00
Max Kellermann
b7bfa24f22 pcm_volume: return bool 
Don't abort MPD when a sample format is not supported by pcm_volume().
 2009-03-02 09:42:16 +01:00
Max Kellermann
0579b6ed27 pcm_volume: no CamelCase 2009-03-01 20:11:41 +01:00
Max Kellermann
4194f4b18b audio_parser: added API documentation 2009-03-01 20:08:48 +01:00
Max Kellermann
f48c58d17b crossfade: fix doxygen tag 2009-03-01 20:05:27 +01:00
Max Kellermann
ba3a8474b6 flac: parse stream tags 
Parse the vorbis comments in libflac's metadata_callback and pass them
as tag struct to the decoder API.
 2009-03-01 14:07:23 +01:00
Max Kellermann
92db09fdf8 listen: return GError on "unix path too long" 
When the unix domain socket path is too long, don't abort with
g_error().
 2009-03-01 13:35:44 +01:00
Max Kellermann
f2664e329f listen: removed unused macro BINDERROR() 2009-03-01 13:34:44 +01:00
Max Kellermann
d399d4b63b output_init: removed getBlockParam() 
Use config_get_block_string() and manual GError handling instead.
 2009-03-01 13:32:42 +01:00
Max Kellermann
f298fcf3a6 output_init: return GError on error 
Do error handling with GError instead of aborting with g_error().
 2009-03-01 13:31:56 +01:00
Max Kellermann
cb942eeb45 output_init: moved code to audio_output_detect() 2009-03-01 13:31:32 +01:00
Max Kellermann
af66f666c6 audiofile: added 24 bit support 
Don't hard code the "bits" parameter to 16.  Try to use the input's
sample format, if possible.
 2009-03-01 10:53:46 +01:00
Max Kellermann
614fe8b341 output: removed duplicate debug messages from plugins 
The MPD core logs the audio format of all audio outputs.  Remove the
duplicate message from the plugins.
 2009-03-01 10:39:42 +01:00
Max Kellermann
e1b79479a5 output_thread: log audio format in a debug message 
To aid debugging, print the audio format of the output plugin in a
debug message, and print information about PCM conversion.
 2009-03-01 10:37:26 +01:00
Max Kellermann
a81a84eaa4 decoder_api: log audio format in a debug message 
To aid debugging, print the audio format of the decoder plugin in a
debug message, and print information about PCM conversion.
 2009-03-01 10:31:47 +01:00
Max Kellermann
c0e61687b6 listen: fix windows specific code 
During the listen_add_host() API transition, the windows code wasn't
tested, and several removed arguments are still in use there.
 2009-03-01 01:49:49 +01:00
Max Kellermann
8c3df4cc83 socket_util: include ws2tcpip.h for getnameinfo() 
Windows doesn't have the standard headers sys/socket.h and netdb.h.
 2009-03-01 01:35:54 +01:00
Max Kellermann
eb64f6542f daemon: disable daemonize_detach() on WIN32 2009-03-01 01:35:53 +01:00
Max Kellermann
80571d1b5a tag: convert ignore_tag_items to a bool array 2009-03-01 00:58:32 +01:00
Max Kellermann
6153c86bc3 tag: added API documentation 2009-03-01 00:55:20 +01:00
Max Kellermann
b49518c636 tag: no CamelCase 
Renamed functions and variables.
 2009-03-01 00:52:02 +01:00
Max Kellermann
ae87abae59 use GLIB_CHECK_VERSION() 
Use GLIB_CHECK_VERSION() instead of manually checking
GLIB_MAJOR_VERSION, ...
 2009-03-01 00:37:22 +01:00
Max Kellermann
82b081a6db volume: throttle access to hardware mixers 
On some hardware, reading the mixer value from hardware is an
expensive operation, and MPD has to do it for every client.  Throttle
access to the hardware, cache the result for one second.
 2009-02-28 21:12:15 +01:00
Max Kellermann
ec4fd9fd88 output: use GTimer instead of time_t for reopen after failure 
time() is not a monotonic timer, and MPD might get confused by clock
skews.  clock_gettime() provides a monotonic clock, but is not
portable to non-POSIX systems (i.e. Windows).  This patch uses GLib's
GTimer API, which aims to be portable.
 2009-02-28 20:43:23 +01:00
Max Kellermann
a5c09c91c4 output: added option to disable audio outputs by default 
The option "enabled" is on by default.  If you specify "enabled no" in
an audio_output section, then this device is disabled by default.
 2009-02-28 19:40:39 +01:00
Max Kellermann
d29db0111c audiofile: removed duplicate decoder_get_command() calls 
decoder_data() returns a decoder_command, no need to call
decoder_get_command() twice after decoder_command().
 2009-02-28 19:28:38 +01:00
Max Kellermann
0813092c63 audiofile: refuse to play non-seekable files 
If an input_stream is not seekable, libaudiofile fails to play at all:

 Audio File Library: unrecognized audio file format [error 0]

Since we know in advance whether the input_stream is seekable, just
refuse to play on a non-seekable stream.
 2009-02-28 19:24:40 +01:00
Max Kellermann
44b55bff89 audiofile: no CamelCase 
Renamed several variables and a function.
 2009-02-28 19:09:54 +01:00
Max Kellermann
4a2b315ab6 tag: moved APE code to tag_ape.c 2009-02-28 16:44:41 +01:00
Michal Nazarewicz
cabbf7ab4a pipe: new audio output plugin which runs a command 
[mk: adapted to new output plugin API]
 2009-02-28 16:11:59 +01:00
Max Kellermann
5ea8a0df3f decoder_list: print decoder list with suffixes 
Print the list of suffixes supported by each decoder, instead of
prining a list of all suffixes of all decoders with duplicates.
 2009-02-28 15:29:51 +01:00
Max Kellermann
1bb0124b77 listen: allocate sockaddr_storage struct for accept() 
The generic sockaddr struct is too small for some addresses.  For
accept(), we have to allocate a sockaddr_storage struct on the stack,
which is large enough for all addresses.
 2009-02-28 15:20:35 +01:00
Max Kellermann
5c10d2ded7 client: use sockaddr_to_string() 
Removed the sockaddr_to_tmp_string() hack, use
the new function sockaddr_to_string() instead.
 2009-02-28 15:20:35 +01:00
Max Kellermann
e085deb944 socket_util: unpack V4MAPPED addresses 
Unpack IPv4 addresses which are packed inside an IPv6 address,
i.e. return "127.0.0.1" rather than "::ffff:127.0.0.1".
 2009-02-28 15:20:33 +01:00
Max Kellermann
b55d9fcdb8 socket_util: added function sockaddr_to_string() 
Create the socket_util.c library, the first function is
sockaddr_to_string(): it converts a sockaddr struct to a string
containing the IP address in a human-readable form.
 2009-02-28 15:12:24 +01:00
Max Kellermann
0fcb7dc65c update: use G_FILE_TEST_IS_REGULAR for archive files 
When checking whether database entries have been deleted, don't check
if an archive file is a directory (G_FILE_TEST_IS_DIR), use
G_FILE_TEST_IS_REGULAR for this case instead.  To determine if a
"struct directory" is an archive, check for device==DEVICE_INARCHIVE.
This is always false after loading the database, so this patch is not
complete yet.
 2009-02-28 14:02:08 +01:00
Max Kellermann
83b1b0ff69 update: don't update unchanged archive 
When the mtime of an archive time hasn't changed, don't update it
again.
 2009-02-28 14:02:03 +01:00
Max Kellermann
2aebbf8460 directory: added "mtime" property 
Remember the modification time of each directory.  This is important
for archives (which are virtual directories right now), but may also
be useful for an automatic update mechanism.
 2009-02-28 14:02:00 +01:00
Max Kellermann
3d6e6416e5 update: moved code to update_archive_file() 
Simplify the rather large function update_regular_file().
 2009-02-28 14:01:33 +01:00
Max Kellermann
7473fa0f4e directory: moved DIRECTORY_* string constants 
Moved some of them to to directory_save.c, and others to database.c.
 2009-02-27 19:30:16 +01:00
Max Kellermann
eae0287466 song_print: hide HTTP password in playlist 
Added the uri_remove_auth() library function which strips username
and password from a HTTP URI, and use it in song_print_url().  This
allows you to add HTTP URIs to the playlist including secret username
and password, without disclosing it to all MPD clients.
 2009-02-27 19:20:11 +01:00
Max Kellermann
9dd00dfab7 client: removed duplicate "client" string from log 
Since we introduced a GLib logging domain, the "client" string appears
twice in the log lines:

 client: client 0: command returned 0

Removed the second one, now it looks like this:

 client: [0] command returned 0

Still not quite good, but better than before.
 2009-02-27 19:03:13 +01:00
Max Kellermann
53271e8ae7 update: print error when opendir() fails 
MPD used to be silent when it could stat() a directory, but could not
opendir() it to read its contents.  This caused a lot of support
headache with users who have wrong file permissions.  Add another
warning message.
 2009-02-27 09:05:58 +01:00
Max Kellermann
497c0b1c18 tag: don't accept invalid UTF-8 sequences 
Overwrite invalid UTF-8 sequences with question marks.
 2009-02-27 09:02:32 +01:00
Max Kellermann
c1ab2d06aa tag: make tag.num_items unsigned 
There's no point in declaring num_items as a uint8_t, it doesn't save
any space, due to padding.  This allows us to lift the articial "255
items" limitation.
 2009-02-27 09:02:13 +01:00
Max Kellermann
75c2029b1c tag: no CamelCase 
Renamed numOfItems to num_items.
 2009-02-27 09:01:55 +01:00
Max Kellermann
5b07cbf0b4 tag: make tag_equal() return bool 2009-02-27 08:06:59 +01:00
Max Kellermann
bcdf947afc player_thread: removed meaningless warning on output failure 
The warning message "problems opening audio device while playing ..."
does not help at all, and should be removed.  At this point, the real
error message has already been logged by the output thread.
 2009-02-26 22:21:35 +01:00
Max Kellermann
9e61c0503e output_all: print a warning when all outputs are disabled 
When all outputs are disabled, MPD printed only a meaningless message
"problems opening audio device", although it didn't attempt to open a
device.
 2009-02-26 22:21:32 +01:00
Max Kellermann
58c201ce14 output_all: removed "audio_outputs!=NULL" check 
After initialization, audio_outputs is always non-NULL.  Don't check
that.
 2009-02-26 22:14:54 +01:00
Max Kellermann
dfea6b7cdd mvp: fixed default device detection 
The check "open()!=0" is wrong, you have to write "open()>=0", because
-1 means error, and 0 is a valid file handle.
 2009-02-26 22:10:58 +01:00
Max Kellermann
ec926539a3 output_plugin: report errors with GError 
Use GLib's GError library for reporting output device failures.

Note that some init() methods don't clean up properly after a failure,
but that's ok for now, because the MPD core will abort anyway.
 2009-02-26 22:04:59 +01:00
Max Kellermann
353ae5e558 osx: use OSStatus and GetMacOSStatusCommentString() 
The return type of most OS X functions is OSStatus, not int.  We can
get a nice error message from GetMacOSStatusCommentString(), log it.
 2009-02-26 22:01:42 +01:00
Max Kellermann
9dc966041d osx: start the audio device in the open() method 
Don't call AudioOutputUnitStart() in the play() method, do it after
the device has been opened.  We can eliminate the "started" property
now, because the device is always started when it's open.
 2009-02-26 21:40:22 +01:00
Max Kellermann
fb5ca6aa29 osx: removed commented code 
We don't need to keep commented code forever.  If we want that
test_default_device() implementation back one day, we'll pick it from
the git history.
 2009-02-26 21:33:13 +01:00
Max Kellermann
985ca094f2 osx: no CamelCase 
Renamed types, functions, variables.
 2009-02-26 21:03:06 +01:00
Max Kellermann
a7b0cfccb4 output_thread: use the right audio_format in assert() 
ao_play() gets PCM data in the in_audio_format, and converts it to
out_audio_format.  Comparing the input data with out_audio_format is
wrong.

prefixed with "STG:" will be automatically removed.  STG: Trailing
empty lines will be automatically removed.  STG: vi: set textwidth=75
filetype=diff nobackup:
 2009-02-26 21:02:39 +01:00
Max Kellermann
bcc3a9debf shout: use config_get_block_unsigned() 
Eliminated manual integer parsing.
 2009-02-26 19:34:00 +01:00
Max Kellermann
710a61a3dc pulse: removed pa_simple!=NULL checks 
The MPD core guarantees that the audio_output object is always
consistent, and our pa_simple!=NULL checks are superfluous.  Also
don't manually close the device on error in pulse_play(), since the
MPD core does this automatically when the play() method returns 0.
 2009-02-26 19:29:06 +01:00
Max Kellermann
4f2ac7ec2c oss: moved code from oss_open() to oss_setup() 
Eliminate one label and a bunch of gotos.
 2009-02-26 19:18:16 +01:00
Max Kellermann
749d6c7766 oss: convert OSS_STAT_* to an enum 
Use C instead of CPP.
 2009-02-26 19:18:13 +01:00
Max Kellermann
a0b3f35537 oss: return bool instead of int 
Return type of oss_find_supported_param(), oss_can_convert() and
oss_find_unsupported_param() should be bool instead of int.
 2009-02-26 19:17:56 +01:00
Max Kellermann
e1f58fdcf5 oss: use unsigned integers 
Convert the num_supported and num_unsupported variables from signed to
unsigned.
 2009-02-26 19:17:09 +01:00
Max Kellermann
4958a6f56f oss: no CamelCase 
Renamed types, functions and variables.
 2009-02-26 19:16:33 +01:00
Avuton Olrich
90ee488597 mixer: Add "disabled" mixer_type. 2009-02-26 09:13:07 -08:00
Avuton Olrich
1b79449ef1 cmdline: Alphabetical help order like other GNU projects. 2009-02-25 15:34:57 -08:00
Avuton Olrich
de07547426 cmdline: Add --no-config to explicitly set daemon default options. 2009-02-25 15:30:52 -08:00
Max Kellermann
a4cf7b7dfd alsa: fall back to 16 bit audio 
When the sample format is unknown, fall back to 16 bit samples.
 2009-02-25 22:01:32 +01:00
Max Kellermann
4c1fb8278b alsa: moved code from alsa_open() to alsa_setup() 
Simplify error handling a bit by moving some code into a separate
function.  This eliminates a good bunch of gotos, but that's not
finished yet.
 2009-02-25 22:01:30 +01:00
Max Kellermann
d3409a65b5 mvp: check for reopen errors 
When the MVP device has been closed in the cancel() method, and the
play() method attempts to reopen it, check for errors.
 2009-02-25 21:57:02 +01:00
Max Kellermann
883e31d55b mvp: moved code to mvp_find_sample_rate() 
Moved the table lookup code to a separate function.
 2009-02-25 21:56:48 +01:00
Max Kellermann
b4c65cac8c mvp: make the mvp_sample_rates array const 
The array must never be modified, it's a constant lookup table.
 2009-02-25 21:54:02 +01:00
Max Kellermann
99f535ad77 mvp: fall back to 16 bit audio samples 
Looks like the MVP audio output only supports 16 and 24 bit audio
samples.  If MPD generates any other sample formats, force it to use
16 bit.
 2009-02-25 21:52:11 +01:00
Max Kellermann
8491f61d6c mvp: fall back to stereo 
When the channel count is greater than 2, fall back to stereo sound.
 2009-02-25 21:51:39 +01:00
Max Kellermann
6722c508a1 mvp: mvp_set_pcm_params() returns bool 
Return true/false instead of 0/-1.  Also check its return value in
mvp_output_open().
 2009-02-25 21:51:36 +01:00
Max Kellermann
84ed6d4701 mvp: pass audio_format struct to mvp_set_pcm_params() 
Pass a pointer to the audio_format struct instead of 3 separate
integers.
 2009-02-25 21:51:32 +01:00
Max Kellermann
57a9e5605b mvp: removed big_endian parameter from mvp_set_pcm_params() 
Don't pass the big_endian flag to mvp_set_pcm_params(), do a simple
"G_BYTE_ORDER==G_LITTLE_ENDIAN" instead.
 2009-02-25 21:51:13 +01:00
Max Kellermann
d902465375 mvp: use G_N_ELEMENTS(mvp_sample_rates) 
Instead of manually calculating the number of elements in the
mvp_sample_rates array, use GLib's convenience macro G_N_ELEMENTS().
 2009-02-25 21:50:50 +01:00
Max Kellermann
fff52ac5b9 mvp: no CamelCase 
Renamed types, functions and variables.
 2009-02-25 21:49:59 +01:00
Max Kellermann
6aa6def776 output: audio_output_init() returns bool 
Return true/false instead of 1/0.
 2009-02-25 19:53:56 +01:00
Max Kellermann
9512704055 output: set a GLib log domain 2009-02-25 19:53:38 +01:00
Max Kellermann
d56ae1e9c2 fifo: return bool values 
Return true/false for success/failure instead of returning 0/-1.
 2009-02-25 19:53:27 +01:00
Max Kellermann
74af4e4c3d fifo: no CamelCase 
Renamed types, functions and variables.
 2009-02-25 19:53:24 +01:00
Max Kellermann
ee7cf9c9b8 fifo: removed timer!=NULL checks 
The MPD core guarantees that the audio_output object is always
consistent, and our timer!=NULL checks are superfluous.
 2009-02-25 19:09:38 +01:00
Max Kellermann
ba4dd651ef ao: no CamelCase 
Renamed functions and variables.
 2009-02-25 19:08:49 +01:00
Max Kellermann
074d5ae13e ao: removed AoData.device!=NULL checks 
The MPD core guarantees that the audio_output object is always in a
consistent state: either open or closed.  When open, it will not call
the open() method again, and when closed, it will not call play().
Removed several checks and the NULL initialization.
 2009-02-25 18:48:27 +01:00
Max Kellermann
8a882209c3 ao: removed implementation of method cancel() 
The method is empty, and we can simply set the method pointer to NULL
instead.
 2009-02-25 18:45:09 +01:00
Max Kellermann
dcd84c19cd output_plugin: don't pass audio_output object to method init() 
audio_output_get_name() has been removed, which was the only function
left in output_api.h.  The output plugin doesn't need the audio_output
object at all, remove the parameter from the init() method.
 2009-02-25 18:34:02 +01:00
Max Kellermann
0cf4f09e4f output_api: removed audio_output_get_name() 
Use config_get_block_string("name") instead of audio_output_get_name().
 2009-02-25 17:32:58 +01:00
Max Kellermann
6823217697 ls: moved generic URI utilities to uri.c 
"ls" is a bad name for a library which parses URIs.  We'll move the
rest of the "ls" library later.
 2009-02-25 16:44:06 +01:00
Max Kellermann
2054464c01 vorbis_encoder: vorbis_encoder_clear() returns void 
Don't return an uninitialized bool variable.
 2009-02-24 19:06:37 +01:00
Max Kellermann
e065c4db33 jack: initialize local variable "space" 
Fix a gcc warning, initialize the "space" variable at the beginning of
mpd_jack_play().
 2009-02-24 19:06:34 +01:00
Max Kellermann
1630fe00a2 listen: fix unused parameter warnings when TCP is disabled 
Work around gcc warnings by casting the parameters to void.
 2009-02-24 19:06:31 +01:00
Max Kellermann
d0a17ffb9d listen: removed is_ipv6_enabled() 
Don't explicitly check is_ipv6_enabled(), just try calling
listen_add_port_ipv6(), but check its error code.
 2009-02-24 18:55:12 +01:00
Max Kellermann
adf044eb09 listen: splitted listen_add_port() into IPv4 and IPv6 
Some more code simplification.
 2009-02-24 18:49:09 +01:00
Max Kellermann
d40c439424 listen: don't call listen_add_config_param(NULL) 
For default bind_to_address settings, don't call
listen_add_config_param(NULL), use listen_add_port() directly.
 2009-02-24 18:36:31 +01:00
Max Kellermann
739c23cca5 listen: moved code to listen_add_host() 
Split code from the rather large function listen_add_config_param(),
part 3.
 2009-02-24 18:29:53 +01:00
Max Kellermann
33749e7ea9 listen: moved code to listen_add_path() 
Split code from the rather large function listen_add_config_param(),
part 2.
 2009-02-24 17:51:39 +01:00
Max Kellermann
36b1a860d3 listen: moved code to listen_add_port() 
Split code from the rather large function listen_add_config_param().
 2009-02-24 17:51:32 +01:00
Max Kellermann
dbb067c016 listen: listen_add_address() returns bool/GError 
Don't return -1 on failure, and abort on fatal error - do proper error
reporting with GError, and return false on failure.
 2009-02-24 17:43:10 +01:00
Max Kellermann
7de4e7228f listen: removed unused macro "MAXHOSTNAME" 2009-02-24 17:42:37 +01:00
Max Kellermann
9bb3f2d060 listen: no CamelCase 
Renamed functions.
 2009-02-24 17:42:36 +01:00
Avuton Olrich
39a33344f2 ffmpeg: add all known ffmpeg extensions and mime-types. 
After much research[1][2][3] this should be the majority of currently
supported file extensions and mime-types for the currently supported
ffmpeg formats. This list maybe incomplete, but it's more complete
than anything else out there that I've been able to find. This list
needs to be updated every now and again as the ffmpeg sources support
more formats.

 1. Sources
 2. wiki.multimedia.cx
 3. filext.com
 2009-02-23 10:48:43 -08:00
Max Kellermann
3b1a9aeca0 Makefile.am: no recursive makefiles 
Recursive Makefiles are inefficient and error prone (no proper way to
declare dependencies).  Since there's no disadvantage in having one
single Makefile, let's do it.
 2009-02-23 10:04:51 +01:00
Max Kellermann
a4dfab2aee output: pass the music chunk pointer as void*, not char* 
The meaning of the chunk depends on the audio format; don't suggest a
specific format by declaring the pointer as "char*", pass "void*"
instead.
 2009-02-23 09:34:26 +01:00
Max Kellermann
5a898c15e7 output_api: play() returns a length 
The old API required an output plugin to not return until all data
passed to the play() method is consumed.  Some output plugins have to
loop to fulfill that requirement, and may block during that.  Simplify
these, by letting them consume only part of the buffer: make play()
return the length of the consumed data.
 2009-02-23 09:29:56 +01:00
Max Kellermann
d50a3d513e shout: removed shout_plugin.h 
There are no plugins left which require shout_plugin.h.  Moved the
struct declaration to shout_plugin.c.
 2009-02-22 17:52:37 +01:00
Max Kellermann
1c56edd1c8 shout: removed shout_encoder_plugins 
This array is empty, and is not used anymore.
 2009-02-22 17:51:12 +01:00
Max Kellermann
f6e5c00726 shout: use the new encoder API 
Removed shout's encoder plugin API in favor of the new generic encoder
plugin API.
 2009-02-22 17:18:28 +01:00
Max Kellermann
f7c685f1ab encoder: added lame mp3 encoder 
This new LAME encoder plugin is based on the existing shout_mp3.c
plugin.
 2009-02-22 17:18:03 +01:00
Max Kellermann
3a6619d62c encoder: added vorbis encoder 
This new vorbis encoder plugin is based on the existing shout_ogg.c
plugin.
 2009-02-22 17:17:26 +01:00
Max Kellermann
a9dde676be added the encoder API 
The new generic encoder API will replace shout's custom encoder API.
 2009-02-22 17:11:14 +01:00
Max Kellermann
e79a82ba3a shout: merged open_shout_conn() into my_shout_open_device() 
The method implementation my_shout_open_device() consists of only one
line, the call to open_shout_conn().  Merge both functions into one.
 2009-02-22 15:24:41 +01:00
Max Kellermann
cece6c00f4 shout: bool return values instead of int 
Return true/false instead of 0/-1.
 2009-02-22 15:18:58 +01:00
Max Kellermann
f0554d9a75 pcm: added API documentation 2009-02-21 18:14:20 +01:00
Max Kellermann
cae7c160a3 crossfade: added API documentation 2009-02-20 14:57:32 +01:00
Max Kellermann
91ebf46853 path: don't export path_set_fs_charset() 
The function path_set_fs_charset() is only used in path.c.
 2009-02-20 14:49:57 +01:00
Max Kellermann
09ecfb6567 path: validate configured character set 2009-02-20 12:31:00 +01:00
Max Kellermann
adea76a6ed decoder_api: fixed shadow warning, rename "wait" 
The parameter name "wait" overlaps with the POSIX wait() function.
Rename it.
 2009-02-19 13:33:06 +01:00
Max Kellermann
e7131b5da2 utils: use g_usleep() instead of my_usleep() 
Now that I've found this nice function in the GLib docs, we can
finally remove our custom sleep function.  Still all those callers of
g_usleep() have to be migrated one day to use events, instead of
regular polling.
 2009-02-19 13:33:03 +01:00
Max Kellermann
c228635489 faad: use faacDecFrameInfo instead of NeAACDecFrameInfo 
Don't use libfaad's internal type names.
 2009-02-19 13:29:15 +01:00
Max Kellermann
eac2da635d added G_LOG_DOMAIN macros to several libraries 
Define the GLib logging domain in the following libraries: conf,
daemon, event_pipe, log.
 2009-02-19 09:24:59 +01:00
Max Kellermann
11e680d640 conf: log the effective configuration file name 
For better debugging aid when something goes wrong, log the name of
the effective configuration file.
 2009-02-19 08:35:22 +01:00
Max Kellermann
0a0736fc4e log: added log_early_init() for early debug messages 2009-02-19 08:35:20 +01:00
Max Kellermann
84437acffb Makefile.am: add new headers to $(mpd_headers) 
I forgot to add these, and this broke "make distcheck".
 2009-02-19 08:12:46 +01:00
Peter Colberg
de6cc2691f mms: fix assertion in input_stream_open 
Hi,

upon trying to play an MMS stream added to the play list, I got this:

    mpd: /tmp/mpd/./src/input_stream.c:85: input_stream_open: Assertion `is->plugin->open == ((void *)0) || is->plugin == plugin' failed.

With the following patch applied, it works perfectly.

Thanks for having implemented MMS support :-).

Best regards,
Peter
 2009-02-19 07:34:07 +01:00
Max Kellermann
7f701744a7 pcm_volume: optimized pcm_volume_change_24() on i386 
Added an inline assembly function for the 64 bit multiplication.

Benchmark results on a Pentium II 266 MHz, 512 MB of 24 bit PCM data:

 dd if=/dev/zero bs=64k count=8k |
     time ./test/software_volume 48000:24:2 >/dev/null

Before this patch 22.94s, after this patch 7.24s.
 2009-02-18 22:27:58 +01:00
Max Kellermann
fcf65de46b mp4ff: always free the mp4ff_read_sample() buffer 
When mp4ff_read_sample() returns a value bigger than zero, it
guarantees that the buffer is set.  Remove the check.
 2009-02-18 19:08:52 +01:00
Max Kellermann
5900ea5299 mp4ff: don't allocate seek_table when input is not seekable 
Don't waste any precious memory when the seek_table cannot be used.
 2009-02-18 18:40:40 +01:00
Max Kellermann
8aa3edb6af mp4ff: include cleanup 
Don't include limits.h, use GLib constants instead.
 2009-02-18 18:40:33 +01:00
Max Kellermann
51c59f6228 mp4ff: use faacDecInit2() to find the AAC track 
Use faacDecInit2() instead of AudioSpecificConfig() to detect the AAC
track in the MP4 file.  This has a great advantage: it initializes the
libfaad decoder, which the caller would normally do anyway - but now
we can go without the AudioSpecificConfig() call.  When decoder==NULL
(called from mp4_tag_dup()), fall back to a mp4ff_get_track_type()==1
check, like other audio players do.
 2009-02-18 18:39:12 +01:00
Max Kellermann
111c73e701 mp4ff: moved code to mp4_faad_new() 
Moved the libfaad decoder initialization to mp4_faad_new(), and also
fill the audio_format struct there.  This eliminates a little bit of
complexity in mp4_decode().
 2009-02-18 18:38:09 +01:00
Max Kellermann
2bc0fabe73 mp4ff: call decoder_initialized() after libfaad initialization 
Don't wait for the first frame to be decoded.  We already have the
sample rate and the channel count from faacDecInit2().
 2009-02-18 18:18:29 +01:00
Max Kellermann
47e3eab872 mp4ff: merged mp4_load_tag() into mp4_tag_dup() 
The function mp4_load_tag() is used only once, and mp4_tag_dup() is a
one-liner.  Merge them.
 2009-02-18 18:18:25 +01:00
Max Kellermann
9d2f16d827 player_thread: don't drop audio buffers when not seekable 
When a file is not seekable, MPD dropped the audio buffers before even
attempting to seek.  This caused noticable sound corruption.  Fix:
first attempt to seek, and only if that succeeds, call
audio_output_all_cancel().
 2009-02-17 23:57:10 +01:00
Max Kellermann
4aca1fa493 faad: variable cleanup 
Make some variables more local, and eliminate superfluous ones.
 2009-02-17 23:44:29 +01:00
Max Kellermann
122e0f3338 faad: added source code comments 2009-02-17 23:42:06 +01:00
Max Kellermann
76b0601f6b faad: faad_decoder_init() returns an audio_format 
Instead of returning the sample rate and channel count as separate
values, fill an audio_format struct.
 2009-02-17 23:35:49 +01:00
Max Kellermann
161bfc4bc0 faad: call decoder_initialized() after libfaad initialization 
Don't wait for the first frame to be decoded.  We already have the
sample rate and the channel count from faacDecInit().
 2009-02-17 23:26:51 +01:00
Max Kellermann
a72c7a7b18 faad: removed DECODE_COMMAND_SEEK check 
The MPD core will never send a SEEK command to a decoder which has
declared to be not seekable.
 2009-02-17 23:20:16 +01:00
Max Kellermann
9245bd0c69 input_file, input_curl, icy_metadata: added GLib log domains 
Define G_LOG_DOMAIN.
 2009-02-17 22:58:27 +01:00
Max Kellermann
7b84f1e6b3 faad: use the decoder_buffer library 
Replace this plugin's own buffer library with the new decoder_buffer
library.
 2009-02-17 22:56:42 +01:00
Max Kellermann
7cea5357e3 faad: check the result of adts_find_frame() 
Instead of checking if the buffer is empty after adts_find_frame(),
check adts_find_frame()'s return value.  This is more robust.
 2009-02-17 22:56:07 +01:00
Max Kellermann
77db32f8fb faad: added libfaad wrappers 
Moved libfaad API quirks to the wrapper functions faad_decoder_init()
and faad_decoder_decode().
 2009-02-17 22:54:26 +01:00
Max Kellermann
6a72db22d7 faad: functions return duration, no float pointer 
Instead of writing the song duration into a float pointer, return it
from the function.
 2009-02-17 22:54:01 +01:00
Max Kellermann
e30ba2e4cf faad: removed length==NULL check in faad_song_duration() 
There are no callers which pass NULL here.
 2009-02-17 22:53:28 +01:00
Max Kellermann
867ae1cf6f faad: fill buffer in adts_find_frame() 
All callers of adts_find_frame() use faad_buffer_fill() before that.
Move that faad_buffer_fill() call into adts_find_frame() instead.
adts_find_frame() will get its own logic for on-demand filling.
 2009-02-17 22:53:25 +01:00
Max Kellermann
1a9756156e added the "decoder buffer" library 
The decoder buffer library may be used by decoder libraries such as
"faad".
 2009-02-17 22:39:45 +01:00
Max Kellermann
66b4a3ab2e faad: converted length check to assertion in adts_check_frame() 
adts_check_frame() must not be called with a buffer length smaller
than 8.  We can eliminate that duplicate check, and convert it into an
assertion.
 2009-02-17 19:28:11 +01:00
Max Kellermann
8edd407918 faad: added length check before comparing "ADIF" 
It's not valid to use the buffer's data without ensuring that the
buffer contains enough data.
 2009-02-17 19:27:36 +01:00
Max Kellermann
d75ce5c4a0 faad: renamed internal functions 
"aac" -> "faad"
 2009-02-17 19:27:01 +01:00
Max Kellermann
943b17c99a wavpack: added GLib log domain 2009-02-17 19:26:36 +01:00
Max Kellermann
656d5c9c7b pcm_convert: removed pcm_convert_size() 
The function is unused, since we added the pcm_buffer library.
 2009-02-17 19:26:32 +01:00
Max Kellermann
ac3e2de28b pcm_buffer: set size after allocation 
When I implemented the pcm_buffer library, I forgot to set the new
buffer size.  This caused a new allocation in each pcm_buffer_get(),
fortunately no memory was leaked.
 2009-02-17 18:27:00 +01:00
Max Kellermann
d8db46edfa decoders: added and fixed GLib log domains 
Fixed the log domains of the renamed decoders.  Added G_LOG_DOMAIN
macros in decoders which don't have one already.
 2009-02-17 08:51:34 +01:00
Max Kellermann
c4d69f0ae1 renamed decoder plugin "mpc" to "mpcdec" 
This plugin is based on "libmpcdec".
 2009-02-17 08:48:20 +01:00
Max Kellermann
70523657bf renamed decoder plugin "mp4" to "mp4ff" 
This plugin is based on "libmp4ff".
 2009-02-17 08:45:26 +01:00
Max Kellermann
f4ff7eab9d tag: fixed typo in MUSICBRAINZ_TRACKID tag name 2009-02-17 06:48:57 +01:00
Max Kellermann
68314c33e9 faad: no CamelCase 
Renamed functions and variables.
 2009-02-16 19:31:11 +01:00
Max Kellermann
8d2e6bf54c faad: removed AacBuffer.fileOffset 
The element fileOffset is only written, but never read.  It can be
removed safely.
 2009-02-16 19:31:08 +01:00
Max Kellermann
c6205bd461 renamed decoder plugin "oggvorbis" to "vorbis" 
This plugin uses libvorbis.
 2009-02-16 19:31:06 +01:00
Max Kellermann
cafaf33aa8 renamed decoder plugin "aac" to "faad" 
A decoder plugin should be named after the library which is used.
 2009-02-16 19:30:54 +01:00
Max Kellermann
c5edb53797 renamed decoder plugin "mp3" to "mad" 
A decoder plugin should be named after the library which is used.
 2009-02-16 19:30:45 +01:00
Max Kellermann
585f81ece1 output_api: don't include config.h 
If an output plugin requires config.h, it should include it directly.
 2009-02-16 18:41:30 +01:00
Max Kellermann
02c99d7716 mixer: include cleanup 
Don't include conf.h in mixer_api.h.  Use a forward struct declaration
instead.
 2009-02-16 18:40:04 +01:00
Max Kellermann
46c15e4ab3 output: include cleanup 
Don't include output_api.h in output_internal.h.  This change requires
adding missing includes in several sources.
 2009-02-16 01:51:50 +01:00
Max Kellermann
83ce0e5325 mixer_api: replaced method "control()" with "{get,set}_volume()" 
The method control() is too complicated, and overengineered.  Replace
it with two trivial functions: get_volume() and set_volume().
 2009-02-16 01:39:52 +01:00
Max Kellermann
37bc31d161 output_plugin: replaced method "control()" with "mixer()" 
The output plugin shouldn't know any specifics of the mixer API.  Make
it return the mixer object, and let the caller deal with it.
 2009-02-16 01:39:00 +01:00
Max Kellermann
79b50b7d9c output_plugin: added inline wrapper functions 
Similar to the decoder plugin API: added wrapper functions to increase
code readability.
 2009-02-16 01:38:10 +01:00
Max Kellermann
67da4cfe3c output_plugin: reorder method declarations 
Initialization and deinitialization first, then tag functions, then
play/cancel/pause.
 2009-02-16 01:38:09 +01:00
Max Kellermann
80702fa3a2 output_api: moved "struct audio_output_plugin" to output_plugin.h 
If we move the plugin struct to a separate header, we don't have to
include the big fat output_api.h everywhere.
 2009-02-16 01:37:42 +01:00
Max Kellermann
a5c0394007 output_api: moved "enum output_command" to output_internal.h 
Now that the output_command enum isn't exposed to output plugins
anymore, we can hide its definition within output_internal.h.
 2009-02-16 00:43:12 +01:00
Max Kellermann
3a82283b19 output_control: no CamelCase 
Renamed variables.
 2009-02-16 00:43:06 +01:00
Max Kellermann
ed591f19ef wildmidi: check if configurationn file exists 
Don't call WildMidi_Init() if the configuration file does not exist.
Don't let libwildmidi clutter stderr with its warning message.
 2009-02-15 18:41:05 +01:00
Max Kellermann
5c68f91dae wildmidi: obtain timidity.cfg location from mpd.conf 2009-02-15 18:41:03 +01:00
Max Kellermann
1f88cd73d4 decoder_list: added configuration option to disable decoder plugins 2009-02-15 18:40:47 +01:00
Max Kellermann
6cfacc778c decoder_list: added configuration block "decoder" 
The "decoder" configuration block may contain the configuration of one
decoder plugin.
 2009-02-15 18:35:19 +01:00
Max Kellermann
dec5d48f80 decoder_plugin: pass struct config_param to init() method 
Preparing for per-plugin configuration sections in mpd.conf.
 2009-02-15 18:34:14 +01:00
Max Kellermann
900784bb4e decoder_api: moved enum decoder_command to decoder_command.h 
Minimize header dependencies, again.
 2009-02-15 18:33:31 +01:00
Max Kellermann
3e3c524264 decoder_plugin: added inline wrapper functions 
Increase code readability, always use the wrapper functions instead of
calling the plugin method pointers directly.
 2009-02-15 18:33:28 +01:00
Max Kellermann
a28287073b decoder_api: moved struct decoder_plugin to decoder_plugin.h 
The decoder_plugin struct is used by both the MPD core and the decoder
plugin implementations.  Move it to a shared header file, to minimize
header dependencies.
 2009-02-15 17:48:37 +01:00
Max Kellermann
92c203d705 daemon: return early from daemonize_set_user() 
If no "user" is configured, return from daemonize_set_user().  Save
one level of indent.
 2009-02-15 16:58:52 +01:00
Max Kellermann
98994c5939 daemon: ignore "user" setting if already running as that user 
If mpd.conf specifies a user, and MPD is invoked by exactly this user,
ignore the "user" setting.  Don't bother to look up its groups and
don't attempt to change uid, it won't work anyway.
 2009-02-15 16:47:21 +01:00
Max Kellermann
59e62d95bd daemon: added comments to daemonize_detach() 2009-02-15 16:28:39 +01:00
Max Kellermann
42415592b4 daemon: print fork error message 
Print details on why the fork() fails.
 2009-02-15 16:27:50 +01:00
Max Kellermann
fd8c63b619 daemon: moved code to daemonize_detach() 
Moved the code which detaches from the parent process/session to a
separate function.
 2009-02-15 16:27:09 +01:00
Romain Bignon
855466df40 playlist_edit: improved range checks in shufflePlaylist() 2009-02-13 11:12:31 +01:00
Romain Bignon
9fe459f625 added the shufflerange command 
This command shuffles a range of songs.
 2009-02-13 10:43:30 +01:00
Max Kellermann
df9245c2aa update: free deleted subdirectories 
Use delete_directory() for removing sub directories instead of
dirvec_clear().  This ensures that all memory occupied by
subdirectories of deleted directories is freed.
 2009-02-12 19:12:32 +01:00