oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity
1,202 Commits 1 Branch 144 Tags 56 MiB
4cf5d04ca1
Commit Graph

42 Commits

Author SHA1 Message Date
Eric Wong
4cf5d04ca1 interface/connection malloc reductions from mpd-ke 
This patch massively reduces the amount of heap allocations at
the interface/command layer.  Most commands with minimal output
should not allocate memory from the heap at all.  Things like
repeatedly polling status, currentsong, and volume changes
should be faster as a result, and more importantly, not a source
of memory fragmentation.

These changes should be safe in that there's no way for a
remote-client to corrupt memory or otherwise do bad stuff to
MPD, but an extra set of eyes to review would be good.  Of
course there's never any warranty :)

No longer do we use FILE * structures in the interface, which means
we don't have to allocate any new memory for most connections.

Now, before you go on about losing the buffering that FILE *
+implies+, remember that myfprintf() never took advantage of
any of the stdio buffering features.

To reduce the diff and make bugs easier to spot in the diff,
I've kept myfprintf in places where we write to files (and not
network interfaces).  Expect myfprintf to go away entirely soon
(we'll use fprintf for writing regular files).

git-svn-id: https://svn.musicpd.org/mpd/trunk@4483 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-30 03:43:38 +00:00
Avuton Olrich
29a25b9933 Add mpd-indent.sh 
Indent the entire tree, hopefully we can keep
it indented.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4410 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-20 16:02:40 +00:00
J. Alexander Treuman
39615044e3 Will the leaks never end?! 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4375 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-16 19:55:01 +00:00
J. Alexander Treuman
fefd214b8e One more leak 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4373 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-16 19:20:40 +00:00
J. Alexander Treuman
5d1df8e25c Fixing a whopping 4 memory leaks 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4371 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-16 18:22:03 +00:00
J. Alexander Treuman
2fa7125cce Change shank's email address 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4333 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-14 19:37:45 +00:00
Avuton Olrich
d9f31b1c47 [CLEANUP] Remove 'extern int errno;' 
Remove unexported functions from the header
Static what makes sense

git-svn-id: https://svn.musicpd.org/mpd/trunk@4326 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-14 19:02:48 +00:00
Avuton Olrich
a37348a74f Huge header update, update the copyright and add 
the GPL header where necessary

git-svn-id: https://svn.musicpd.org/mpd/trunk@4317 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-13 19:20:34 +00:00
Eric Wong
6dadabea21 ls.c: remove unnecessary strdup 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3927 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-03-18 03:55:41 +00:00
Eric Wong
6963502213 merge with mpd/trunk up to r3925 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3926 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-03-16 06:52:46 +00:00
Eric Wong
402c8cd707 debug messages no longer cause segfaults :P 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3553 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-10-25 20:35:16 +00:00
Qball Cow
edcfbef90d Patch to make the configure flag for mpd-mad and mpd-libid3tag more logic (from ticho) 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3477 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-09-08 21:08:02 +00:00
Warren Dukes
d6a87f538d ok, now song->url is only the filename, not the full path to the song 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2602 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-11-11 02:59:16 +00:00
Warren Dukes
366e370cb0 patch from normalperson 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1679 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-26 17:33:42 +00:00
Warren Dukes
43afc87cc5 fix big boo boo in last commit: isFile() { myStat==0 } 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1599 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-21 14:32:13 +00:00
Warren Dukes
598162e395 todo update 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1597 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-21 04:11:23 +00:00
Warren Dukes
600091c3e0 slight bug fix for making sure url's obey the RFC's 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1470 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-13 20:58:22 +00:00
Warren Dukes
b4adc880a1 clean up some command.h include stuff 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1322 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-04 00:51:31 +00:00
Warren Dukes
a29e38bef5 a slight cleanup in isValidRemoteUrl() 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1310 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-03 00:24:33 +00:00
Warren Dukes
b48ac2dfa3 add urlhandlers command, but prolly not needed 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1307 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-02 23:22:37 +00:00
Warren Dukes
3c0c34bcb7 '\n' are bad 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1296 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-02 02:07:07 +00:00
Warren Dukes
efe8a04c70 validate url's before adding to playlist 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1289 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-02 01:26:15 +00:00
Warren Dukes
fd6aa25359 mp3 and ogg plugin stuff 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1245 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-31 01:21:17 +00:00
Warren Dukes
b65ec79c16 a small change in determining suffix of files 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1232 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-30 00:05:23 +00:00
Warren Dukes
45f8d47384 assume all streams are mp3's, we'll need to open the streams before calling 
the decoder routines to fetch the mime-type!

git-svn-id: https://svn.musicpd.org/mpd/trunk@1054 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-18 04:35:26 +00:00
Warren Dukes
746e7477e0 yes! rudimentary stream playing for mp3's! 
be gentle

git-svn-id: https://svn.musicpd.org/mpd/trunk@1051 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-18 03:37:55 +00:00
Warren Dukes
daa4ceb65a oops, fix an infinate loop 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1004 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-14 21:35:20 +00:00
Warren Dukes
965e6edcf1 redimentary addition of url's to playlist 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1000 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-13 18:46:38 +00:00
Warren Dukes
a7076a120b some cleanups of sprintf's => snprintf's 
git-svn-id: https://svn.musicpd.org/mpd/trunk@794 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-16 15:01:06 +00:00
Warren Dukes
2e420db19c remove directory mtime from db! 
also, only reReadDB and write DB on update if something was actually updated

git-svn-id: https://svn.musicpd.org/mpd/trunk@780 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-16 00:41:56 +00:00
Warren Dukes
549344d38a add vim shiznit to end of all source files 
git-svn-id: https://svn.musicpd.org/mpd/trunk@750 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-14 14:53:41 +00:00
Warren Dukes
1004890e25 lots of fsCharset, utf8/ascii converting clean-up and robustness stuff 
Also, if fsCharsetToUtf8 can't convert to valid UTF-8, then don't add
it to the db, this way clients don't have to worry about weirdness and it
will force ppl to convert it.

git-svn-id: https://svn.musicpd.org/mpd/trunk@711 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-13 04:59:57 +00:00
Warren Dukes
795a1e930b lets cleanup some file type detection and not call stat() so much 
git-svn-id: https://svn.musicpd.org/mpd/trunk@575 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-31 22:32:44 +00:00
Warren Dukes
fc84fa54fc fix some gcc-2.95 errors 
git-svn-id: https://svn.musicpd.org/mpd/trunk@414 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-23 03:02:49 +00:00
Warren Dukes
89d096fbef some simple compilation fix 
git-svn-id: https://svn.musicpd.org/mpd/trunk@341 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-21 12:46:13 +00:00
Warren Dukes
445d807b9c streamline ls.c code 
remove dontUpSampleSBR, not in faad2 rc3

git-svn-id: https://svn.musicpd.org/mpd/trunk@330 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-21 03:45:58 +00:00
Warren Dukes
91450723b2 bunch of autotool cleanups 
git-svn-id: https://svn.musicpd.org/mpd/trunk@271 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-18 03:29:25 +00:00
Warren Dukes
9a7636f5bc have AAC and MP4 types 
git-svn-id: https://svn.musicpd.org/mpd/trunk@267 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-17 17:30:50 +00:00
Warren Dukes
f114fbd437 fix a few snafoo's in configure.ac 
Add initial stuff for AAC support, now we just need to write the decoder

git-svn-id: https://svn.musicpd.org/mpd/trunk@264 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-17 03:10:17 +00:00
Warren Dukes
c69b615f2b fix it so that mpd will work if mtime is 0 (for those strange folk) 
git-svn-id: https://svn.musicpd.org/mpd/trunk@237 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-10 02:58:27 +00:00
Warren Dukes
8edc416344 some more cleanups 
git-svn-id: https://svn.musicpd.org/mpd/trunk@60 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-02-25 21:10:56 +00:00
Warren Dukes
d35747a40c import from SF CVS 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-02-23 23:41:20 +00:00