oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity
2,487 Commits 1 Branch 144 Tags 56 MiB
1d385190a0
Commit Graph

2056 Commits

Author SHA1 Message Date
Max Kellermann
1d385190a0 path: removed pathcpy_trunc() 
There was only one user of pathcpy_trunc(), which can be eliminated.
 2008-10-20 22:18:42 +02:00
Max Kellermann
49260e6db2 path: replaced parent_path() with g_path_get_dirname() 
Again, GLib's version is more robust than ours.
 2008-10-20 22:18:40 +02:00
Max Kellermann
ba96920a52 path: replaced mpd_basename() with g_path_get_basename() 
GLib's g_path_get_basename() is much more reliable than
mpd_basename().  The latter could be tricked into an assertion
failure.
 2008-10-20 22:18:12 +02:00
Max Kellermann
99e82a2ef2 signal_check.c: don't use leading underscores 
Identifiers with two leading underscores are reserved for the C
compiler's internal use.  Don't use them in the source.
 2008-10-20 22:18:03 +02:00
Max Kellermann
57f5e8731d mapper: don't return database path with leading slash 
Due to an off-by-one bug in map_fs_to_utf8(), the function returned
database paths with a leading slash.
 2008-10-19 00:05:39 +02:00
Andrzej Rybczak
52123c1de8 listen: fix "struct ucred" check 
The macro name is HAVE_STRUCT_UCRED, not HAVE_UCRED.
 2008-10-18 18:21:49 +02:00
Max Kellermann
98f7177f4a input_stream: don't declare method typedefs 
The typedefs aren't using by anybody but struct input_stream.  Remove
them and declare the method type within struct input_stream.
 2008-10-18 08:17:55 +02:00
Max Kellermann
1dfe92057e ffmpeg: make internal functions static 
The mpdurl_* code is internal, don't expose them.  Also don't
initialize struct members with NULL.
 2008-10-18 08:08:13 +02:00
Max Kellermann
02a2a407c1 client: converted permissions to unsigned 
client->permission is a bit set, and should be unsigned.
 2008-10-17 23:53:28 +02:00
Max Kellermann
f8d5b74071 client: eliminate variable "left" in client_write() 
Reduce two temporary variables to only one.
 2008-10-17 23:53:16 +02:00
Max Kellermann
bdbccc633d client: fixed send buffer 
There is no sense in using the kernel's send buffer size (SO_SNDBUF)
for MPD's send buffer.  Convert it into a static buffer of 4 kB.
 2008-10-17 23:52:47 +02:00
Max Kellermann
48c11c52ac client: removed CLIENT_MAX_BUFFER_LENGTH 
Use a literal in the struct declaration, and sizeof(client->buffer)
everywhere else.  Also shrink the buffer from 40 kB to 4 kB.  The
buffer must only be large enough to hold one line of input, and 4 kB
is still more than enough.
 2008-10-17 23:52:40 +02:00
Max Kellermann
3689d5e4ed client: added assertions on the buffer pointers 
The buffer pointers must not exceed the buffer size.
 2008-10-17 23:29:41 +02:00
Max Kellermann
d691577a96 client: read() return value is ssize_t 
Use ssize_t instead of int.
 2008-10-17 23:26:40 +02:00
Max Kellermann
79459d08d9 client: handle partial lines correctly 
Commit 6eb62e47 didn't obey partial lines correctly: when a line
wasn't finished in one read, the first part was ignored when the rest
arrived.
 2008-10-17 23:23:54 +02:00
Viliam Mateicka
11ad997141 ffmpeg: new decoder plugin 
[mk: fixed indent, changed copyright statement, added autoconf test,
fixed includes paths, fixed 2 gcc warnings, don't close input stream
twice]
 2008-10-17 22:27:33 +02:00
Max Kellermann
4ee8da2e69 Makefile.am: don't compile disabled decoder plugins 
Don't compile the sources of disabled decoder plugins at all, and
don't attempt to register these.
 2008-10-17 21:57:09 +02:00
Max Kellermann
25b5d90e44 Makefile.am: don't compile disabled sources 
If a feature is disabled, don't compile the source file at all,
disable it completely in Makefile.am instead.
 2008-10-17 21:13:23 +02:00
Max Kellermann
4984639b72 input_stream: removed nmemb argument 
The nmemb argument isn't actually useful, and one of nmemb and size
was always passed as 1.  Remove it.
 2008-10-17 17:53:59 +02:00
Max Kellermann
b73ecbb073 input: declare struct input_stream 
Provide a struct type which can be forward-declared.  The typedef
InputStream is deprecated now.
 2008-10-17 17:53:48 +02:00
Max Kellermann
bae98f777b decoder: notify player after entering decodeStart() 
Wake up the player as soon as the decoder thread has entered its loop.
This fixes a dead lock when the input is blocking.
 2008-10-17 17:53:44 +02:00
Max Kellermann
7ca19736c9 command: expect "file:///" url for local files 
When adding a local file, clients have to use the "file" URI schema
described in RFC 1738 3.10.  By adding this schema to "urlhandlers", a
client can detect whether this feature is available.
 2008-10-17 17:53:43 +02:00
Max Kellermann
f548216ead listen: fixed unused variable warning without HAVE_UCRED 
The local variable "passcred" was only used by ucred code.
 2008-10-17 17:40:28 +02:00
Max Kellermann
9b5ce27c3b configure.ac: check if "struct ucred" is available 
By default, glibc 2.8 hides struct ucred behind the _GNU_SOURCE
macro.  I don't want to enable that globally, because it may encourage
the use of non-portable functions.  Test if "struct ucred" is
available, and enable _GNU_SOURCE if required.

For details about that issue, see glib's bug database:

 http://sources.redhat.com/bugzilla/show_bug.cgi?id=6545
 2008-10-16 14:59:26 +02:00
Max Kellermann
b53365949a configure.ac: find more libraries with pkg-config 
Detect the following libraries with pkg-config: libshout, libid3tag,
libmad.
 2008-10-16 08:33:29 +02:00
Max Kellermann
beec15ddaa command: special case for "add /" 
The undocumented command "add /" adds the full music database to the
playlist.  Don't interpret this special path as a local file path.
 2008-10-16 07:40:34 +02:00
Max Kellermann
f9222fdabe playlist: also allow world-readable local files 
Allow a local user to not only add his own files, but also all
world-readable files (mode 0444).
 2008-10-15 23:10:05 +02:00
Max Kellermann
f1ab4d2c1b song: check file type in song_file_update() 
Don't load non-regular files.
 2008-10-15 22:43:24 +02:00
Max Kellermann
8c0060fae4 playlist: added support for adding songs not in the music database 
Clients which have authenticated via unix socket may add local files
to the MPD playlist, provided that they own the file.
 2008-10-15 22:35:13 +02:00
Max Kellermann
0b44cad2ce command: print error message on "addid" failure 
Returning the playlist_result value from a command handler does not
make sense.  Call print_playlist_result() there, and forward its
return value.
 2008-10-15 22:35:04 +02:00
Max Kellermann
961a349f15 playlist: moved code to song_by_url() 
Replace some complicated checks from addToPlaylist() to the simpler
function song_by_url().
 2008-10-15 22:35:00 +02:00
Max Kellermann
6d3488c8b3 song: added song_in_database() 
Some functions assume that a song is not in the database when it is a
remote song.  Based on that, they decide whether they are responsible
for freeing the song struct.  Add a special function which checks
whether a song is in the database (currently equal to song_is_file()).
 2008-10-15 22:34:47 +02:00
Max Kellermann
4a7ad5b618 listen, client: enable SO_PASSCRED, get client's uid 
Enable authentication over unix sockets.  Store the client's uid in
the client struct.
 2008-10-15 22:34:21 +02:00
Max Kellermann
fa56ff3d52 update: don't skip hidden files 
Skip only the special directory entries "." and "..", don't skip all
other "hidden" files.
 2008-10-15 20:51:01 +02:00
Max Kellermann
92513c3309 shout: check for vorbisenc library 
The switch from ogg.m4 to pkg-config intentionally disabled
libvorbisenc.  Enable it when shout_ogg is used.
 2008-10-15 20:40:04 +02:00
Enrico Weigelt
30cd345581 fixing several imports to work via pkg-config 
This patch fixes several imports to use pkg-config instead of certain
esoteric tests.
 2008-10-15 20:39:46 +02:00
Max Kellermann
047043d2a8 locate: use g_utf8_casefold() instead of string_toupper() 
string_toupper() and strDupToUpper() were not able to deal with
character sets other than US-ASCII.  Use GLib's g_utf8_casefold()
for strings.
 2008-10-15 19:36:37 +02:00
Max Kellermann
7366191f0d mapper: moved musicDir initialization from path.c 
Moved the musicDir variable and its initialization code from path.c to
mapper.c.
 2008-10-15 19:36:33 +02:00
Max Kellermann
76779f0fbe path: allow starting MPD with non-existing music directory 
When the music directory is not mounted yet, let MPD start anyway.
 2008-10-15 19:36:31 +02:00
Max Kellermann
8746a58ab9 path, tag_id3: use g_convert() instead of charConv.c 
GLib provides an easier API for character set conversion than iconv().
Use g_convert() / g_convert_with_fallback() for all character
conversions.  We should optimize the path.h API later to return a
newly allocated buffer, so we can just pass GLib's return value.
 2008-10-15 19:36:30 +02:00
Max Kellermann
e89599eaad use GLib 
GLib is a nice and portable utility library.  We are going to use it
from now on, and eliminate a lot of duplicated code from MPD.  Why
invent the wheel again and again?
 2008-10-15 19:35:04 +02:00
Max Kellermann
2a47e90cf5 tag_id3: fix indentation 
Indentation was broken in tag_id3.c: it used 4 spaces instead of tabs.
 2008-10-15 19:29:46 +02:00
Max Kellermann
cf7ed8c5df idle: client command "noidle" aborts idle 2008-10-15 18:21:57 +02:00
Max Kellermann
6eb62e4761 client: optimized client_input_received() 
Use memchr() instead of manually traversing the input buffer.  Update
the client's properties after all commands have been processed.  Check
for buffer overflow once.
 2008-10-15 18:21:45 +02:00
Max Kellermann
62ee702877 listen: pass protocol family to establishListen() 
The caller already knows the protocol family, and we can eliminate the
complicated switch statement in establishListen() if we just pass this
information.  This seems more robust.
 2008-10-15 07:30:24 +02:00
Max Kellermann
ba594cfec0 listen: use getaddrinfo() instead of gethostbyname() 
getaddrinfo() is more robust and has proper IPv6 support.  The new
code tries to bind to all IP addresses returned by getaddrinfo().
 2008-10-15 07:20:53 +02:00
Max Kellermann
a3e3d2c950 command: added command "idle" 
"idle" waits until something noteworthy happens on the server,
e.g. song change, playlist modified, database updated.  This allows
clients to keep up to date without polling.
 2008-10-14 22:38:14 +02:00
Max Kellermann
30c86d8ae6 alsa: added #ifdefs around SND_PCM_NO_AUTO_xxx 
These macros are not available in older libasound versions (1.0.13
fails, 1.0.16 is ok).  Ignore the configuration if the constants are
not defined.
 2008-10-14 22:37:27 +02:00
Max Kellermann
da1c0cd6d7 playlist: don't use uninitialized local variable (typo) 
Instead of the uninitialized local variable "s", I should have used
"uri".
 2008-10-14 17:23:24 +02:00
Max Kellermann
c4a43f8a9d oss: use unsigned integer for ioctl constants 
The OSS constants overflow a signed integer, use unsigned instead.
 2008-10-14 17:21:57 +02:00