oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity
15,307 Commits 1 Branch 144 Tags 56 MiB
Commit Graph

15307 Commits

Author SHA1 Message Date
Max Kellermann 33694642bd playlist/asx: add State::TAG 2020-03-12 20:42:16 +01:00
Max Kellermann c71242d743 playlist/asx: use tag_table to convert element name to TagType 2020-03-12 20:40:18 +01:00
Max Kellermann 2229e86673 client/Expire: cancel the BackgroundCommand before deleting it 
Fixes assertion failure.

Closes https://github.com/MusicPlayerDaemon/MPD/issues/774
 2020-03-12 20:32:08 +01:00
Max Kellermann f24c274f5c client/BackgroundCommand: fix typo in comment 2020-03-12 20:32:07 +01:00
Max Kellermann 3824bf66ca lib/chromaprint/DecoderClient: add assertion 2020-03-12 20:32:07 +01:00
Max Kellermann d942f874ae lib/chromaprint/DecoderClient: check `ready` in GetCommand() 
Fixes access to uninitialized memory (`remaining_bytes` isn't
initialized until Ready() is called) and fixes spurious
`getfingerprint` failures.
 2020-03-12 20:31:46 +01:00
Max Kellermann 01632d37ef Merge branch 'v0.21.x' 2020-03-12 08:11:08 +01:00
Max Kellermann c45f113856 playlist/xspf: concatenate multiple CharacterData fragments 
Closes https://github.com/MusicPlayerDaemon/MPD/issues/781
 2020-03-12 08:02:58 +01:00
Max Kellermann e0a8fd398c playlist/xspf: add State::TAG 2020-03-12 08:00:54 +01:00
Max Kellermann 3e97058151 playlist/xspf: move location.empty() check to _start_element() 2020-03-11 20:54:53 +01:00
Max Kellermann 51b1dd8672 playlist/xspf: use tag_table to convert element name to TagType 2020-03-11 20:51:47 +01:00
Max Kellermann 98a7d8da6c playlist/xspf: use C++11 initializer 2020-03-11 20:51:10 +01:00
Max Kellermann acb29f792f tag/Mask: fix yet another typo, this time in Unset() 
Similar to commits e8f2f98048 and
ff1ff1e54a

Closes https://github.com/MusicPlayerDaemon/MPD/issues/783
 2020-03-11 20:34:02 +01:00
Max Kellermann cd364023ae .travis.yml: rename "matrix" to "jobs" 
Travis has changed the canonical name for this a while ago.

(Now really.  The last commit for this was empty.)
 2020-03-07 09:31:46 +01:00
Max Kellermann 8d34a1cfc6 archive/iso9660: skip empty filenames 
Aparently, libcdio sometimes returns empty filenames, causing MPD
crashes.  This shouldn't really happen, and I consider this a libcdio
bug - but if it happens, people blame MPD, so let's add a check.

Closes https://github.com/MusicPlayerDaemon/MPD/issues/776
 2020-03-07 09:30:56 +01:00
Max Kellermann 73a1f078a6 archive/iso9660: use IsSpecialFilename() 2020-03-07 09:30:56 +01:00
Max Kellermann b7ce452308 fs/Traits: add IsSpecialFilename() 
Merge some duplicate code in a central library.
 2020-03-07 09:30:56 +01:00
Max Kellermann 5faf76051d .travis.yml: force updating homebrew on OSX 
Workaround for Travis failures as described in
 https://travis-ci.community/t/macos-build-fails-because-of-homebrew-bundle-unknown-command/7296/18
 2020-03-07 09:30:56 +01:00
Max Kellermann 5fe70a3417 .travis.yml: rename "matrix" to "jobs" 
Travis has changed the canonical name for this a while ago.
 2020-03-07 09:30:56 +01:00
Thomas Klausner 7a68b1e71f Adapt SolarisOutputPlugin.cxx to be usable on NetBSD. 2020-02-29 10:05:29 +01:00
Thomas Klausner d5468dfe89 Add missing header. 
Fixes
../src/time/ISO8601.cxx:67:24: error: use of undeclared identifier 'strtoul'
        unsigned long value = strtoul(s, &endptr, 10);
                              ^
../src/time/ISO8601.cxx:77:14: error: use of undeclared identifier 'strtoul'
                        minutes = strtoul(s, &endptr, 10);
                                  ^

on NetBSD with clang 9.0.0.
 2020-02-29 10:04:54 +01:00
John Regan 976372ff63 gme: check for empty metadata strings instead of nullptr 
Using libgme 0.6.2 on macOS, it appears that gme_info_t strings can be
empty, which creates weird track titles: (001/050)

This adds an additional check for an empty string.
 2020-02-25 20:12:08 +01:00
Max Kellermann c977d646c7 Merge remote-tracking branches 'neheb/j', 'neheb/f', 'neheb/qwe' and 'neheb/hgf' 2020-02-20 16:58:17 +01:00
Rosen Penev ac50bb5d2b [clang-tidy] remove needless std::move 
Found with performance-move-const-arg

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-02-20 16:47:34 +01:00
Max Kellermann 85e33f7d60 lib/dbus/Udisks2: make `path` non-const to allow moving from it 2020-02-20 16:47:32 +01:00
Max Kellermann 7646866a32 neighbor/smbclient: make iterators non-const to enable the std::move() 2020-02-20 16:47:32 +01:00
Max Kellermann d072b3cb17 storage/smbclient: remove misplaced .c_str() call 2020-02-20 16:47:32 +01:00
Max Kellermann 646fef108a storage/composite: make variable non-const to enable the std::move() 2020-02-20 16:41:38 +01:00
Max Kellermann d1cc73775f Instance: flush input cache on SIGHUP 2020-02-17 15:23:05 +01:00
Max Kellermann 29d05cdb8e unix/SignalHandlers: pass Instance to ...Init() 2020-02-17 15:23:03 +01:00
Max Kellermann 322d6f2a40 doc/user.rst: add section "Signals" 2020-02-17 15:22:45 +01:00
Max Kellermann 7729713924 doc/user.rst: add section "Starting MPD" 
Move the existing systemd sections over there.
 2020-02-17 12:21:05 +01:00
Rosen Penev 351a4a80d2
[clang-tidy] use using instead of typedef 
Found with modernize-use-using

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-02-16 19:22:32 -08:00
Rosen Penev 87f7b0f0bb
[clang-tidy] use emplace_back 
Found with hicpp-use-emplace

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-02-16 19:21:55 -08:00
Rosen Penev 6d3190fe5f
[clang-tidy] use = default 
Found with modernize-use-equals-default

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-02-16 17:10:18 -08:00
Rosen Penev 5d787806fe
[clang-tidy] add ending namespace comments 
Found with llvm-namespace-comment

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-02-16 16:44:37 -08:00
Max Kellermann 9abb686eeb increment version number to 0.21.21 2020-02-16 20:48:46 +01:00
Max Kellermann dea0cc165d input/cache/Manager: add method Flush() 2020-02-16 20:46:24 +01:00
Max Kellermann 07e0a31d02 release v0.21.20 
-----BEGIN PGP SIGNATURE-----
 
 iQJEBAABCgAuFiEEA5IzWngIOJSkMBxDI26KWMbbRRIFAl5Jm2cQHG1heEBtdXNp
 Y3BkLm9yZwAKCRAjbopYxttFEj3nEACkdgWh02NT0EGpmumCn4cB1mZ78ef0GyGm
 OOJi6qrnfuQdFX89UlL1+Nrx1U4Q6O6XvlIuuWTdKUjRQ+g5ktWuN48uEIKJ38If
 5ZbAqEZOvrH2b2lHNX15v7OvwXeGYK28fBbAjKf7txOJtW86azZ3NTjn4bb2a77B
 cio+Rhj9+fXzx/nBxHGVhLY3OQWQySFTm2Nbaz6zQoQYgm2xZ0htHNsGYKV6nl8I
 2Xt5zPEIlbjqdK9moSL1qyCevLZc7ME1Ha1v45pLwrXeCKlqhr5+6xFe2BEc1+DZ
 NHVmVs4e0GqSnyNTEd8eHXn70lpJ5ZSfrrk/HIHkx0Jk2hoGmAasHIUQViYxBiMN
 LqET7vM9nslrvuHl1Dd7wE66rrkGW6ILYKB7w48Jw00W5BjBtgcEVSj3PoKwchdh
 m4+JNZFJvubrXFKWjuXfRtY3MXsDKfy7lMd0iXDAxjh0YJuC8VGpGwRLL4V2uEzs
 tr2UvWIpjlw96kvvjTDnJp5kjA7D77xomxNkCHmj2/LOsA/bd4ljoCcmX033DBRr
 b7ddcESVcqTYXtMnYSWxmcHqizGjwIAVr7SsRgNbzZzs0/DVNpFAb/tGz3K9DzzF
 vdpm3y5KqdGyVoMAsIZDsxannmxcpivI6iOITAQH5aIRSLN/8ZGzCZ6ucS2GTjwq
 TZUR7iOjVQ==
 =ejSV
 -----END PGP SIGNATURE-----

Merge tag 'v0.21.20'

release v0.21.20
 2020-02-16 20:46:13 +01:00
Max Kellermann f24bcc7f42 release v0.21.20 2020-02-16 20:43:35 +01:00
Max Kellermann 89800324cb .travis.yml: use GTest 1.8.0 instead of HEAD 
Fixes strange C++11 compatibility problems during GTest installation:

 /tmp/gtest-20200216-20679-mu1044/googletest/include/gtest/internal/gtest-internal.h:1249:1: error: unknown type name 'constexpr'
 constexpr bool TypedTestCaseIsDeprecated() { return true; }

 /tmp/gtest-20200216-20679-mu1044/googletest/include/gtest/internal/gtest-internal.h:1249:11: error: expected unqualified-id
 constexpr bool TypedTestCaseIsDeprecated() { return true; }

 /tmp/gtest-20200216-20679-mu1044/googletest/include/gtest/internal/gtest-internal.h:1254:1: error: unknown type name 'constexpr'
 constexpr bool RegisterTypedTestCase_P_IsDeprecated() { return true; }
 2020-02-16 20:33:15 +01:00
Rosen Penev 050e30418c Fix travis 
pip is bugged on arm64 and s390x. Add --no-cache-dir to fix. For
consistency, it doesn't hurt to add everywhere.
 2020-02-16 19:29:30 +01:00
Max Kellermann 36a678276b storage/composite: no "=default" in constructor 
Closes https://github.com/MusicPlayerDaemon/MPD/pull/739 (essentially
the same, but with a proper explanation)
 2020-02-16 19:07:08 +01:00
Max Kellermann d4a6d647a0 Merge branch 'efuhgeh' of git://github.com/neheb/MPD 2020-02-16 19:03:35 +01:00
Max Kellermann 5397d18ed9 protocol/ArgParser: cast seek offset to SignedSongTime 
"The issue is that ParseCommandArgSignedSongTime parses with
SongTime::FromS, not SignedSongTime::FromS, before casting back to a
SignedSongTime for the return. With x86 overflow rules this doesn't
matter, but on ARM the first cast turns negative values to zero."

Closes https://github.com/MusicPlayerDaemon/MPD/issues/757
 2020-02-10 09:18:37 +01:00
Max Kellermann 2d3b51665e util/BitReverse: generate table with constexpr function 
Get rid of the macro hell.
 2020-02-05 19:51:46 +01:00
Max Kellermann 7b03f55cb4 util/bit_reverse: convert to C++ 2020-02-05 19:49:18 +01:00
Max Kellermann b84444b680 archive/iso9660: rewrite the macro CEILING as function 2020-02-05 19:43:20 +01:00
Max Kellermann 1e421cbcb2 Merge remote-tracking branches 'neheb/patch-2', 'neheb/con', 'neheb/cons', 'neheb/guruhg', 'neheb/r12R3', 'neheb/fefgheh' and 'neheb/rhgerg3453' 2020-02-05 19:36:01 +01:00
Rosen Penev a4eed3e330
[clang-tidy] use forward instead of move 
Found with bugprone-move-forwarding-reference

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-02-04 18:31:00 -08:00