oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

lib/nfs/Cancellable: use boost::intrusive::list

Browse Source 
Reduce Remove() overhead because we don't have to walk the list to
find an iterator by reference.
This commit is contained in:
Max Kellermann
2014-09-28 19:18:48 +02:00
parent 3560dc4be6
commit fb4e6ac923
3 changed files with 18 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/nfs/Connection.cxx
View File

@@ -161,7 +161,7 @@ NfsConnection::Open(const char *path, int flags, NfsCallback &callback,
auto &c = callbacks.Add(callback, *this);
if (!c.Open(context, path, flags, error)) {
callbacks.RemoveLast();
callbacks.Remove(c);
return false;
}
@@ -176,7 +176,7 @@ NfsConnection::Stat(struct nfsfh *fh, NfsCallback &callback, Error &error)
auto &c = callbacks.Add(callback, *this);
if (!c.Stat(context, fh, error)) {
callbacks.RemoveLast();
callbacks.Remove(c);
return false;
}
@@ -192,7 +192,7 @@ NfsConnection::Read(struct nfsfh *fh, uint64_t offset, size_t size,
auto &c = callbacks.Add(callback, *this);
if (!c.Read(context, fh, offset, size, error)) {
callbacks.RemoveLast();
callbacks.Remove(c);
return false;
}