Instance: eliminate FinishShutdownUpdate(), move code to destructor

src/Instance.cxx

@@ -31,6 +31,7 @@
 #ifdef ENABLE_DATABASE
 #include "db/DatabaseError.hxx"
 #include "db/Interface.hxx"
+#include "db/update/Service.hxx"
 #include "storage/StorageInterface.hxx"
 
 #ifdef ENABLE_SQLITE
@@ -53,6 +54,8 @@ Instance::Instance()
 Instance::~Instance() noexcept
 {
 #ifdef ENABLE_DATABASE
+	delete update;
+
 	if (database != nullptr) {
 		database->Close();
 		delete database;

src/Instance.hxx

@@ -167,7 +167,6 @@ struct Instance final
 #endif
 
 	void BeginShutdownUpdate() noexcept;
-	void FinishShutdownUpdate() noexcept;
 
 #ifdef ENABLE_CURL
 	void LookupRemoteTag(const char *uri) noexcept;

src/Main.cxx

@@ -351,14 +351,6 @@ Instance::BeginShutdownUpdate() noexcept
 #endif
 }
 
-inline void
-Instance::FinishShutdownUpdate() noexcept
-{
-#ifdef ENABLE_DATABASE
-	delete update;
-#endif
-}
-
 inline void
 Instance::BeginShutdownPartitions() noexcept
 {
@@ -634,8 +626,6 @@ mpd_main_after_fork(const ConfigData &raw_config, const Config &config)
 	}
 #endif
 
-	instance->FinishShutdownUpdate();
-
 #ifdef ENABLE_SQLITE
 	sticker_global_finish();
 #endif