oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

[clang-tidy] use nodiscard

Browse Source 
Introduced in C++17. It replaces gcc's warn_unused_result.

Found with modernize-use-nodiscard.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev
2020-03-11 23:43:06 -07:00
parent 2229e86673
commit f00f8b002a
37 changed files with 58 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/db/plugins/ProxyDatabasePlugin.cxx
View File

@@ -61,7 +61,7 @@ public:
LibmpdclientError(enum mpd_error _code, const char *_msg)
:std::runtime_error(_msg), code(_code) {}
enum mpd_error GetCode() const {
[[nodiscard]] enum mpd_error GetCode() const {
return code;
}
};

8
src/db/plugins/upnp/UpnpDatabasePlugin.cxx
View File

@@ -95,12 +95,12 @@ public:
VisitSong visit_song,
VisitPlaylist visit_playlist) const override;
RecursiveMap<std::string> CollectUniqueTags(const DatabaseSelection &selection,
[[nodiscard]] RecursiveMap<std::string> CollectUniqueTags(const DatabaseSelection &selection,
ConstBuffer<TagType> tag_types) const override;
DatabaseStats GetStats(const DatabaseSelection &selection) const override;
[[nodiscard]] DatabaseStats GetStats(const DatabaseSelection &selection) const override;
std::chrono::system_clock::time_point GetUpdateStamp() const noexcept override {
[[nodiscard]] std::chrono::system_clock::time_point GetUpdateStamp() const noexcept override {
return std::chrono::system_clock::time_point::min();
}
@@ -139,7 +139,7 @@ private:
* except easier cause our inodes have a parent id. Not used
* any more actually (see comments in SearchSongs).
*/
std::string BuildPath(const ContentDirectoryService &server,
[[nodiscard]] std::string BuildPath(const ContentDirectoryService &server,
const UPnPDirObject& dirent) const;
};