oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

[clang-tidy] pass by value where appropriate

Browse Source 
Found with modernize-pass-by-value

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2020-01-31 19:59:48 -08:00
parent bc6eca2115
commit ecad6d936a
No known key found for this signature in database
GPG Key ID: 36D31CFA845F0E3B
4 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/archive/plugins/Bzip2ArchivePlugin.cxx
View File

@ -32,6 +32,7 @@
#include <bzlib.h> #include <bzlib.h>
#include <stdexcept> #include <stdexcept>
#include <utility>
class Bzip2ArchiveFile final : public ArchiveFile { class Bzip2ArchiveFile final : public ArchiveFile {
std::string name; std::string name;
@ -65,7 +66,7 @@ class Bzip2InputStream final : public InputStream {
char buffer[5000]; char buffer[5000];
public: public:
Bzip2InputStream(const std::shared_ptr<InputStream> &_input, Bzip2InputStream(std::shared_ptr<InputStream> _input,
const char *uri, const char *uri,
Mutex &mutex); Mutex &mutex);
~Bzip2InputStream() override; ~Bzip2InputStream() override;
@ -111,11 +112,11 @@ bz2_open(Path pathname)
/* single archive handling */ /* single archive handling */
Bzip2InputStream::Bzip2InputStream(const std::shared_ptr<InputStream> &_input, Bzip2InputStream::Bzip2InputStream(std::shared_ptr<InputStream> _input,
const char *_uri, const char *_uri,
Mutex &_mutex) Mutex &_mutex)
:InputStream(_uri, _mutex), :InputStream(_uri, _mutex),
input(_input) input(std::move(_input))
{ {
Open(); Open();
} }

6
src/archive/plugins/Iso9660ArchivePlugin.cxx
View File

@ -34,6 +34,8 @@
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <utility>
#define CEILING(x, y) ((x+(y-1))/y) #define CEILING(x, y) ((x+(y-1))/y)
struct Iso9660 { struct Iso9660 {
@ -141,12 +143,12 @@ class Iso9660InputStream final : public InputStream {
iso9660_stat_t *statbuf; iso9660_stat_t *statbuf;
public: public:
Iso9660InputStream(const std::shared_ptr<Iso9660> &_iso, Iso9660InputStream(std::shared_ptr<Iso9660> _iso,
const char *_uri, const char *_uri,
Mutex &_mutex, Mutex &_mutex,
iso9660_stat_t *_statbuf) iso9660_stat_t *_statbuf)
:InputStream(_uri, _mutex), :InputStream(_uri, _mutex),
iso(_iso), statbuf(_statbuf) { iso(std::move(_iso)), statbuf(_statbuf) {
size = statbuf->size; size = statbuf->size;
seekable = true; seekable = true;
SetReady(); SetReady();

5
src/db/VHelper.cxx
View File

@ -23,14 +23,15 @@
#include "song/Filter.hxx" #include "song/Filter.hxx"
#include <algorithm> #include <algorithm>
#include <utility>
#include <assert.h> #include <assert.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
DatabaseVisitorHelper::DatabaseVisitorHelper(const DatabaseSelection &_selection, DatabaseVisitorHelper::DatabaseVisitorHelper(DatabaseSelection _selection,
VisitSong &visit_song) noexcept VisitSong &visit_song) noexcept
:selection(_selection) :selection(std::move(_selection))
{ {
// TODO: apply URI and SongFilter // TODO: apply URI and SongFilter
assert(selection.uri.empty()); assert(selection.uri.empty());

2
src/db/VHelper.hxx
View File

@ -60,7 +60,7 @@ public:
* @param visit_song the callback function passed to * @param visit_song the callback function passed to
* Database::Visit(); may be replaced by this class * Database::Visit(); may be replaced by this class
*/ */
DatabaseVisitorHelper(const DatabaseSelection &selection, DatabaseVisitorHelper(DatabaseSelection selection,
VisitSong &visit_song) noexcept; VisitSong &visit_song) noexcept;
~DatabaseVisitorHelper() noexcept; ~DatabaseVisitorHelper() noexcept;