oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

don't repeat select()

Browse Source 
The interfaces main loop repeats the select() (non-blocking) after an
event was handled.  I do not see any reason for that, since all events
should be handled after the first select().  This double select() does
nothing than consume more CPU cycles.

git-svn-id: https://svn.musicpd.org/mpd/trunk@7213 09075e82-0dd4-0310-85a5-a0d7c8717e4f
This commit is contained in:
Max Kellermann 2008-03-26 10:38:44 +00:00 committed by Eric Wong
parent f9e317ccbd
commit e4779fa752
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/interface.c
View File

@ -478,7 +478,6 @@ int doIOForInterfaces(void)
fd_set rfds; fd_set rfds;
fd_set wfds; fd_set wfds;
fd_set efds; fd_set efds;
struct timeval tv, *tvp = NULL;
int i; int i;
int selret; int selret;
int fdmax; int fdmax;
@ -492,7 +491,7 @@ int doIOForInterfaces(void)
registered_IO_add_fds(&fdmax, &rfds, &wfds, &efds); registered_IO_add_fds(&fdmax, &rfds, &wfds, &efds);
selret = select(fdmax + 1, &rfds, &wfds, &efds, tvp); selret = select(fdmax + 1, &rfds, &wfds, &efds, NULL);
if (selret < 0 && errno == EINTR) if (selret < 0 && errno == EINTR)
break; break;
@ -525,9 +524,7 @@ int doIOForInterfaces(void)
} }
} }
tv.tv_sec = 0; break;
tv.tv_usec = 0;
tvp = &tv;
} }
return 1; return 1;