oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

daemon: no initgroups() when already running as the configured user 

We can assume that initgroups() would be a no-op in that case, however
initgroups() is not allowed for unprivileged users anyway.
This commit is contained in:
Max Kellermann 2013-12-29 13:58:39 +01:00
parent 09a0803116
commit e30b356eb0
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS
View File

@ -1,4 +1,6 @@
ver 0.18.7 (not yet released) ver 0.18.7 (not yet released)
* daemon: don't initialize supplementary groups when already running
as the configured user
ver 0.18.6 (2013/12/24) ver 0.18.6 (2013/12/24)
* input * input

6
src/Daemon.cxx
View File

@ -116,7 +116,11 @@ daemonize_set_user(void)
/* init supplementary groups /* init supplementary groups
* (must be done before we change our uid) * (must be done before we change our uid)
*/ */
if (!had_group && initgroups(user_name, user_gid) == -1) { if (!had_group &&
/* no need to set the new user's supplementary groups if
we are already this user */
user_uid != getuid() &&
initgroups(user_name, user_gid) == -1) {
FormatFatalSystemError("Failed to set supplementary groups " FormatFatalSystemError("Failed to set supplementary groups "
"of user \"%s\"", "of user \"%s\"",
user_name); user_name);