oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

decoder/mikmod: fix memory leak

Browse Source 
The return value of Player_LoadTitle() is allocated with malloc(), and
must be freed by the caller.
This commit is contained in:
Max Kellermann 2010-05-31 10:24:08 +02:00
parent 2c1c588868
commit de8f2739c2
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@ -39,6 +39,7 @@ ver 0.16 (20??/??/??)
- wavpack: allow more than 2 channels - wavpack: allow more than 2 channels
- mp4ff: rename plugin "mp4" to "mp4ff" - mp4ff: rename plugin "mp4" to "mp4ff"
- mp4ff: support tags "albumartist", "band" - mp4ff: support tags "albumartist", "band"
- mikmod: fix memory leak
* encoders: * encoders:
- twolame: new encoder plugin based on libtwolame - twolame: new encoder plugin based on libtwolame
- flac: new encoder plugin based on libFLAC - flac: new encoder plugin based on libFLAC

6
src/decoder/mikmod_decoder_plugin.c
View File

@ -195,11 +195,13 @@ mikmod_decoder_tag_dup(const char *path_fs)
tag->time = 0; tag->time = 0;
char *title = g_strdup(Player_LoadTitle(path2)); char *title = Player_LoadTitle(path2);
g_free(path2); g_free(path2);
if (title) if (title != NULL) {
tag_add_item(tag, TAG_TITLE, title); tag_add_item(tag, TAG_TITLE, title);
free(title);
}
return tag; return tag;
} }