output_init: put the "convert" filter at the end of the list
No, really!  This fixes a regression of commit 74617389, which
changed the order of filter plugins.
			
			
This commit is contained in:
		
							
								
								
									
										2
									
								
								NEWS
									
									
									
									
									
								
							
							
						
						
									
										2
									
								
								NEWS
									
									
									
									
									
								
							@@ -1,6 +1,8 @@
 | 
				
			|||||||
ver 0.17.1 (2012/??/??)
 | 
					ver 0.17.1 (2012/??/??)
 | 
				
			||||||
* protocol:
 | 
					* protocol:
 | 
				
			||||||
  - require appropriate permissions for searchadd{,pl}
 | 
					  - require appropriate permissions for searchadd{,pl}
 | 
				
			||||||
 | 
					* output:
 | 
				
			||||||
 | 
					  - fix noisy playback with conversion and software volume
 | 
				
			||||||
 | 
					
 | 
				
			||||||
ver 0.17 (2012/06/27)
 | 
					ver 0.17 (2012/06/27)
 | 
				
			||||||
* protocol:
 | 
					* protocol:
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -213,13 +213,6 @@ ao_base_init(struct audio_output *ao,
 | 
				
			|||||||
	ao->replay_gain_filter = NULL;
 | 
						ao->replay_gain_filter = NULL;
 | 
				
			||||||
	ao->other_replay_gain_filter = NULL;
 | 
						ao->other_replay_gain_filter = NULL;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	/* the "convert" filter must be the last one in the chain */
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
	ao->convert_filter = filter_new(&convert_filter_plugin, NULL, NULL);
 | 
					 | 
				
			||||||
	assert(ao->convert_filter != NULL);
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
	filter_chain_append(ao->filter, ao->convert_filter);
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
	/* done */
 | 
						/* done */
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	return true;
 | 
						return true;
 | 
				
			||||||
@@ -280,6 +273,13 @@ audio_output_setup(struct audio_output *ao, const struct config_param *param,
 | 
				
			|||||||
		return false;
 | 
							return false;
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
						/* the "convert" filter must be the last one in the chain */
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
						ao->convert_filter = filter_new(&convert_filter_plugin, NULL, NULL);
 | 
				
			||||||
 | 
						assert(ao->convert_filter != NULL);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
						filter_chain_append(ao->filter, ao->convert_filter);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	return true;
 | 
						return true;
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user