util/SplitString: convert return value to std::string_view

Eliminates lots of overhead.
This commit is contained in:
Max Kellermann
2020-04-03 16:42:49 +02:00
parent 2c02a04566
commit db93bb996c
8 changed files with 27 additions and 32 deletions
+4 -7
View File
@@ -25,6 +25,7 @@
#include "util/ASCII.hxx"
#include "util/RuntimeError.hxx"
#include "util/SplitString.hxx"
#include "util/StringView.hxx"
void
TagLoadConfig(const ConfigData &config)
@@ -44,15 +45,11 @@ TagLoadConfig(const ConfigData &config)
/* no "+-": not incremental */
global_tag_mask = TagMask::None();
for (const auto &i : SplitString(value, ',')) {
const char *name = i.c_str();
if (*name == '+') {
for (StringView name : SplitString(value, ',')) {
if (name.SkipPrefix("+")) {
plus = true;
++name;
} else if (*name == '-') {
} else if (name.SkipPrefix("-")) {
plus = false;
++name;
}
const auto type = tag_name_parse_i(name);