oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

input/curl: move the range buffer to the stack

Browse Source 
From the CURLOPT_RANGE documentation: "The application does not have
to keep the string around after setting this option."
This commit is contained in:
Max Kellermann 2017-10-24 21:38:35 +02:00
parent 338e1f5926
commit d8e4705dd4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/input/plugins/CurlInputPlugin.cxx
View File

@ -64,7 +64,6 @@ static const size_t CURL_RESUME_AT = 384 * 1024;
struct CurlInputStream final : public AsyncInputStream, CurlResponseHandler { struct CurlInputStream final : public AsyncInputStream, CurlResponseHandler {
/* some buffers which were passed to libcurl, which we have /* some buffers which were passed to libcurl, which we have
too free */ too free */
char range[32];
CurlSlist request_headers; CurlSlist request_headers;
CurlRequest *request = nullptr; CurlRequest *request = nullptr;
@ -398,6 +397,7 @@ CurlInputStream::SeekInternal(offset_type new_offset)
/* send the "Range" header */ /* send the "Range" header */
if (offset > 0) { if (offset > 0) {
char range[32];
#ifdef WIN32 #ifdef WIN32
// TODO: what can we use on Windows to format 64 bit? // TODO: what can we use on Windows to format 64 bit?
sprintf(range, "%lu-", (long)offset); sprintf(range, "%lu-", (long)offset);