oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

pcm/Normalizer: no in-place editing, separate src/dest parameters

Browse Source 
This eliminates the memcpy() call from NormalizeFilter::FilterPCM().
This commit is contained in:
Max Kellermann
2023-03-13 13:17:43 +01:00
parent 8ea9b89321
commit d7f2d90fd3
4 changed files with 18 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/filter/plugins/NormalizeFilterPlugin.cxx
View File

@@ -8,8 +8,7 @@
#include "pcm/Buffer.hxx"
#include "pcm/AudioFormat.hxx"
#include "pcm/Normalizer.hxx"
#include <string.h>
#include "util/SpanCast.hxx"
class NormalizeFilter final : public Filter {
PcmNormalizer normalizer;
@@ -49,13 +48,13 @@ PreparedNormalizeFilter::Open(AudioFormat &audio_format)
}
std::span<const std::byte>
NormalizeFilter::FilterPCM(std::span<const std::byte> src)
NormalizeFilter::FilterPCM(std::span<const std::byte> _src)
{
auto *dest = (int16_t *)buffer.Get(src.size());
memcpy(dest, src.data(), src.size());
const auto src = FromBytesStrict<const int16_t>(_src);
auto *dest = (int16_t *)buffer.GetT<int16_t>(src.size());
normalizer.ProcessS16({dest, src.size() / 2});
return { (const std::byte *)dest, src.size() };
normalizer.ProcessS16(dest, src);
return std::as_bytes(std::span{dest, src.size()});
}
const FilterPlugin normalize_filter_plugin = {