oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

input/rewind, archive/iso9660: use use std::cmp_*() for safe integer comparison

Browse Source
This commit is contained in:
Max Kellermann 2024-03-11 15:09:56 +01:00
parent b0cfdfa257
commit d685d693e8
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/archive/plugins/Iso9660ArchivePlugin.cxx
View File

@ -242,7 +242,7 @@ Iso9660InputStream::Read(std::unique_lock<Mutex> &,
if (remaining == 0) if (remaining == 0)
return 0; return 0;
if (offset_type(read_size) > remaining) if (std::cmp_greater(read_size, remaining))
read_size = remaining; read_size = remaining;
auto r = buffer.Read(); auto r = buffer.Read();

2
src/input/RewindInputStream.cxx
View File

@ -105,7 +105,7 @@ RewindInputStream::Seek(std::unique_lock<Mutex> &lock, offset_type new_offset)
{ {
assert(IsReady()); assert(IsReady());
if (tail > 0 && new_offset <= (offset_type)tail) { if (tail > 0 && std::cmp_less_equal(new_offset, tail)) {
/* buffered seek */ /* buffered seek */
assert(!ReadingFromBuffer() || assert(!ReadingFromBuffer() ||