oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

mp4ff_decoder: use g_ascii_strcasecmp() instead of strcasecmp()

Browse Source 
strcasecmp() is locale dependent, making it a bad choice for internal
string comparisons.
This commit is contained in:
Max Kellermann 2009-04-28 09:29:11 +02:00
parent 9038882d95
commit d5b3dd36fd
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/decoder/mp4ff_plugin.c
View File

@ -394,21 +394,22 @@ mp4_tag_dup(const char *file)
mp4ff_meta_get_by_index(mp4fh, i, &item, &value); mp4ff_meta_get_by_index(mp4fh, i, &item, &value);
if (0 == strcasecmp("artist", item)) { if (0 == g_ascii_strcasecmp("artist", item)) {
tag_add_item(ret, TAG_ITEM_ARTIST, value); tag_add_item(ret, TAG_ITEM_ARTIST, value);
} else if (0 == strcasecmp("title", item)) { } else if (0 == g_ascii_strcasecmp("title", item)) {
tag_add_item(ret, TAG_ITEM_TITLE, value); tag_add_item(ret, TAG_ITEM_TITLE, value);
} else if (0 == strcasecmp("album", item)) { } else if (0 == g_ascii_strcasecmp("album", item)) {
tag_add_item(ret, TAG_ITEM_ALBUM, value); tag_add_item(ret, TAG_ITEM_ALBUM, value);
} else if (0 == strcasecmp("track", item)) { } else if (0 == g_ascii_strcasecmp("track", item)) {
tag_add_item(ret, TAG_ITEM_TRACK, value); tag_add_item(ret, TAG_ITEM_TRACK, value);
} else if (0 == strcasecmp("disc", item)) { /* Is that the correct id? */ } else if (0 == g_ascii_strcasecmp("disc", item)) {
/* Is that the correct id? */
tag_add_item(ret, TAG_ITEM_DISC, value); tag_add_item(ret, TAG_ITEM_DISC, value);
} else if (0 == strcasecmp("genre", item)) { } else if (0 == g_ascii_strcasecmp("genre", item)) {
tag_add_item(ret, TAG_ITEM_GENRE, value); tag_add_item(ret, TAG_ITEM_GENRE, value);
} else if (0 == strcasecmp("date", item)) { } else if (0 == g_ascii_strcasecmp("date", item)) {
tag_add_item(ret, TAG_ITEM_DATE, value); tag_add_item(ret, TAG_ITEM_DATE, value);
} else if (0 == strcasecmp("writer", item)) { } else if (0 == g_ascii_strcasecmp("writer", item)) {
tag_add_item(ret, TAG_ITEM_COMPOSER, value); tag_add_item(ret, TAG_ITEM_COMPOSER, value);
} }