oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

fifo: return bool values

Browse Source 
Return true/false for success/failure instead of returning 0/-1.
This commit is contained in:
Max Kellermann 2009-02-25 19:53:27 +01:00
parent 74af4e4c3d
commit d56ae1e9c2
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/output/fifo_plugin.c
View File

@ -38,7 +38,7 @@ struct fifo_data {
char *path; char *path;
int input; int input;
int output; int output;
int created; bool created;
Timer *timer; Timer *timer;
}; };
@ -51,7 +51,7 @@ static struct fifo_data *fifo_data_new(void)
ret->path = NULL; ret->path = NULL;
ret->input = -1; ret->input = -1;
ret->output = -1; ret->output = -1;
ret->created = 0; ret->created = false;
return ret; return ret;
} }
@ -72,7 +72,7 @@ static void fifo_delete(struct fifo_data *fd)
return; return;
} }
fd->created = 0; fd->created = false;
} }
static void static void
@ -94,21 +94,21 @@ fifo_close(struct fifo_data *fd)
fifo_delete(fd); fifo_delete(fd);
} }
static int static bool
fifo_make(struct fifo_data *fd) fifo_make(struct fifo_data *fd)
{ {
if (mkfifo(fd->path, 0666) < 0) { if (mkfifo(fd->path, 0666) < 0) {
g_warning("Couldn't create FIFO \"%s\": %s", g_warning("Couldn't create FIFO \"%s\": %s",
fd->path, strerror(errno)); fd->path, strerror(errno));
return -1; return false;
} }
fd->created = 1; fd->created = true;
return 0; return true;
} }
static int static bool
fifo_check(struct fifo_data *fd) fifo_check(struct fifo_data *fd)
{ {
struct stat st; struct stat st;
@ -121,22 +121,22 @@ fifo_check(struct fifo_data *fd)
g_warning("Failed to stat FIFO \"%s\": %s", g_warning("Failed to stat FIFO \"%s\": %s",
fd->path, strerror(errno)); fd->path, strerror(errno));
return -1; return false;
} }
if (!S_ISFIFO(st.st_mode)) { if (!S_ISFIFO(st.st_mode)) {
g_warning("\"%s\" already exists, but is not a FIFO", g_warning("\"%s\" already exists, but is not a FIFO",
fd->path); fd->path);
return -1; return false;
} }
return 0; return true;
} }
static bool static bool
fifo_open(struct fifo_data *fd) fifo_open(struct fifo_data *fd)
{ {
if (fifo_check(fd) < 0) if (!fifo_check(fd))
return false; return false;
fd->input = open(fd->path, O_RDONLY|O_NONBLOCK); fd->input = open(fd->path, O_RDONLY|O_NONBLOCK);