oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

playlist: fix FILE* leak in appendSongToStoredPlaylistByPath()

Browse Source 
When an error occurs after the file has been opened, the function will
never close the FILE object.
This commit is contained in:
Max Kellermann 2008-09-07 13:37:33 +02:00
parent 54c8e3daaf
commit d1df71ebbc
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/storedPlaylist.c
View File

@ -301,9 +301,11 @@ int appendSongToStoredPlaylistByPath(int fd, const char *utf8path, Song *song)
if (fstat(fileno(file), &st) < 0) { if (fstat(fileno(file), &st) < 0) {
commandError(fd, ACK_ERROR_NO_EXIST, "could not stat file " commandError(fd, ACK_ERROR_NO_EXIST, "could not stat file "
"\"%s\": %s", path_max_tmp, strerror(errno)); "\"%s\": %s", path_max_tmp, strerror(errno));
while (fclose(file) != 0 && errno == EINTR);
return -1; return -1;
} }
if (st.st_size >= ((MPD_PATH_MAX+1) * playlist_max_length)) { if (st.st_size >= ((MPD_PATH_MAX+1) * playlist_max_length)) {
while (fclose(file) != 0 && errno == EINTR);
commandError(fd, ACK_ERROR_PLAYLIST_MAX, commandError(fd, ACK_ERROR_PLAYLIST_MAX,
"playlist is at the max size"); "playlist is at the max size");
return -1; return -1;