check.h: remove obsolete header

Since we switched from autotools to Meson in commit 94592c1406, we don't need to include `config.h` early to properly enable large file support. Meson passes the required macros on the compiler command line instead of defining them in `config.h`. This means we can include `config.h` at any time, whenever we want to check its macros, and there are no ordering constraints.
2018-11-19 12:49:45 +01:00
parent 2e450bbf95
commit ce49d99c2f
725 changed files with 68 additions and 888 deletions
--- a/src/db/Configured.cxx
+++ b/src/db/Configured.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "Configured.hxx"
 #include "DatabaseGlue.hxx"
 #include "config/Data.hxx"
--- a/src/db/Configured.hxx
+++ b/src/db/Configured.hxx
@@ -20,8 +20,6 @@
 #ifndef MPD_DB_CONFIG_HXX
 #define MPD_DB_CONFIG_HXX

-#include "check.h"
-
 struct ConfigData;
 class EventLoop;
 class DatabaseListener;
--- a/src/db/Count.cxx
+++ b/src/db/Count.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "Count.hxx"
 #include "Selection.hxx"
 #include "Interface.hxx"
--- a/src/db/DatabaseGlue.cxx
+++ b/src/db/DatabaseGlue.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "DatabaseGlue.hxx"
 #include "Registry.hxx"
 #include "DatabaseError.hxx"
--- a/src/db/DatabaseLock.cxx
+++ b/src/db/DatabaseLock.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "DatabaseLock.hxx"

 Mutex db_mutex;
--- a/src/db/DatabaseLock.hxx
+++ b/src/db/DatabaseLock.hxx
@@ -26,7 +26,6 @@
 #ifndef MPD_DB_LOCK_HXX
 #define MPD_DB_LOCK_HXX

-#include "check.h"
 #include "thread/Mutex.hxx"
 #include "util/Compiler.h"

--- a/src/db/DatabasePlaylist.cxx
+++ b/src/db/DatabasePlaylist.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "DatabasePlaylist.hxx"
 #include "DatabaseSong.hxx"
 #include "Selection.hxx"
--- a/src/db/DatabasePrint.cxx
+++ b/src/db/DatabasePrint.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "DatabasePrint.hxx"
 #include "Selection.hxx"
 #include "SongPrint.hxx"
--- a/src/db/DatabaseQueue.cxx
+++ b/src/db/DatabaseQueue.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "DatabaseQueue.hxx"
 #include "DatabaseSong.hxx"
 #include "Interface.hxx"
--- a/src/db/DatabaseSong.cxx
+++ b/src/db/DatabaseSong.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "DatabaseSong.hxx"
 #include "Interface.hxx"
 #include "song/DetachedSong.hxx"
--- a/src/db/PlaylistInfo.hxx
+++ b/src/db/PlaylistInfo.hxx
@@ -20,7 +20,6 @@
 #ifndef MPD_PLAYLIST_INFO_HXX
 #define MPD_PLAYLIST_INFO_HXX

-#include "check.h"
 #include "util/Compiler.h"

 #include <string>
--- a/src/db/PlaylistVector.cxx
+++ b/src/db/PlaylistVector.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "PlaylistVector.hxx"
 #include "db/DatabaseLock.hxx"

--- a/src/db/Selection.cxx
+++ b/src/db/Selection.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "Selection.hxx"
 #include "song/Filter.hxx"

--- a/src/db/VHelper.cxx
+++ b/src/db/VHelper.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "VHelper.hxx"
 #include "song/DetachedSong.hxx"
 #include "song/LightSong.hxx"
--- a/src/db/plugins/ProxyDatabasePlugin.cxx
+++ b/src/db/plugins/ProxyDatabasePlugin.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "ProxyDatabasePlugin.hxx"
 #include "db/Interface.hxx"
 #include "db/DatabasePlugin.hxx"
--- a/src/db/plugins/simple/DatabaseSave.cxx
+++ b/src/db/plugins/simple/DatabaseSave.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "DatabaseSave.hxx"
 #include "db/DatabaseLock.hxx"
 #include "Directory.hxx"
--- a/src/db/plugins/simple/Directory.cxx
+++ b/src/db/plugins/simple/Directory.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "Directory.hxx"
 #include "SongSort.hxx"
 #include "Song.hxx"
--- a/src/db/plugins/simple/Directory.hxx
+++ b/src/db/plugins/simple/Directory.hxx
@@ -20,7 +20,6 @@
 #ifndef MPD_DIRECTORY_HXX
 #define MPD_DIRECTORY_HXX

-#include "check.h"
 #include "util/Compiler.h"
 #include "db/Visitor.hxx"
 #include "db/PlaylistVector.hxx"
--- a/src/db/plugins/simple/DirectorySave.cxx
+++ b/src/db/plugins/simple/DirectorySave.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "DirectorySave.hxx"
 #include "Directory.hxx"
 #include "Song.hxx"
--- a/src/db/plugins/simple/Mount.cxx
+++ b/src/db/plugins/simple/Mount.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "Mount.hxx"
 #include "PrefixedLightSong.hxx"
 #include "song/Filter.hxx"
--- a/src/db/plugins/simple/PrefixedLightSong.hxx
+++ b/src/db/plugins/simple/PrefixedLightSong.hxx
@@ -20,7 +20,6 @@
 #ifndef MPD_DB_SIMPLE_PREFIXED_LIGHT_SONG_HXX
 #define MPD_DB_SIMPLE_PREFIXED_LIGHT_SONG_HXX

-#include "check.h"
 #include "song/LightSong.hxx"
 #include "fs/Traits.hxx"

--- a/src/db/plugins/simple/SimpleDatabasePlugin.hxx
+++ b/src/db/plugins/simple/SimpleDatabasePlugin.hxx
@@ -20,12 +20,12 @@
 #ifndef MPD_SIMPLE_DATABASE_PLUGIN_HXX
 #define MPD_SIMPLE_DATABASE_PLUGIN_HXX

-#include "check.h"
 #include "db/Interface.hxx"
 #include "fs/AllocatedPath.hxx"
 #include "song/LightSong.hxx"
 #include "util/Manual.hxx"
 #include "util/Compiler.h"
+#include "config.h"

 #include <cassert>

--- a/src/db/plugins/simple/Song.cxx
+++ b/src/db/plugins/simple/Song.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "Song.hxx"
 #include "Directory.hxx"
 #include "tag/Tag.hxx"
--- a/src/db/plugins/simple/Song.hxx
+++ b/src/db/plugins/simple/Song.hxx
@@ -20,11 +20,11 @@
 #ifndef MPD_SONG_HXX
 #define MPD_SONG_HXX

-#include "check.h"
 #include "Chrono.hxx"
 #include "tag/Tag.hxx"
 #include "AudioFormat.hxx"
 #include "util/Compiler.h"
+#include "config.h"

 #include <boost/intrusive/list.hpp>

--- a/src/db/plugins/simple/SongSort.cxx
+++ b/src/db/plugins/simple/SongSort.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "SongSort.hxx"
 #include "Song.hxx"
 #include "tag/Tag.hxx"
--- a/src/db/plugins/upnp/ContentDirectoryService.cxx
+++ b/src/db/plugins/upnp/ContentDirectoryService.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "lib/upnp/ContentDirectoryService.hxx"
 #include "lib/upnp/ixmlwrap.hxx"
 #include "lib/upnp/UniqueIxml.hxx"
--- a/src/db/plugins/upnp/Directory.cxx
+++ b/src/db/plugins/upnp/Directory.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "Directory.hxx"
 #include "lib/upnp/Util.hxx"
 #include "lib/expat/ExpatParser.hxx"
--- a/src/db/plugins/upnp/Tags.cxx
+++ b/src/db/plugins/upnp/Tags.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "Tags.hxx"
 #include "tag/Table.hxx"

--- a/src/db/plugins/upnp/UpnpDatabasePlugin.cxx
+++ b/src/db/plugins/upnp/UpnpDatabasePlugin.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "UpnpDatabasePlugin.hxx"
 #include "Directory.hxx"
 #include "Tags.hxx"
--- a/src/db/update/Archive.cxx
+++ b/src/db/update/Archive.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h" /* must be first for large file support */
 #include "Walk.hxx"
 #include "UpdateDomain.hxx"
 #include "db/DatabaseLock.hxx"
--- a/src/db/update/Config.cxx
+++ b/src/db/update/Config.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "Config.hxx"
 #include "config/Data.hxx"
 #include "config/Option.hxx"
--- a/src/db/update/Config.hxx
+++ b/src/db/update/Config.hxx
@@ -20,8 +20,6 @@
 #ifndef MPD_UPDATE_CONFIG_HXX
 #define MPD_UPDATE_CONFIG_HXX

-#include "check.h"
-
 struct ConfigData;

 struct UpdateConfig {
--- a/src/db/update/Container.cxx
+++ b/src/db/update/Container.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h" /* must be first for large file support */
 #include "Walk.hxx"
 #include "UpdateDomain.hxx"
 #include "song/DetachedSong.hxx"
--- a/src/db/update/Editor.cxx
+++ b/src/db/update/Editor.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h" /* must be first for large file support */
 #include "Editor.hxx"
 #include "Remove.hxx"
 #include "db/PlaylistVector.hxx"
--- a/src/db/update/Editor.hxx
+++ b/src/db/update/Editor.hxx
@@ -20,7 +20,6 @@
 #ifndef MPD_UPDATE_DATABASE_HXX
 #define MPD_UPDATE_DATABASE_HXX

-#include "check.h"
 #include "Remove.hxx"
 #include "util/Compiler.h"

--- a/src/db/update/ExcludeList.cxx
+++ b/src/db/update/ExcludeList.cxx
@@ -22,13 +22,13 @@
 *
 */

-#include "config.h"
 #include "ExcludeList.hxx"
 #include "fs/Path.hxx"
 #include "fs/NarrowPath.hxx"
 #include "input/TextInputStream.hxx"
 #include "util/StringStrip.hxx"
 #include "Log.hxx"
+#include "config.h"

 #include <exception>

--- a/src/db/update/ExcludeList.hxx
+++ b/src/db/update/ExcludeList.hxx
@@ -25,10 +25,10 @@
 #ifndef MPD_EXCLUDE_H
 #define MPD_EXCLUDE_H

-#include "check.h"
 #include "util/Compiler.h"
 #include "fs/Glob.hxx"
 #include "input/Ptr.hxx"
+#include "config.h"

 #ifdef HAVE_CLASS_GLOB
 #include <forward_list>
--- a/src/db/update/InotifyQueue.cxx
+++ b/src/db/update/InotifyQueue.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "InotifyQueue.hxx"
 #include "InotifyDomain.hxx"
 #include "Service.hxx"
--- a/src/db/update/InotifySource.cxx
+++ b/src/db/update/InotifySource.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "InotifySource.hxx"
 #include "InotifyDomain.hxx"
 #include "system/FileDescriptor.hxx"
--- a/src/db/update/InotifyUpdate.cxx
+++ b/src/db/update/InotifyUpdate.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h" /* must be first for large file support */
 #include "InotifyUpdate.hxx"
 #include "InotifySource.hxx"
 #include "InotifyQueue.hxx"
--- a/src/db/update/InotifyUpdate.hxx
+++ b/src/db/update/InotifyUpdate.hxx
@@ -20,7 +20,6 @@
 #ifndef MPD_INOTIFY_UPDATE_HXX
 #define MPD_INOTIFY_UPDATE_HXX

-#include "check.h"
 #include "util/Compiler.h"

 class EventLoop;
--- a/src/db/update/Queue.cxx
+++ b/src/db/update/Queue.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "Queue.hxx"

 bool
--- a/src/db/update/Queue.hxx
+++ b/src/db/update/Queue.hxx
@@ -20,7 +20,6 @@
 #ifndef MPD_UPDATE_QUEUE_HXX
 #define MPD_UPDATE_QUEUE_HXX

-#include "check.h"
 #include "util/Compiler.h"

 #include <string>
--- a/src/db/update/Remove.cxx
+++ b/src/db/update/Remove.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h" /* must be first for large file support */
 #include "Remove.hxx"
 #include "UpdateDomain.hxx"
 #include "db/DatabaseListener.hxx"
--- a/src/db/update/Remove.hxx
+++ b/src/db/update/Remove.hxx
@@ -20,7 +20,6 @@
 #ifndef MPD_UPDATE_REMOVE_HXX
 #define MPD_UPDATE_REMOVE_HXX

-#include "check.h"
 #include "event/DeferEvent.hxx"
 #include "thread/Mutex.hxx"
 #include "util/Compiler.h"
--- a/src/db/update/Service.cxx
+++ b/src/db/update/Service.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h"
 #include "Service.hxx"
 #include "Walk.hxx"
 #include "UpdateDomain.hxx"
--- a/src/db/update/Service.hxx
+++ b/src/db/update/Service.hxx
@@ -20,7 +20,6 @@
 #ifndef MPD_UPDATE_SERVICE_HXX
 #define MPD_UPDATE_SERVICE_HXX

-#include "check.h"
 #include "Config.hxx"
 #include "Queue.hxx"
 #include "event/DeferEvent.hxx"
--- a/src/db/update/UpdateIO.cxx
+++ b/src/db/update/UpdateIO.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h" /* must be first for large file support */
 #include "UpdateIO.hxx"
 #include "db/plugins/simple/Directory.hxx"
 #include "storage/FileInfo.hxx"
--- a/src/db/update/UpdateIO.hxx
+++ b/src/db/update/UpdateIO.hxx
@@ -20,7 +20,6 @@
 #ifndef MPD_UPDATE_IO_HXX
 #define MPD_UPDATE_IO_HXX

-#include "check.h"
 #include "util/Compiler.h"

 struct Directory;
--- a/src/db/update/UpdateSong.cxx
+++ b/src/db/update/UpdateSong.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h" /* must be first for large file support */
 #include "Walk.hxx"
 #include "UpdateIO.hxx"
 #include "UpdateDomain.hxx"
--- a/src/db/update/Walk.cxx
+++ b/src/db/update/Walk.cxx
@@ -17,7 +17,6 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

-#include "config.h" /* must be first for large file support */
 #include "Walk.hxx"
 #include "UpdateIO.hxx"
 #include "Editor.hxx"
--- a/src/db/update/Walk.hxx
+++ b/src/db/update/Walk.hxx
@@ -20,10 +20,10 @@
 #ifndef MPD_UPDATE_WALK_HXX
 #define MPD_UPDATE_WALK_HXX

-#include "check.h"
 #include "Config.hxx"
 #include "Editor.hxx"
 #include "util/Compiler.h"
+#include "config.h"

 #include <atomic>