oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

DecoderAPI: pass rvalue reference to decoder_tag()

Browse Source 
Avoid duplicating the tag.
This commit is contained in:
Max Kellermann
2013-07-31 00:34:22 +02:00
parent 06f898cc12
commit cbd38327e7
9 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/decoder/MadDecoderPlugin.cxx
View File

@@ -1084,7 +1084,8 @@ MadDecoder::Read()
ret = DecodeNextFrameHeader(&tag);
if (tag != nullptr) {
decoder_tag(decoder, input_stream, tag);
decoder_tag(decoder, input_stream,
std::move(*tag));
delete tag;
}
} while (ret == DECODE_CONT);
@@ -1142,7 +1143,7 @@ mp3_decode(struct decoder *decoder, struct input_stream *input_stream)
data.total_time);
if (tag != nullptr) {
decoder_tag(decoder, input_stream, tag);
decoder_tag(decoder, input_stream, std::move(*tag));
delete tag;
}